From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: add guard macros of unistd.h to prevent double inclusion
Date: Thu, 11 Sep 2014 16:02:12 +0100 [thread overview]
Message-ID: <20140911150212.GP6158@arm.com> (raw)
In-Reply-To: <5411698E.3000402@huawei.com>
On Thu, Sep 11, 2014 at 10:21:18AM +0100, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> Add guard macros for uapi/asm/unistd.h, asm/unistd.h and
> asm/unistd32.h.
Hmm, so I applied this and now my machine panics when we hit userspace. I
think the issue is that we no longer generate our syscall table in
arch/arm64/kernel/sys.c, because unistd.h is already included via
linux/syscalls.h but without the __SYSCALL definition.
So, a couple of questions:
(1) Is the lack of header guards actually causing you a problem?
(2) How did you test this?
I've dropped the patch.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [PATCH v2] arm64: add guard macros of unistd.h to prevent double inclusion
Date: Thu, 11 Sep 2014 16:02:12 +0100 [thread overview]
Message-ID: <20140911150212.GP6158@arm.com> (raw)
In-Reply-To: <5411698E.3000402@huawei.com>
On Thu, Sep 11, 2014 at 10:21:18AM +0100, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> Add guard macros for uapi/asm/unistd.h, asm/unistd.h and
> asm/unistd32.h.
Hmm, so I applied this and now my machine panics when we hit userspace. I
think the issue is that we no longer generate our syscall table in
arch/arm64/kernel/sys.c, because unistd.h is already included via
linux/syscalls.h but without the __SYSCALL definition.
So, a couple of questions:
(1) Is the lack of header guards actually causing you a problem?
(2) How did you test this?
I've dropped the patch.
Will
next prev parent reply other threads:[~2014-09-11 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 3:59 [PATCH] arm64: add guard macro of unistd.h to prevent double inclusion Yang Yingliang
2014-09-09 3:59 ` Yang Yingliang
2014-09-09 12:39 ` Will Deacon
2014-09-09 12:39 ` Will Deacon
2014-09-11 7:55 ` Yang Yingliang
2014-09-11 7:55 ` Yang Yingliang
2014-09-11 9:21 ` [PATCH v2] arm64: add guard macros " Yang Yingliang
2014-09-11 9:21 ` Yang Yingliang
2014-09-11 15:02 ` Will Deacon [this message]
2014-09-11 15:02 ` Will Deacon
2014-09-12 9:03 ` Yang Yingliang
2014-09-12 9:03 ` Yang Yingliang
2014-09-11 15:14 ` [PATCH] arm64: add guard macro " Arnd Bergmann
2014-09-11 15:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911150212.GP6158@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.