From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: atmel_nand: retrieve NFC clock
Date: Thu, 11 Sep 2014 17:38:54 +0200 [thread overview]
Message-ID: <20140911173854.73b201e7@bbrezillon> (raw)
In-Reply-To: <20140911152029.GA16666@arch>
Hi Ezequiel,
On Thu, 11 Sep 2014 12:20:30 -0300
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:
> Hi Alexandre,
>
> On 11 Sep 04:43 PM, Alexandre Belloni wrote:
> > @@ -2276,6 +2280,16 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + nfc->clk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(nfc->clk)) {
> > + dev_warn(&pdev->dev, "NFC clock is missing");
> > + return 0;
> > + }
> > +
>
> The binding documentation makes no mention to a clock.
You're right, I didn't update atmel,nand DT binding doc.
>
> Anyway, with or without the docs I think this patch breaks DT backward
> compatibility.
>
> Or am I missing something?
Indeed, this block of code should be placed at the end of the probe
function. I'll fix that.
Note that if the clk is missing it just print a warning message and
return 0, so after moving the code, it should not break DT backward
compat ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: atmel_nand: retrieve NFC clock
Date: Thu, 11 Sep 2014 17:38:54 +0200 [thread overview]
Message-ID: <20140911173854.73b201e7@bbrezillon> (raw)
In-Reply-To: <20140911152029.GA16666@arch>
Hi Ezequiel,
On Thu, 11 Sep 2014 12:20:30 -0300
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:
> Hi Alexandre,
>
> On 11 Sep 04:43 PM, Alexandre Belloni wrote:
> > @@ -2276,6 +2280,16 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + nfc->clk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(nfc->clk)) {
> > + dev_warn(&pdev->dev, "NFC clock is missing");
> > + return 0;
> > + }
> > +
>
> The binding documentation makes no mention to a clock.
You're right, I didn't update atmel,nand DT binding doc.
>
> Anyway, with or without the docs I think this patch breaks DT backward
> compatibility.
>
> Or am I missing something?
Indeed, this block of code should be placed at the end of the probe
function. I'll fix that.
Note that if the clk is missing it just print a warning message and
return 0, so after moving the code, it should not break DT backward
compat ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: atmel_nand: retrieve NFC clock
Date: Thu, 11 Sep 2014 17:38:54 +0200 [thread overview]
Message-ID: <20140911173854.73b201e7@bbrezillon> (raw)
In-Reply-To: <20140911152029.GA16666@arch>
Hi Ezequiel,
On Thu, 11 Sep 2014 12:20:30 -0300
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:
> Hi Alexandre,
>
> On 11 Sep 04:43 PM, Alexandre Belloni wrote:
> > @@ -2276,6 +2280,16 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + nfc->clk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(nfc->clk)) {
> > + dev_warn(&pdev->dev, "NFC clock is missing");
> > + return 0;
> > + }
> > +
>
> The binding documentation makes no mention to a clock.
You're right, I didn't update atmel,nand DT binding doc.
>
> Anyway, with or without the docs I think this patch breaks DT backward
> compatibility.
>
> Or am I missing something?
Indeed, this block of code should be placed at the end of the probe
function. I'll fix that.
Note that if the clk is missing it just print a warning message and
return 0, so after moving the code, it should not break DT backward
compat ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-11 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 14:43 [PATCH] mtd: nand: atmel_nand: retrieve NFC clock Alexandre Belloni
2014-09-11 14:43 ` Alexandre Belloni
2014-09-11 14:43 ` Alexandre Belloni
2014-09-11 15:20 ` Ezequiel Garcia
2014-09-11 15:20 ` Ezequiel Garcia
2014-09-11 15:20 ` Ezequiel Garcia
2014-09-11 15:38 ` Boris BREZILLON [this message]
2014-09-11 15:38 ` Boris BREZILLON
2014-09-11 15:38 ` Boris BREZILLON
2014-09-11 22:05 ` Thomas Petazzoni
2014-09-11 22:05 ` Thomas Petazzoni
2014-09-11 22:05 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911173854.73b201e7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.