From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@freescale.com>, timur@tabi.org
Cc: Li.Xiubo@freescale.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.de, mpa@pengutronix.de,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Fri, 12 Sep 2014 11:33:24 -0700 [thread overview]
Message-ID: <20140912183324.GA2738@Alpha> (raw)
In-Reply-To: <894383e00876763f22988fc5f3f9f232f939f923.1410517971.git.shengjiu.wang@freescale.com>
On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote:
> Check if ipg clock is in clock-names property, then we can move the
> ipg clock enable and disable operation to startup and shutdown, that
> is only enable ipg clock when ssi is working and keep clock is disabled
> when ssi is in idle.
> But when the checking is failed, remain the clock control as before.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
The patch looks fine to me. I tested the has_ipg_clk_name == true
case, and it works fine. As long as there's no further objection,
I can give an Acked-by. (I think Timur and Markus may like to have
a test as well.)
Thank you
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shengjiu Wang <shengjiu.wang@freescale.com>, timur@tabi.org
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz,
broonie@kernel.org, mpa@pengutronix.de,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Fri, 12 Sep 2014 11:33:24 -0700 [thread overview]
Message-ID: <20140912183324.GA2738@Alpha> (raw)
In-Reply-To: <894383e00876763f22988fc5f3f9f232f939f923.1410517971.git.shengjiu.wang@freescale.com>
On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote:
> Check if ipg clock is in clock-names property, then we can move the
> ipg clock enable and disable operation to startup and shutdown, that
> is only enable ipg clock when ssi is working and keep clock is disabled
> when ssi is in idle.
> But when the checking is failed, remain the clock control as before.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
The patch looks fine to me. I tested the has_ipg_clk_name == true
case, and it works fine. As long as there's no further objection,
I can give an Acked-by. (I think Timur and Markus may like to have
a test as well.)
Thank you
Nicolin
next prev parent reply other threads:[~2014-09-12 18:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:35 [PATCH V3] ASoC: fsl_ssi: refine ipg clock usage in this module Shengjiu Wang
2014-09-12 10:35 ` Shengjiu Wang
2014-09-12 10:35 ` Shengjiu Wang
2014-09-12 18:33 ` Nicolin Chen [this message]
2014-09-12 18:33 ` Nicolin Chen
2014-09-12 20:02 ` Michael Trimarchi
2014-09-12 20:02 ` [alsa-devel] " Michael Trimarchi
2014-09-15 10:05 ` Markus Pargmann
2014-09-15 10:05 ` Markus Pargmann
2014-09-15 10:22 ` Shengjiu Wang
2014-09-15 10:22 ` Shengjiu Wang
2014-09-15 10:22 ` Shengjiu Wang
2014-09-15 10:32 ` Markus Pargmann
2014-09-15 10:32 ` Markus Pargmann
2014-09-15 10:37 ` Shengjiu Wang
2014-09-15 10:37 ` Shengjiu Wang
2014-09-15 10:37 ` Shengjiu Wang
2014-09-15 13:52 ` Markus Pargmann
2014-09-15 13:52 ` Markus Pargmann
2014-09-15 13:52 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912183324.GA2738@Alpha \
--to=nicoleotsuka@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpa@pengutronix.de \
--cc=perex@perex.cz \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.