From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Dave Airlie <airlied@redhat.com>,
virtio-dev@lists.oasis-open.org,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file
Date: Sun, 14 Sep 2014 17:11:58 +0300 [thread overview]
Message-ID: <20140914141158.GA27836@redhat.com> (raw)
In-Reply-To: <CAFEAcA8f8kKoDwCd4-rVYHQZXJQSXZcJiqMVRMVzWRvFwUDNRA@mail.gmail.com>
On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote:
> On 14 September 2014 06:46, Michael S. Tsirkin <mst@redhat.com> wrote:
> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU.
> > You have to stick it in a C file though, so it
> > won't be visible in this patch.
>
> Why do you think that? We have several header files which
> use QEMU_BUILD_BUG_ON and I don't see any reason why
> it would have to be invoked from a .c file.
>
> -- PMM
Because Gerd wants to share this with linux uapi, and
you can't use BUILD_BUG_ON in uapi headers on linux.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Dave Airlie <airlied@redhat.com>,
virtio-dev@lists.oasis-open.org,
Gerd Hoffmann <kraxel@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file
Date: Sun, 14 Sep 2014 17:11:58 +0300 [thread overview]
Message-ID: <20140914141158.GA27836@redhat.com> (raw)
In-Reply-To: <CAFEAcA8f8kKoDwCd4-rVYHQZXJQSXZcJiqMVRMVzWRvFwUDNRA@mail.gmail.com>
On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote:
> On 14 September 2014 06:46, Michael S. Tsirkin <mst@redhat.com> wrote:
> > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU.
> > You have to stick it in a C file though, so it
> > won't be visible in this patch.
>
> Why do you think that? We have several header files which
> use QEMU_BUILD_BUG_ON and I don't see any reason why
> it would have to be invoked from a .c file.
>
> -- PMM
Because Gerd wants to share this with linux uapi, and
you can't use BUILD_BUG_ON in uapi headers on linux.
next prev parent reply other threads:[~2014-09-14 14:11 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 15:09 [PATCH 0/2] virtio-gpu: hardware specification Gerd Hoffmann
2014-09-11 15:09 ` [Qemu-devel] " Gerd Hoffmann
2014-09-11 15:09 ` [PATCH 1/2] virtio-gpu/2d: add hardware spec include file Gerd Hoffmann
2014-09-11 15:09 ` [Qemu-devel] " Gerd Hoffmann
2014-09-11 15:15 ` Peter Maydell
2014-09-11 15:40 ` Gerd Hoffmann
2014-09-11 15:15 ` Peter Maydell
2014-09-11 15:19 ` Eric Blake
2014-09-12 10:44 ` Gerd Hoffmann
2014-09-12 12:48 ` Eric Blake
2014-09-12 12:48 ` Eric Blake
2014-09-12 12:51 ` Eric Blake
2014-09-12 12:51 ` Eric Blake
2014-09-12 13:03 ` Peter Maydell
2014-09-12 13:03 ` Peter Maydell
2014-09-14 13:46 ` Michael S. Tsirkin
2014-09-14 13:46 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-14 14:04 ` Peter Maydell
2014-09-14 14:04 ` Peter Maydell
2014-09-14 14:11 ` Michael S. Tsirkin [this message]
2014-09-14 14:11 ` Michael S. Tsirkin
2014-09-14 14:32 ` Peter Maydell
2014-09-14 14:32 ` Peter Maydell
2014-09-14 15:09 ` Michael S. Tsirkin
2014-09-14 15:09 ` Michael S. Tsirkin
2014-09-14 16:11 ` Peter Maydell
2014-09-14 16:11 ` Peter Maydell
2014-09-14 16:31 ` Michael S. Tsirkin
2014-09-14 16:31 ` Michael S. Tsirkin
2014-09-15 10:36 ` Gerd Hoffmann
2014-09-15 10:40 ` Gerd Hoffmann
2014-09-15 10:40 ` [Qemu-devel] " Gerd Hoffmann
2014-09-15 10:55 ` Michael S. Tsirkin
2014-09-15 10:55 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-11 15:19 ` Eric Blake
2014-09-11 15:20 ` Peter Maydell
2014-09-11 15:43 ` Gerd Hoffmann
2014-09-11 15:53 ` Christopher Covington
2014-09-11 18:58 ` [virtio-dev] " Paolo Bonzini
2014-09-11 18:58 ` [Qemu-devel] [virtio-dev] " Paolo Bonzini
2014-09-11 15:09 ` [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt Gerd Hoffmann
2014-09-11 15:09 ` [Qemu-devel] " Gerd Hoffmann
2014-09-11 15:30 ` Eric Blake
2014-09-12 11:08 ` Gerd Hoffmann
2014-09-11 15:30 ` Eric Blake
2014-09-12 9:10 ` [virtio-dev] " Stefan Hajnoczi
2014-09-12 9:10 ` [Qemu-devel] " Stefan Hajnoczi
2014-09-12 11:38 ` Gerd Hoffmann
2014-09-12 11:38 ` [Qemu-devel] " Gerd Hoffmann
2014-09-12 21:14 ` Dave Airlie
2014-09-12 21:14 ` [Qemu-devel] " Dave Airlie
2014-09-15 10:14 ` Gerd Hoffmann
2014-09-15 10:14 ` [Qemu-devel] " Gerd Hoffmann
2014-09-14 9:16 ` Michael S. Tsirkin
2014-09-14 9:16 ` [Qemu-devel] " Michael S. Tsirkin
2014-09-14 11:05 ` [virtio-dev] " Dave Airlie
2014-09-14 11:05 ` [Qemu-devel] " Dave Airlie
2014-09-12 21:18 ` [virtio-dev] [PATCH 0/2] virtio-gpu: hardware specification Dave Airlie
2014-09-12 21:18 ` [Qemu-devel] " Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140914141158.GA27836@redhat.com \
--to=mst@redhat.com \
--cc=airlied@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.