From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: Vladislav Yasevich <vyasevic@redhat.com>,
netdev@vger.kernel.org, shemminger@vyatta.com,
bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH 0/3] bridge: Some nice new things for vlan filtering
Date: Mon, 15 Sep 2014 09:24:05 -0700 [thread overview]
Message-ID: <20140915092405.124ff9d0@urahara> (raw)
In-Reply-To: <1410554691-18467-1-git-send-email-vyasevic@redhat.com>
On Fri, 12 Sep 2014 16:44:48 -0400
Vladislav Yasevich <vyasevich@gmail.com> wrote:
> While working with vlan filtering and non-promisc mode, I've found
> myself wanting untagged traffic to automatically pass through the
> bridge. So I decided to introduce the concept of a per bridge default
> pvid. VLAN 1 is used as default pvid by default and can be changed
> by user through sysfs while vlan filtering is off. (I'll be adding netlink
> support now that Jiri Pirko kindly added the ifrastructure). Default
> pvid is assigned to all ports that do not assign their own pvid or
> already have a given vlan configured. This makes it very simple
> to enable vlan filtering on the bridge, not have to configure a thing,
> and still pass untagged traffic.
>
> The other small thing this series adds is automatic update of the
> vlan filter when vlan is configured on top of the bridge. In this
> case we automatically add the given vlan to the bridge filter list.
> The ports may still need to be updated as we don't know which ports
> are allowed to receive a given vlan.
>
> Thanks
> -vlad
>
> Vladislav Yasevich (3):
> bridge: Add a default_pvid sysfs attribute
> bridge: Add filtering support for default_pvid
> bridge; Automatically filter vlans configured on top of bridge
>
> net/bridge/br_device.c | 54 +++++++++++++++++++---
> net/bridge/br_if.c | 2 +
> net/bridge/br_private.h | 35 ++++++++++++++-
> net/bridge/br_sysfs_br.c | 17 +++++++
> net/bridge/br_vlan.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++-
> 5 files changed, 213 insertions(+), 8 deletions(-)
>
Please, no special VLAN 1, other equipment has that silliness.
Why is untagged traffic not treated as VLAN 0?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladislav Yasevich <vyasevich@gmail.com>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
bridge@lists.linux-foundation.org,
Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
Vladislav Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH 0/3] bridge: Some nice new things for vlan filtering
Date: Mon, 15 Sep 2014 09:24:05 -0700 [thread overview]
Message-ID: <20140915092405.124ff9d0@urahara> (raw)
In-Reply-To: <1410554691-18467-1-git-send-email-vyasevic@redhat.com>
On Fri, 12 Sep 2014 16:44:48 -0400
Vladislav Yasevich <vyasevich@gmail.com> wrote:
> While working with vlan filtering and non-promisc mode, I've found
> myself wanting untagged traffic to automatically pass through the
> bridge. So I decided to introduce the concept of a per bridge default
> pvid. VLAN 1 is used as default pvid by default and can be changed
> by user through sysfs while vlan filtering is off. (I'll be adding netlink
> support now that Jiri Pirko kindly added the ifrastructure). Default
> pvid is assigned to all ports that do not assign their own pvid or
> already have a given vlan configured. This makes it very simple
> to enable vlan filtering on the bridge, not have to configure a thing,
> and still pass untagged traffic.
>
> The other small thing this series adds is automatic update of the
> vlan filter when vlan is configured on top of the bridge. In this
> case we automatically add the given vlan to the bridge filter list.
> The ports may still need to be updated as we don't know which ports
> are allowed to receive a given vlan.
>
> Thanks
> -vlad
>
> Vladislav Yasevich (3):
> bridge: Add a default_pvid sysfs attribute
> bridge: Add filtering support for default_pvid
> bridge; Automatically filter vlans configured on top of bridge
>
> net/bridge/br_device.c | 54 +++++++++++++++++++---
> net/bridge/br_if.c | 2 +
> net/bridge/br_private.h | 35 ++++++++++++++-
> net/bridge/br_sysfs_br.c | 17 +++++++
> net/bridge/br_vlan.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++-
> 5 files changed, 213 insertions(+), 8 deletions(-)
>
Please, no special VLAN 1, other equipment has that silliness.
Why is untagged traffic not treated as VLAN 0?
next prev parent reply other threads:[~2014-09-15 16:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 20:44 [Bridge] [PATCH 0/3] bridge: Some nice new things for vlan filtering Vladislav Yasevich
2014-09-12 20:44 ` Vladislav Yasevich
2014-09-12 20:44 ` [Bridge] [PATCH 1/3] bridge: Add a default_pvid sysfs attribute Vladislav Yasevich
2014-09-12 20:44 ` Vladislav Yasevich
2014-09-12 20:44 ` [Bridge] [PATCH 2/3] bridge: Add filtering support for default_pvid Vladislav Yasevich
2014-09-12 20:44 ` Vladislav Yasevich
2014-09-14 15:21 ` [Bridge] " Toshiaki Makita
2014-09-14 15:21 ` Toshiaki Makita
2014-09-15 15:09 ` [Bridge] " Vlad Yasevich
2014-09-16 11:10 ` Toshiaki Makita
2014-09-16 11:10 ` Toshiaki Makita
2014-09-16 13:23 ` [Bridge] " Vlad Yasevich
2014-09-16 13:23 ` Vlad Yasevich
2014-09-12 20:44 ` [Bridge] [PATCH 3/3] bridge; Automatically filter vlans configured on top of bridge Vladislav Yasevich
2014-09-12 20:44 ` Vladislav Yasevich
2014-09-14 15:39 ` [Bridge] " Toshiaki Makita
2014-09-15 15:19 ` Vlad Yasevich
2014-09-15 15:19 ` Vlad Yasevich
2014-09-16 11:28 ` [Bridge] " Toshiaki Makita
2014-09-16 11:28 ` Toshiaki Makita
2014-09-16 13:31 ` [Bridge] " Vlad Yasevich
2014-09-16 13:31 ` Vlad Yasevich
2014-09-16 14:39 ` [Bridge] " Toshiaki Makita
2014-09-16 14:39 ` Toshiaki Makita
2014-09-16 15:00 ` [Bridge] " Vlad Yasevich
2014-09-16 15:00 ` Vlad Yasevich
2014-09-17 0:25 ` [Bridge] " Toshiaki Makita
2014-09-17 0:25 ` Toshiaki Makita
2014-09-17 14:14 ` [Bridge] " Vlad Yasevich
2014-09-17 14:14 ` Vlad Yasevich
2014-09-18 9:47 ` [Bridge] " Toshiaki Makita
2014-09-18 9:47 ` Toshiaki Makita
2014-09-15 16:24 ` Stephen Hemminger [this message]
2014-09-15 16:24 ` [PATCH 0/3] bridge: Some nice new things for vlan filtering Stephen Hemminger
2014-09-16 11:38 ` [Bridge] " Toshiaki Makita
2014-09-16 11:38 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915092405.124ff9d0@urahara \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.