From: Catalin Marinas <catalin.marinas@arm.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "graeme.gregory@linaro.org" <graeme.gregory@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
Rob Herring <robh@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Robert Richter <rric@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Robert Moore <robert.moore@intel.com>,
Will Deacon <Will.Deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>, Olof Johansson <olof@lixom.net>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Lv Zheng <lv.zheng@intel.com>
Subject: Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI
Date: Mon, 15 Sep 2014 10:24:56 +0100 [thread overview]
Message-ID: <20140915092456.GB1577@arm.com> (raw)
In-Reply-To: <20140915040844.12D19C40A02@trevor.secretlab.ca>
On Mon, Sep 15, 2014 at 05:08:44AM +0100, Grant Likely wrote:
> On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory <graeme.gregory@linaro.org> wrote:
> > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote:
> > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote:
> > > > +#ifdef CONFIG_ACPI
> > > > +/* Configure some sensible defaults for ACPI mode */
> > > > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config,
> > > > + acpi_handle *ahandle)
> > > > +{
> > > > + if (!ahandle)
> > > > + return -ENOSYS;
> > > > +
> > > > + config->phy_interface = PHY_INTERFACE_MODE_MII;
> > > >
> > >
> > > Please remove the #ifdef and use
> > >
> > > if (!IS_ENABLED(CONFIG_ACPI) || !ahandle)
> > >
> > > to check for ACPI support. This should result in the same object code
> > > in all cases, but give better compile-time coverage when ACPI is
> > > disabled.
> > >
> > struct acpi_handle does not exist in the case !CONFIG_ACPI
> >
> > > Also, -ENOSYS is probably the wrong return value. I think you mean
> > > -ENXIO.
> > >
> > Yes that would make sense thanks.
> >
> > Not sure if we are planning to actually upstream this patch, I guess it
> > depends if ARM start shipping Junos with the ACPI tables loaded on them.
>
> I think we do want this upstreamed. Juno is intended to be a readily
> available reference platform, regardless of the firmware loaded when
> shipped. There will be users who use it as a test platform for ACPI
> development.
The patches for Juno are not intrusive. The only problem I have is
giving the wrong example on how to deal with the platform-specific
device information like this patch. I would much prefer to use _DSD
(once we agree on how to do this) than hard-coding information based on
the ACPI device id (you would need one for each SoC). I don't think we
have reached an agreement yet:
https://lkml.kernel.org/g/4816592.tj3on6vUaC@wuerfel
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI
Date: Mon, 15 Sep 2014 10:24:56 +0100 [thread overview]
Message-ID: <20140915092456.GB1577@arm.com> (raw)
In-Reply-To: <20140915040844.12D19C40A02@trevor.secretlab.ca>
On Mon, Sep 15, 2014 at 05:08:44AM +0100, Grant Likely wrote:
> On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory <graeme.gregory@linaro.org> wrote:
> > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote:
> > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote:
> > > > +#ifdef CONFIG_ACPI
> > > > +/* Configure some sensible defaults for ACPI mode */
> > > > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config,
> > > > + acpi_handle *ahandle)
> > > > +{
> > > > + if (!ahandle)
> > > > + return -ENOSYS;
> > > > +
> > > > + config->phy_interface = PHY_INTERFACE_MODE_MII;
> > > >
> > >
> > > Please remove the #ifdef and use
> > >
> > > if (!IS_ENABLED(CONFIG_ACPI) || !ahandle)
> > >
> > > to check for ACPI support. This should result in the same object code
> > > in all cases, but give better compile-time coverage when ACPI is
> > > disabled.
> > >
> > struct acpi_handle does not exist in the case !CONFIG_ACPI
> >
> > > Also, -ENOSYS is probably the wrong return value. I think you mean
> > > -ENXIO.
> > >
> > Yes that would make sense thanks.
> >
> > Not sure if we are planning to actually upstream this patch, I guess it
> > depends if ARM start shipping Junos with the ACPI tables loaded on them.
>
> I think we do want this upstreamed. Juno is intended to be a readily
> available reference platform, regardless of the firmware loaded when
> shipped. There will be users who use it as a test platform for ACPI
> development.
The patches for Juno are not intrusive. The only problem I have is
giving the wrong example on how to deal with the platform-specific
device information like this patch. I would much prefer to use _DSD
(once we agree on how to do this) than hard-coding information based on
the ACPI device id (you would need one for each SoC). I don't think we
have reached an agreement yet:
https://lkml.kernel.org/g/4816592.tj3on6vUaC at wuerfel
--
Catalin
next prev parent reply other threads:[~2014-09-15 9:25 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:05 [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Hanjun Guo
2014-09-01 15:05 ` Hanjun Guo
2014-09-01 15:06 ` [RFC PATCH for Juno 1/2] net: smsc911x add support for probing " Hanjun Guo
2014-09-01 15:06 ` Hanjun Guo
2014-09-01 15:17 ` [Linaro-acpi] " Arnd Bergmann
2014-09-01 15:17 ` Arnd Bergmann
2014-09-01 15:28 ` Graeme Gregory
2014-09-01 15:28 ` Graeme Gregory
2014-09-01 15:32 ` Arnd Bergmann
2014-09-01 15:32 ` Arnd Bergmann
2014-09-01 16:53 ` Catalin Marinas
2014-09-01 16:53 ` Catalin Marinas
2014-09-01 16:58 ` Mark Brown
2014-09-01 16:58 ` Mark Brown
2014-09-01 17:08 ` Sudeep Holla
2014-09-01 17:08 ` Sudeep Holla
2014-09-01 17:14 ` Catalin Marinas
2014-09-01 17:14 ` Catalin Marinas
2014-09-01 17:33 ` Sudeep Holla
2014-09-01 17:33 ` Sudeep Holla
2014-09-01 17:33 ` Sudeep Holla
2014-09-01 17:03 ` Graeme Gregory
2014-09-01 17:03 ` Graeme Gregory
2014-09-15 4:08 ` Grant Likely
2014-09-15 4:08 ` Grant Likely
2014-09-15 9:24 ` Catalin Marinas [this message]
2014-09-15 9:24 ` Catalin Marinas
2014-09-01 17:04 ` Catalin Marinas
2014-09-01 17:04 ` Catalin Marinas
2014-09-01 17:04 ` Catalin Marinas
2014-09-01 17:11 ` Arnd Bergmann
2014-09-01 17:11 ` Arnd Bergmann
2014-09-01 17:11 ` Arnd Bergmann
2014-09-01 17:27 ` Catalin Marinas
2014-09-01 17:27 ` Catalin Marinas
2014-09-01 17:27 ` Catalin Marinas
2014-09-01 17:32 ` Graeme Gregory
2014-09-01 17:32 ` Graeme Gregory
2014-09-01 17:32 ` Graeme Gregory
2014-09-01 18:11 ` Mark Brown
2014-09-01 18:11 ` Mark Brown
2014-09-01 18:11 ` Mark Brown
2014-09-02 13:26 ` Catalin Marinas
2014-09-02 13:26 ` Catalin Marinas
2014-09-02 13:26 ` Catalin Marinas
2014-09-02 13:42 ` [Linaro-acpi] " Arnd Bergmann
2014-09-02 13:42 ` Arnd Bergmann
2014-09-02 16:26 ` Mark Brown
2014-09-02 16:26 ` Mark Brown
2014-09-02 23:00 ` Rafael J. Wysocki
2014-09-02 23:00 ` Rafael J. Wysocki
2014-09-03 15:09 ` Arnd Bergmann
2014-09-03 15:09 ` Arnd Bergmann
2014-09-09 6:51 ` Jon Masters
2014-09-09 6:51 ` Jon Masters
2014-09-15 4:14 ` Grant Likely
2014-09-15 4:14 ` Grant Likely
2014-09-15 4:14 ` Grant Likely
2014-09-15 16:12 ` Mark Brown
2014-09-15 16:12 ` Mark Brown
2014-09-15 16:12 ` Mark Brown
2014-09-01 15:06 ` [RFC PATCH for Juno 2/2] tty: SBSA compatible UART Hanjun Guo
2014-09-01 15:06 ` Hanjun Guo
2014-09-01 15:26 ` Mark Brown
2014-09-01 15:26 ` Mark Brown
2014-09-01 15:26 ` Mark Brown
2014-09-01 17:12 ` Catalin Marinas
2014-09-01 17:12 ` Catalin Marinas
2014-09-01 17:12 ` Catalin Marinas
2014-09-01 17:18 ` Graeme Gregory
2014-09-01 17:18 ` Graeme Gregory
2014-09-01 17:18 ` Graeme Gregory
2014-09-01 17:29 ` Catalin Marinas
2014-09-01 17:29 ` Catalin Marinas
2014-09-01 17:29 ` Catalin Marinas
2014-09-01 15:29 ` [RFC PATCH for Juno 0/2] Drivers for Juno to boot from ACPI Arnd Bergmann
2014-09-01 15:29 ` Arnd Bergmann
2014-09-01 15:29 ` Arnd Bergmann
2014-09-09 6:55 ` Jon Masters
2014-09-09 6:55 ` Jon Masters
2014-09-09 10:55 ` Arnd Bergmann
2014-09-09 10:55 ` Arnd Bergmann
2014-09-09 14:13 ` Jon Masters
2014-09-09 14:13 ` Jon Masters
2014-09-15 22:57 ` Grant Likely
2014-09-15 22:57 ` Grant Likely
2014-09-15 23:00 ` Jon Masters
2014-09-15 23:00 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915092456.GB1577@arm.com \
--to=catalin.marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Marc.Zyngier@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jason@lakedaemon.net \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=olof@lixom.net \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.