From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty
Date: Tue, 16 Sep 2014 13:03:57 -0300 [thread overview]
Message-ID: <20140916160357.GA30753@amt.cnet> (raw)
In-Reply-To: <54185A58.2010105@redhat.com>
On Tue, Sep 16, 2014 at 05:42:16PM +0200, Paolo Bonzini wrote:
> Il 16/09/2014 17:14, Marcelo Tosatti ha scritto:
> > + /*
> > + * Make sure that CPU state is synchronized from KVM
> > + * once every VM state change callback has finished.
>
> Which other callback could affect the in-kernel state,
Do you want me to find out exactly which callback is changing
the in-kernel interrupt state?
To be honest: i don't know.
> and should that call cpu_clean_all_dirty instead?
Does not make sense: any callback which modifies any in-kernel register
state should clean dirty state because its possibly set.
prev parent reply other threads:[~2014-09-16 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 15:14 [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty Marcelo Tosatti
2014-09-16 15:42 ` Paolo Bonzini
2014-09-16 15:55 ` Marcelo Tosatti
2014-09-16 16:03 ` Paolo Bonzini
2014-09-16 16:07 ` Marcelo Tosatti
2014-09-16 16:22 ` Paolo Bonzini
2014-09-16 16:48 ` Marcelo Tosatti
2014-09-16 16:54 ` Marcelo Tosatti
2014-09-16 18:10 ` Marcelo Tosatti
2014-09-16 16:03 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916160357.GA30753@amt.cnet \
--to=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.