From: Lee Jones <lee.jones@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off
Date: Tue, 16 Sep 2014 16:05:37 -0700 [thread overview]
Message-ID: <20140916230537.GU25162@lee--X1> (raw)
In-Reply-To: <20140909000126.GU3238@atomide.com>
On Mon, 08 Sep 2014, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140903 12:07]:
> > ti,system-power-controller is more or less the standard way of
> > indicating that the PMIC is the system wide power controller and hence
> > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > many Maxim PMIC drivers follow the same style.
> >
> > So support 'ti,system-power-controller' in addition to the usual
> > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > switching off the system.
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Acked-by: Tony Lindgren <tony@atomide.com>
I assume you're going to resend this with the document modifications?
When you do, don't forget to apply Tony's Ack, as it will ensure a
faster merge.
> > ---
> > drivers/mfd/twl4030-power.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 3bc969a..1c129ba 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
> > if (pdata && pdata->use_poweroff)
> > return true;
> >
> > + if (of_property_read_bool(node, "ti,system-power-controller"))
> > + return true;
> > +
> > if (of_property_read_bool(node, "ti,use_poweroff"))
> > return true;
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off
Date: Tue, 16 Sep 2014 16:05:37 -0700 [thread overview]
Message-ID: <20140916230537.GU25162@lee--X1> (raw)
In-Reply-To: <20140909000126.GU3238@atomide.com>
On Mon, 08 Sep 2014, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140903 12:07]:
> > ti,system-power-controller is more or less the standard way of
> > indicating that the PMIC is the system wide power controller and hence
> > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > many Maxim PMIC drivers follow the same style.
> >
> > So support 'ti,system-power-controller' in addition to the usual
> > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > switching off the system.
> >
> > Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Acked-by: Tony Lindgren <tony@atomide.com>
I assume you're going to resend this with the document modifications?
When you do, don't forget to apply Tony's Ack, as it will ensure a
faster merge.
> > ---
> > drivers/mfd/twl4030-power.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 3bc969a..1c129ba 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -627,6 +627,9 @@ static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata,
> > if (pdata && pdata->use_poweroff)
> > return true;
> >
> > + if (of_property_read_bool(node, "ti,system-power-controller"))
> > + return true;
> > +
> > if (of_property_read_bool(node, "ti,use_poweroff"))
> > return true;
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-16 23:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 19:06 [PATCH 0/2] mfd: twl4030-power: support ti,system-power-controller Nishanth Menon
2014-09-03 19:06 ` Nishanth Menon
2014-09-03 19:06 ` [PATCH 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Nishanth Menon
2014-09-03 19:06 ` Nishanth Menon
[not found] ` <1409771208-21867-2-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-09-03 19:53 ` Sebastian Reichel
2014-09-03 19:53 ` Sebastian Reichel
2014-09-03 20:31 ` Nishanth Menon
[not found] ` <1409771208-21867-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2014-09-03 19:06 ` [PATCH 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off Nishanth Menon
2014-09-03 19:06 ` Nishanth Menon
2014-09-09 0:01 ` Tony Lindgren
2014-09-16 23:05 ` Lee Jones [this message]
2014-09-16 23:05 ` Lee Jones
2014-09-17 12:17 ` Nishanth Menon
2014-09-17 12:17 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916230537.GU25162@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.