From: Matthew Garrett <mjg59@srcf.ucam.org>
To: suravee.suthikulpanit@amd.com
Cc: mark.rutland@arm.com, rjw@rjwysocki.net,
graeme.gregory@linaro.org, arnd@arndb.de, marc.zyngier@arm.com,
catalin.marinas@arm.com, olof@lixom.net, will.deacon@arm.com,
linux-kernel@vger.kernel.org, astone@redhat.com,
linux-acpi@vger.kernel.org, hanjun.guo@linaro.org,
Sudeep.Holla@arm.com, grant.likely@linaro.org,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net
Subject: Re: [PATCH 1/4] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller
Date: Wed, 17 Sep 2014 02:26:14 +0100 [thread overview]
Message-ID: <20140917012614.GA31214@srcf.ucam.org> (raw)
In-Reply-To: <1410828446-28502-2-git-send-email-suravee.suthikulpanit@amd.com>
On Mon, Sep 15, 2014 at 07:47:23PM -0500, suravee.suthikulpanit@amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
> This patch adds ACPI match table in ahci_platform. The table includes
> the acpi_device_id to match AMD Seattle SATA controller with following
> asl structure in DSDT:
>
> Device (SATA0)
> {
> Name(_HID, "AMDI0600") // Seattle AHSATA
There really ought to be a well-defined PNPID for AHCI, so you can _HID
to AMD and _CID to something generic. That way we won't have:
> +#ifdef CONFIG_ATA_ACPI
> +static const struct acpi_device_id ahci_acpi_match[] = {
> + { "AMDI0600", 0 }, /* AMD Seattle AHCI */
> + { },
> +};
utter sadness here. Really, please don't end up in a situation where we
need to add device-specific IDs to a generic driver.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: mjg59@srcf.ucam.org (Matthew Garrett)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller
Date: Wed, 17 Sep 2014 02:26:14 +0100 [thread overview]
Message-ID: <20140917012614.GA31214@srcf.ucam.org> (raw)
In-Reply-To: <1410828446-28502-2-git-send-email-suravee.suthikulpanit@amd.com>
On Mon, Sep 15, 2014 at 07:47:23PM -0500, suravee.suthikulpanit at amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
> This patch adds ACPI match table in ahci_platform. The table includes
> the acpi_device_id to match AMD Seattle SATA controller with following
> asl structure in DSDT:
>
> Device (SATA0)
> {
> Name(_HID, "AMDI0600") // Seattle AHSATA
There really ought to be a well-defined PNPID for AHCI, so you can _HID
to AMD and _CID to something generic. That way we won't have:
> +#ifdef CONFIG_ATA_ACPI
> +static const struct acpi_device_id ahci_acpi_match[] = {
> + { "AMDI0600", 0 }, /* AMD Seattle AHCI */
> + { },
> +};
utter sadness here. Really, please don't end up in a situation where we
need to add device-specific IDs to a generic driver.
--
Matthew Garrett | mjg59 at srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: suravee.suthikulpanit@amd.com
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
mark.rutland@arm.com, arnd@arndb.de, graeme.gregory@linaro.org,
marc.zyngier@arm.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, astone@redhat.com,
grant.likely@linaro.org, hanjun.guo@linaro.org,
Sudeep.Holla@arm.com, olof@lixom.net, jason@lakedaemon.net
Subject: Re: [PATCH 1/4] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller
Date: Wed, 17 Sep 2014 02:26:14 +0100 [thread overview]
Message-ID: <20140917012614.GA31214@srcf.ucam.org> (raw)
In-Reply-To: <1410828446-28502-2-git-send-email-suravee.suthikulpanit@amd.com>
On Mon, Sep 15, 2014 at 07:47:23PM -0500, suravee.suthikulpanit@amd.com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
>
> This patch adds ACPI match table in ahci_platform. The table includes
> the acpi_device_id to match AMD Seattle SATA controller with following
> asl structure in DSDT:
>
> Device (SATA0)
> {
> Name(_HID, "AMDI0600") // Seattle AHSATA
There really ought to be a well-defined PNPID for AHCI, so you can _HID
to AMD and _CID to something generic. That way we won't have:
> +#ifdef CONFIG_ATA_ACPI
> +static const struct acpi_device_id ahci_acpi_match[] = {
> + { "AMDI0600", 0 }, /* AMD Seattle AHCI */
> + { },
> +};
utter sadness here. Really, please don't end up in a situation where we
need to add device-specific IDs to a generic driver.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2014-09-17 1:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 0:47 [RFC PATCH for AMD Seattle 0/4] Drivers for AMD-Seatlle to boot from ACPI suravee.suthikulpanit at amd.com
2014-09-16 0:47 ` suravee.suthikulpanit
2014-09-16 0:47 ` [PATCH 1/4] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller suravee.suthikulpanit at amd.com
2014-09-16 0:47 ` suravee.suthikulpanit
2014-09-17 1:26 ` Matthew Garrett [this message]
2014-09-17 1:26 ` Matthew Garrett
2014-09-17 1:26 ` Matthew Garrett
2014-10-01 21:19 ` Suravee Suthikulanit
2014-10-01 21:19 ` Suravee Suthikulanit
2014-10-01 21:19 ` Suravee Suthikulanit
2014-10-02 8:39 ` Arnd Bergmann
2014-10-02 8:39 ` Arnd Bergmann
2014-10-06 16:31 ` Matthew Garrett
2014-10-06 16:31 ` Matthew Garrett
2014-10-06 18:19 ` Arnd Bergmann
2014-10-06 18:19 ` Arnd Bergmann
2014-10-06 18:21 ` Matthew Garrett
2014-10-06 18:21 ` Matthew Garrett
2014-10-06 18:44 ` Arnd Bergmann
2014-10-06 18:44 ` Arnd Bergmann
2014-10-06 18:47 ` Matthew Garrett
2014-10-06 18:47 ` Matthew Garrett
2014-09-16 0:47 ` [PATCH 2/4] arm64/efi: efistub: don't abort if base of DRAM is occupied suravee.suthikulpanit at amd.com
2014-09-16 0:47 ` suravee.suthikulpanit
2014-09-16 0:47 ` [PATCH 3/4] efi/arm64: fix fdt-related memory reservation suravee.suthikulpanit at amd.com
2014-09-16 0:47 ` suravee.suthikulpanit
2014-09-16 0:47 ` [PATCH 4/4] [RFC PATCH for Juno 2/2] tty: SBSA compatible UART suravee.suthikulpanit at amd.com
2014-09-16 0:47 ` suravee.suthikulpanit
2014-09-17 10:40 ` One Thousand Gnomes
2014-09-17 10:40 ` One Thousand Gnomes
2014-09-17 17:01 ` Graeme Gregory
2014-09-17 17:01 ` Graeme Gregory
2014-09-16 4:28 ` [RFC PATCH for AMD Seattle 0/4] Drivers for AMD-Seatlle to boot from ACPI Suravee Suthikulpanit
2014-09-16 4:28 ` Suravee Suthikulpanit
2014-09-16 4:28 ` Suravee Suthikulpanit
2014-09-16 22:56 ` Jon Masters
2014-09-16 22:56 ` Jon Masters
2014-09-16 22:56 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917012614.GA31214@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Sudeep.Holla@arm.com \
--cc=arnd@arndb.de \
--cc=astone@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=graeme.gregory@linaro.org \
--cc=grant.likely@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
--cc=suravee.suthikulpanit@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.