From: b38343@freescale.com (Robin Gong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 17 Sep 2014 17:19:24 +0800 [thread overview]
Message-ID: <20140917091922.GA6551@Robin-OptiPlex-780> (raw)
In-Reply-To: <1410944156.2731.1.camel@pengutronix.de>
On Wed, Sep 17, 2014 at 10:55:56AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 17.09.2014, 16:41 +0800 schrieb Robin Gong:
> > On Tue, Sep 16, 2014 at 11:50:06AM +0200, Lucas Stach wrote:
> > > Hi Robin,
> > >
> > > Am Dienstag, den 16.09.2014, 11:41 +0800 schrieb Robin Gong:
> > > > Hi Lucas,
> > > > I understood your concern,but looks we have to break old DT.
> > >
> > > Sorry, but this isn't going to happen. And honestly I don't even see the
> > > need to do so.
> > >
> > > > Our old DT
> > > > support SPI DMA on i.mx6q/dl(v2,b3810c3dc1bcbc6a), but the DMA support patch
> > > > for SPI driver is still in reviewing(v6).
> > >
> > > So this means now is the time to fix this driver patch to not enable DMA
> > > on imx6dl. Nobody will experience any breakage in this case.
> > >
> > Sorry, i.mx6q and i.mx6dl are totally same, not only IP but also clock. So we
> > can't distinguish them except for different compatible name....
>
> I know that, but I still don't see the problem.
>
> If this issue is specific to the ECSPI IP integrated into a imx6dl SoC
> you need to check for the machine compatible in the driver and disable
> DMA support based on this. We generally avoid checking for the machine
> compatible in drivers and prefer to have a specific IP block compatible
> instead, but in that case it's the only reasonable thing to do.
>
> Regards,
> Lucas
Sounds we make a agreement on use different compatible name, right? I will
make patch for reviewing, thanks.
> --
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 17 Sep 2014 17:19:24 +0800 [thread overview]
Message-ID: <20140917091922.GA6551@Robin-OptiPlex-780> (raw)
In-Reply-To: <1410944156.2731.1.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, Sep 17, 2014 at 10:55:56AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 17.09.2014, 16:41 +0800 schrieb Robin Gong:
> > On Tue, Sep 16, 2014 at 11:50:06AM +0200, Lucas Stach wrote:
> > > Hi Robin,
> > >
> > > Am Dienstag, den 16.09.2014, 11:41 +0800 schrieb Robin Gong:
> > > > Hi Lucas,
> > > > I understood your concern,but looks we have to break old DT.
> > >
> > > Sorry, but this isn't going to happen. And honestly I don't even see the
> > > need to do so.
> > >
> > > > Our old DT
> > > > support SPI DMA on i.mx6q/dl(v2,b3810c3dc1bcbc6a), but the DMA support patch
> > > > for SPI driver is still in reviewing(v6).
> > >
> > > So this means now is the time to fix this driver patch to not enable DMA
> > > on imx6dl. Nobody will experience any breakage in this case.
> > >
> > Sorry, i.mx6q and i.mx6dl are totally same, not only IP but also clock. So we
> > can't distinguish them except for different compatible name....
>
> I know that, but I still don't see the problem.
>
> If this issue is specific to the ECSPI IP integrated into a imx6dl SoC
> you need to check for the machine compatible in the driver and disable
> DMA support based on this. We generally avoid checking for the machine
> compatible in drivers and prefer to have a specific IP block compatible
> instead, but in that case it's the only reasonable thing to do.
>
> Regards,
> Lucas
Sounds we make a agreement on use different compatible name, right? I will
make patch for reviewing, thanks.
> --
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <b38343@freescale.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<linux@arm.linux.org.uk>, <pawel.moll@arm.com>,
<ijc+devicetree@hellion.org.uk>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <shawn.guo@freescale.com>,
<kernel@pengutronix.de>, <galak@codeaurora.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Wed, 17 Sep 2014 17:19:24 +0800 [thread overview]
Message-ID: <20140917091922.GA6551@Robin-OptiPlex-780> (raw)
In-Reply-To: <1410944156.2731.1.camel@pengutronix.de>
On Wed, Sep 17, 2014 at 10:55:56AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 17.09.2014, 16:41 +0800 schrieb Robin Gong:
> > On Tue, Sep 16, 2014 at 11:50:06AM +0200, Lucas Stach wrote:
> > > Hi Robin,
> > >
> > > Am Dienstag, den 16.09.2014, 11:41 +0800 schrieb Robin Gong:
> > > > Hi Lucas,
> > > > I understood your concern,but looks we have to break old DT.
> > >
> > > Sorry, but this isn't going to happen. And honestly I don't even see the
> > > need to do so.
> > >
> > > > Our old DT
> > > > support SPI DMA on i.mx6q/dl(v2,b3810c3dc1bcbc6a), but the DMA support patch
> > > > for SPI driver is still in reviewing(v6).
> > >
> > > So this means now is the time to fix this driver patch to not enable DMA
> > > on imx6dl. Nobody will experience any breakage in this case.
> > >
> > Sorry, i.mx6q and i.mx6dl are totally same, not only IP but also clock. So we
> > can't distinguish them except for different compatible name....
>
> I know that, but I still don't see the problem.
>
> If this issue is specific to the ECSPI IP integrated into a imx6dl SoC
> you need to check for the machine compatible in the driver and disable
> DMA support based on this. We generally avoid checking for the machine
> compatible in drivers and prefer to have a specific IP block compatible
> instead, but in that case it's the only reasonable thing to do.
>
> Regards,
> Lucas
Sounds we make a agreement on use different compatible name, right? I will
make patch for reviewing, thanks.
> --
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
next prev parent reply other threads:[~2014-09-17 9:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 5:30 [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl Robin Gong
2014-09-10 5:30 ` Robin Gong
2014-09-10 5:30 ` Robin Gong
2014-09-11 8:02 ` Shawn Guo
2014-09-11 8:02 ` Shawn Guo
2014-09-11 8:02 ` Shawn Guo
2014-09-15 9:41 ` Lucas Stach
2014-09-15 9:41 ` Lucas Stach
2014-09-15 9:41 ` Lucas Stach
2014-09-16 1:43 ` Shawn Guo
2014-09-16 1:43 ` Shawn Guo
2014-09-16 1:43 ` Shawn Guo
2014-09-16 3:41 ` Robin Gong
2014-09-16 3:41 ` Robin Gong
2014-09-16 3:41 ` Robin Gong
2014-09-16 9:50 ` Lucas Stach
2014-09-16 9:50 ` Lucas Stach
2014-09-16 9:50 ` Lucas Stach
2014-09-17 8:41 ` Robin Gong
2014-09-17 8:41 ` Robin Gong
2014-09-17 8:41 ` Robin Gong
2014-09-17 8:55 ` Lucas Stach
2014-09-17 8:55 ` Lucas Stach
2014-09-17 8:55 ` Lucas Stach
2014-09-17 9:19 ` Robin Gong [this message]
2014-09-17 9:19 ` Robin Gong
2014-09-17 9:19 ` Robin Gong
2014-09-17 9:19 ` Lucas Stach
2014-09-17 9:19 ` Lucas Stach
2014-09-17 9:19 ` Lucas Stach
2014-09-17 9:28 ` Robin Gong
2014-09-17 9:28 ` Robin Gong
2014-09-17 9:28 ` Robin Gong
2014-09-15 11:50 ` Alexander Holler
2014-09-15 11:50 ` Alexander Holler
2014-09-15 11:50 ` Alexander Holler
2014-09-16 3:52 ` Robin Gong
2014-09-16 3:52 ` Robin Gong
2014-09-16 3:52 ` Robin Gong
2014-09-16 9:41 ` Alexander Holler
2014-09-16 9:41 ` Alexander Holler
2014-09-16 9:41 ` Alexander Holler
2014-09-17 8:51 ` Robin Gong
2014-09-17 8:51 ` Robin Gong
2014-09-17 8:51 ` Robin Gong
2014-09-17 10:56 ` Alexander Holler
2014-09-17 10:56 ` Alexander Holler
2014-09-17 10:56 ` Alexander Holler
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 1:06 Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917091922.GA6551@Robin-OptiPlex-780 \
--to=b38343@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.