All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] python-configshell-fb: new package
Date: Wed, 17 Sep 2014 14:03:41 +0200	[thread overview]
Message-ID: <20140917140341.34d14957@free-electrons.com> (raw)
In-Reply-To: <1410953999-16520-5-git-send-email-cvubrugier@fastmail.fm>

Dear Christophe Vu-Brugier,

On Wed, 17 Sep 2014 13:39:57 +0200, Christophe Vu-Brugier wrote:

> diff --git a/package/python-configshell-fb/Config.in b/package/python-configshell-fb/Config.in
> new file mode 100644
> index 0000000..05de585
> --- /dev/null
> +++ b/package/python-configshell-fb/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
> +	bool "python-configshell-fb"
> +	depends on BR2_PACKAGE_PYTHON

Ok, I just read the README file for this package, and it explains that
the setup.py script runs 2to3 to convert the package source code to
Python 3 if needed. Most likely our installation of 2to3 is broken.

The patch anyway looks good to me, so:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-09-17 12:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
2014-09-17 11:59   ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
2014-09-17 12:00   ` Thomas Petazzoni
2014-09-17 13:13     ` Christophe Vu-Brugier
2014-09-17 13:15       ` Thomas Petazzoni
2014-09-17 15:21         ` Christophe Vu-Brugier
2014-09-17 15:29           ` Thomas Petazzoni
2014-09-17 20:00   ` Jerzy Grzegorek
2014-09-18  7:39     ` Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
2014-09-17 12:03   ` Thomas Petazzoni [this message]
2014-09-17 11:39 ` [Buildroot] [PATCH 5/6] targetcli-fb: " Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
2014-09-17 12:12   ` Thomas Petazzoni
2014-09-17 13:19     ` Christophe Vu-Brugier
2014-09-17 13:21       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917140341.34d14957@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.