* [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
` (4 subsequent siblings)
5 siblings, 0 replies; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
The copy_scripts() method in distutils copies the scripts listed
in the setup file and adjusts the first line to refer to the
current Python interpreter. When cross-compiling, this means that
the adjusted shebang refers to the host Python interpreter.
As a consequence, we add a patch for python and python3 that
force copy_scripts() to preserve the shebang when
cross-compilation is detected.
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
...017-distutils-scripts-dont-adjust-shebang.patch | 25 ++++++++++++++++++++++
...015-distutils-scripts-dont-adjust-shebang.patch | 25 ++++++++++++++++++++++
2 files changed, 50 insertions(+)
create mode 100644 package/python/python-017-distutils-scripts-dont-adjust-shebang.patch
create mode 100644 package/python3/python3-015-distutils-scripts-dont-adjust-shebang.patch
diff --git a/package/python/python-017-distutils-scripts-dont-adjust-shebang.patch b/package/python/python-017-distutils-scripts-dont-adjust-shebang.patch
new file mode 100644
index 0000000..da4dc36
--- /dev/null
+++ b/package/python/python-017-distutils-scripts-dont-adjust-shebang.patch
@@ -0,0 +1,25 @@
+Do not adjust the shebang of Python scripts for cross-compilation
+
+The copy_scripts() method in distutils copies the scripts listed in
+the setup file and adjusts the first line to refer to the current
+Python interpreter. When cross-compiling, this means that the adjusted
+shebang refers to the host Python interpreter.
+
+This patch modifies copy_scripts() to preserve the shebang when
+cross-compilation is detected.
+
+Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
+
+Index: b/Lib/distutils/command/build_scripts.py
+===================================================================
+--- a/Lib/distutils/command/build_scripts.py
++++ b/Lib/distutils/command/build_scripts.py
+@@ -89,7 +89,7 @@
+ adjust = 1
+ post_interp = match.group(1) or ''
+
+- if adjust:
++ if adjust and not '_python_sysroot' in os.environ:
+ log.info("copying and adjusting %s -> %s", script,
+ self.build_dir)
+ if not self.dry_run:
diff --git a/package/python3/python3-015-distutils-scripts-dont-adjust-shebang.patch b/package/python3/python3-015-distutils-scripts-dont-adjust-shebang.patch
new file mode 100644
index 0000000..ed2f193
--- /dev/null
+++ b/package/python3/python3-015-distutils-scripts-dont-adjust-shebang.patch
@@ -0,0 +1,25 @@
+Do not adjust the shebang of Python scripts for cross-compilation
+
+The copy_scripts() method in distutils copies the scripts listed in
+the setup file and adjusts the first line to refer to the current
+Python interpreter. When cross-compiling, this means that the adjusted
+shebang refers to the host Python interpreter.
+
+This patch modifies copy_scripts() to preserve the shebang when
+cross-compilation is detected.
+
+Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
+
+Index: b/Lib/distutils/command/build_scripts.py
+===================================================================
+--- a/Lib/distutils/command/build_scripts.py
++++ b/Lib/distutils/command/build_scripts.py
+@@ -91,7 +91,7 @@
+ adjust = True
+ post_interp = match.group(1) or b''
+
+- if adjust:
++ if adjust and not '_python_sysroot' in os.environ:
+ log.info("copying and adjusting %s -> %s", script,
+ self.build_dir)
+ updated_files.append(outfile)
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 2/6] python-urwid: new package
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 11:59 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
` (3 subsequent siblings)
5 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
Urwid is a console user interface library for Python.
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
package/Config.in | 1 +
package/python-urwid/Config.in | 7 +++++++
package/python-urwid/python-urwid.mk | 14 ++++++++++++++
3 files changed, 22 insertions(+)
create mode 100644 package/python-urwid/Config.in
create mode 100644 package/python-urwid/python-urwid.mk
diff --git a/package/Config.in b/package/Config.in
index 73ba86a..17930ea 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -508,6 +508,7 @@ menu "external python modules"
source "package/python-simplejson/Config.in"
source "package/python-thrift/Config.in"
source "package/python-tornado/Config.in"
+ source "package/python-urwid/Config.in"
source "package/python-versiontools/Config.in"
endmenu
endif
diff --git a/package/python-urwid/Config.in b/package/python-urwid/Config.in
new file mode 100644
index 0000000..92f7d53
--- /dev/null
+++ b/package/python-urwid/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_URWID
+ bool "python-urwid"
+ depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+ help
+ Urwid is a console user interface library for Python
+
+ http://urwid.org/
diff --git a/package/python-urwid/python-urwid.mk b/package/python-urwid/python-urwid.mk
new file mode 100644
index 0000000..4f1be46
--- /dev/null
+++ b/package/python-urwid/python-urwid.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-urwid
+#
+################################################################################
+
+PYTHON_URWID_VERSION = 1.2.1
+PYTHON_URWID_SOURCE = urwid-$(PYTHON_URWID_VERSION).tar.gz
+PYTHON_URWID_SITE = https://pypi.python.org/packages/source/u/urwid
+PYTHON_URWID_LICENSE = LGPLv2.1+
+PYTHON_URWID_LICENSE_FILES = COPYING
+PYTHON_URWID_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 2/6] python-urwid: new package
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
@ 2014-09-17 11:59 ` Thomas Petazzoni
0 siblings, 0 replies; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 11:59 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 13:39:55 +0200, Christophe Vu-Brugier wrote:
> Urwid is a console user interface library for Python.
>
> Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> ---
> package/Config.in | 1 +
> package/python-urwid/Config.in | 7 +++++++
> package/python-urwid/python-urwid.mk | 14 ++++++++++++++
> 3 files changed, 22 insertions(+)
> create mode 100644 package/python-urwid/Config.in
> create mode 100644 package/python-urwid/python-urwid.mk
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Looks good to me, I've checked that the license is indeed LGPLv2.1+,
the rest of the package is quite simple and obvious.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 12:00 ` Thomas Petazzoni
2014-09-17 20:00 ` Jerzy Grzegorek
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
` (2 subsequent siblings)
5 siblings, 2 replies; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
rtslib-fb is an object-based Python library for configuring the
LIO generic SCSI target, present in 3.x Linux kernel versions.
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
package/Config.in | 1 +
package/python-rtslib-fb/Config.in | 9 +++++++++
package/python-rtslib-fb/python-rtslib.mk | 13 +++++++++++++
3 files changed, 23 insertions(+)
create mode 100644 package/python-rtslib-fb/Config.in
create mode 100644 package/python-rtslib-fb/python-rtslib.mk
diff --git a/package/Config.in b/package/Config.in
index 17930ea..7447036 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -503,6 +503,7 @@ menu "external python modules"
source "package/python-pysnmp-mibs/Config.in"
source "package/python-pyusb/Config.in"
source "package/python-pyzmq/Config.in"
+ source "package/python-rtslib-fb/Config.in"
source "package/python-serial/Config.in"
source "package/python-setuptools/Config.in"
source "package/python-simplejson/Config.in"
diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
new file mode 100644
index 0000000..b2aebcf
--- /dev/null
+++ b/package/python-rtslib-fb/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_RTSLIB_FB
+ bool "python-rtslib-fb"
+ depends on BR2_PACKAGE_PYTHON
+ help
+ rtslib-fb is an object-based Python library for configuring
+ the LIO generic SCSI target, present in 3.x Linux kernel
+ versions.
+
+ https://github.com/agrover/rtslib-fb
diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
new file mode 100644
index 0000000..70b0257
--- /dev/null
+++ b/package/python-rtslib-fb/python-rtslib.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# python-rtslib-fb
+#
+################################################################################
+
+PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
+PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
+PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
+PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
+PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
@ 2014-09-17 12:00 ` Thomas Petazzoni
2014-09-17 13:13 ` Christophe Vu-Brugier
2014-09-17 20:00 ` Jerzy Grzegorek
1 sibling, 1 reply; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 12:00 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 13:39:56 +0200, Christophe Vu-Brugier wrote:
> diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
> new file mode 100644
> index 0000000..b2aebcf
> --- /dev/null
> +++ b/package/python-rtslib-fb/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_RTSLIB_FB
> + bool "python-rtslib-fb"
> + depends on BR2_PACKAGE_PYTHON
Is it for this package that you had the Python 3 issue? Could you
explain a bit more the 2to3 problems you have seen?
> + help
> + rtslib-fb is an object-based Python library for configuring
> + the LIO generic SCSI target, present in 3.x Linux kernel
> + versions.
> +
> + https://github.com/agrover/rtslib-fb
> diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
> new file mode 100644
> index 0000000..70b0257
> --- /dev/null
> +++ b/package/python-rtslib-fb/python-rtslib.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# python-rtslib-fb
> +#
> +################################################################################
> +
> +PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
> +PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
> +PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
> +PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
> +PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
Other than that, the patch looks good to me, and the Python 3 support
can always be added later:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 12:00 ` Thomas Petazzoni
@ 2014-09-17 13:13 ` Christophe Vu-Brugier
2014-09-17 13:15 ` Thomas Petazzoni
0 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 13:13 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Thank you for the prompt review.
On Wed, 17 Sep 2014 14:00:59 +0200, Thomas Petazzoni wrote :
> On Wed, 17 Sep 2014 13:39:56 +0200, Christophe Vu-Brugier wrote:
>
> > diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
> > new file mode 100644
> > index 0000000..b2aebcf
> > --- /dev/null
> > +++ b/package/python-rtslib-fb/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_PYTHON_RTSLIB_FB
> > + bool "python-rtslib-fb"
> > + depends on BR2_PACKAGE_PYTHON
>
> Is it for this package that you had the Python 3 issue? Could you
> explain a bit more the 2to3 problems you have seen?
It is for this package (and for configshell-fb and targetcli-fb) that I
thought I had an issue with `2to3`.
But I was wrong because it seems that `2to3` is correctly invoked by
setup.py when it is run under Python 3.
The installed python files are different from the source python files
and are modified by `2to3`:
--- build/python-rtslib-fb-v2.1.fb49/rtslib/utils.py
+++ target/usr/lib/python3.4/site-packages/rtslib/utils.py
@@ -435,14 +435,14 @@
raise
def set_attributes(obj, attr_dict, err_func):
- for name, value in attr_dict.iteritems():
+ for name, value in attr_dict.items():
So if there is an issue, it is not caused by a broken `2to3`.
> > + help
> > + rtslib-fb is an object-based Python library for configuring
> > + the LIO generic SCSI target, present in 3.x Linux kernel
> > + versions.
> > +
> > + https://github.com/agrover/rtslib-fb
> > diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
> > new file mode 100644
> > index 0000000..70b0257
> > --- /dev/null
> > +++ b/package/python-rtslib-fb/python-rtslib.mk
> > @@ -0,0 +1,13 @@
> > +################################################################################
> > +#
> > +# python-rtslib-fb
> > +#
> > +################################################################################
> > +
> > +PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
> > +PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
> > +PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
> > +PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
> > +PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
> > +
> > +$(eval $(python-package))
>
> Other than that, the patch looks good to me, and the Python 3 support
> can always be added later:
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Thomas
^ permalink raw reply [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 13:13 ` Christophe Vu-Brugier
@ 2014-09-17 13:15 ` Thomas Petazzoni
2014-09-17 15:21 ` Christophe Vu-Brugier
0 siblings, 1 reply; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 13:15 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 15:13:02 +0200, Christophe Vu-Brugier wrote:
> Thank you for the prompt review.
You're welcome. Thanks for submitting those packages in the first place!
> > Is it for this package that you had the Python 3 issue? Could you
> > explain a bit more the 2to3 problems you have seen?
>
> It is for this package (and for configshell-fb and targetcli-fb) that I
> thought I had an issue with `2to3`.
> But I was wrong because it seems that `2to3` is correctly invoked by
> setup.py when it is run under Python 3.
> The installed python files are different from the source python files
> and are modified by `2to3`:
>
> --- build/python-rtslib-fb-v2.1.fb49/rtslib/utils.py
> +++ target/usr/lib/python3.4/site-packages/rtslib/utils.py
> @@ -435,14 +435,14 @@
> raise
>
> def set_attributes(obj, attr_dict, err_func):
> - for name, value in attr_dict.iteritems():
> + for name, value in attr_dict.items():
>
> So if there is an issue, it is not caused by a broken `2to3`.
Indeed, this modification looks like a Python 2 vs. Python 3
conversion, even though I'm not familiar enough with the Python
language changes to be sure.
What was the issue you had with Python 3 ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 13:15 ` Thomas Petazzoni
@ 2014-09-17 15:21 ` Christophe Vu-Brugier
2014-09-17 15:29 ` Thomas Petazzoni
0 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 15:21 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, 17 Sep 2014 15:15:52 +0200, Thomas Petazzoni wrote :
> What was the issue you had with Python 3 ?
The only "issue" I face at the moment is with pyparsing. I get an
ImportError when I try to import this module from Python 3. I think the
module is correctly installed: I compared the installation in Buildroot
and in a virtualenv and the only difference I see is that a
"pyparsing.py" file is installed in "site-packages/" in my virtualenv.
It is expected since BR2_PACKAGE_PYTHON3_PYC_ONLY is selected. If I
select BR2_PACKAGE_PYTHON3_PY_PYC instead, then importing the pyparsing
module works.
I don't know how to properly fix this. What would you suggest?
Best regards,
--
Christophe Vu-Brugier
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 15:21 ` Christophe Vu-Brugier
@ 2014-09-17 15:29 ` Thomas Petazzoni
0 siblings, 0 replies; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 15:29 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 17:21:11 +0200, Christophe Vu-Brugier wrote:
> The only "issue" I face at the moment is with pyparsing. I get an
> ImportError when I try to import this module from Python 3. I think the
> module is correctly installed: I compared the installation in Buildroot
> and in a virtualenv and the only difference I see is that a
> "pyparsing.py" file is installed in "site-packages/" in my virtualenv.
>
> It is expected since BR2_PACKAGE_PYTHON3_PYC_ONLY is selected. If I
> select BR2_PACKAGE_PYTHON3_PY_PYC instead, then importing the pyparsing
> module works.
>
> I don't know how to properly fix this. What would you suggest?
Aah, yes, sorry, not your fault. There is an issue with Python 3 and
external modules in the BR2_PACKAGE_PYTHON3_PYC_ONLY case, caused by
PEP 3147. There is a patch pending at
http://patchwork.ozlabs.org/patch/373082/ to solve this, but I'm not
really happy with the proposed solution, and I wanted to investigate
this a bit more. Which I've started to do, but of course didn't had
enough time to come to a conclusion.
For the time being, either apply the patch mentioned above, or use
BR2_PACKAGE_PYTHON3_PY_PYC.
Sorry again :/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
2014-09-17 12:00 ` Thomas Petazzoni
@ 2014-09-17 20:00 ` Jerzy Grzegorek
2014-09-18 7:39 ` Christophe Vu-Brugier
1 sibling, 1 reply; 19+ messages in thread
From: Jerzy Grzegorek @ 2014-09-17 20:00 UTC (permalink / raw)
To: buildroot
Hi Christophe,
> rtslib-fb is an object-based Python library for configuring the
> LIO generic SCSI target, present in 3.x Linux kernel versions.
>
> Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> ---
> package/Config.in | 1 +
> package/python-rtslib-fb/Config.in | 9 +++++++++
> package/python-rtslib-fb/python-rtslib.mk | 13 +++++++++++++
Shouldn't this be:
package/python-rtslib-fb/python-rtslib-fb.mk ?
Regards,
Jerzy
> 3 files changed, 23 insertions(+)
> create mode 100644 package/python-rtslib-fb/Config.in
> create mode 100644 package/python-rtslib-fb/python-rtslib.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 17930ea..7447036 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -503,6 +503,7 @@ menu "external python modules"
> source "package/python-pysnmp-mibs/Config.in"
> source "package/python-pyusb/Config.in"
> source "package/python-pyzmq/Config.in"
> + source "package/python-rtslib-fb/Config.in"
> source "package/python-serial/Config.in"
> source "package/python-setuptools/Config.in"
> source "package/python-simplejson/Config.in"
> diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
> new file mode 100644
> index 0000000..b2aebcf
> --- /dev/null
> +++ b/package/python-rtslib-fb/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_RTSLIB_FB
> + bool "python-rtslib-fb"
> + depends on BR2_PACKAGE_PYTHON
> + help
> + rtslib-fb is an object-based Python library for configuring
> + the LIO generic SCSI target, present in 3.x Linux kernel
> + versions.
> +
> + https://github.com/agrover/rtslib-fb
> diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
> new file mode 100644
> index 0000000..70b0257
> --- /dev/null
> +++ b/package/python-rtslib-fb/python-rtslib.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# python-rtslib-fb
> +#
> +################################################################################
> +
> +PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
> +PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
> +PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
> +PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
> +PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
2014-09-17 20:00 ` Jerzy Grzegorek
@ 2014-09-18 7:39 ` Christophe Vu-Brugier
0 siblings, 0 replies; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-18 7:39 UTC (permalink / raw)
To: buildroot
Hi Jerzy,
On Wed, 17 Sep 2014 22:00:44 +0200, Jerzy Grzegorek wrote :
> > rtslib-fb is an object-based Python library for configuring the
> > LIO generic SCSI target, present in 3.x Linux kernel versions.
> >
> > Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> > ---
> > package/Config.in | 1 +
> > package/python-rtslib-fb/Config.in | 9 +++++++++
> > package/python-rtslib-fb/python-rtslib.mk | 13 +++++++++++++
>
> Shouldn't this be:
>
> package/python-rtslib-fb/python-rtslib-fb.mk ?
Indeed. Thank you for catching this one!
Best regards,
> > 3 files changed, 23 insertions(+)
> > create mode 100644 package/python-rtslib-fb/Config.in
> > create mode 100644 package/python-rtslib-fb/python-rtslib.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index 17930ea..7447036 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -503,6 +503,7 @@ menu "external python modules"
> > source "package/python-pysnmp-mibs/Config.in"
> > source "package/python-pyusb/Config.in"
> > source "package/python-pyzmq/Config.in"
> > + source "package/python-rtslib-fb/Config.in"
> > source "package/python-serial/Config.in"
> > source "package/python-setuptools/Config.in"
> > source "package/python-simplejson/Config.in"
> > diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
> > new file mode 100644
> > index 0000000..b2aebcf
> > --- /dev/null
> > +++ b/package/python-rtslib-fb/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_PYTHON_RTSLIB_FB
> > + bool "python-rtslib-fb"
> > + depends on BR2_PACKAGE_PYTHON
> > + help
> > + rtslib-fb is an object-based Python library for configuring
> > + the LIO generic SCSI target, present in 3.x Linux kernel
> > + versions.
> > +
> > + https://github.com/agrover/rtslib-fb
> > diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
> > new file mode 100644
> > index 0000000..70b0257
> > --- /dev/null
> > +++ b/package/python-rtslib-fb/python-rtslib.mk
> > @@ -0,0 +1,13 @@
> > +################################################################################
> > +#
> > +# python-rtslib-fb
> > +#
> > +################################################################################
> > +
> > +PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
> > +PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
> > +PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
> > +PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
> > +PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
> > +
> > +$(eval $(python-package))
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 4/6] python-configshell-fb: new package
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
` (2 preceding siblings ...)
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 12:03 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 5/6] targetcli-fb: " Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
5 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
configshell-fb is a Python library that provides a framework for
building simple but nice CLI-based applications.
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
package/Config.in | 1 +
package/python-configshell-fb/Config.in | 11 +++++++++++
package/python-configshell-fb/python-configshell-fb.mk | 14 ++++++++++++++
3 files changed, 26 insertions(+)
create mode 100644 package/python-configshell-fb/Config.in
create mode 100644 package/python-configshell-fb/python-configshell-fb.mk
diff --git a/package/Config.in b/package/Config.in
index 7447036..096d8c6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -473,6 +473,7 @@ menu "external python modules"
source "package/python-bottle/Config.in"
source "package/python-cffi/Config.in"
source "package/python-configobj/Config.in"
+ source "package/python-configshell-fb/Config.in"
source "package/python-crc16/Config.in"
source "package/python-daemon/Config.in"
source "package/python-dialog/Config.in"
diff --git a/package/python-configshell-fb/Config.in b/package/python-configshell-fb/Config.in
new file mode 100644
index 0000000..05de585
--- /dev/null
+++ b/package/python-configshell-fb/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
+ bool "python-configshell-fb"
+ depends on BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_PYTHON_PYPARSING
+ select BR2_PACKAGE_PYTHON_READLINE
+ select BR2_PACKAGE_PYTHON_URWID
+ help
+ configshell-fb is a Python library that provides a framework
+ for building simple but nice CLI-based applications.
+
+ https://github.com/agrover/configshell-fb
diff --git a/package/python-configshell-fb/python-configshell-fb.mk b/package/python-configshell-fb/python-configshell-fb.mk
new file mode 100644
index 0000000..64b27fe
--- /dev/null
+++ b/package/python-configshell-fb/python-configshell-fb.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-configshell-fb
+#
+################################################################################
+
+PYTHON_CONFIGSHELL_FB_VERSION = v1.1.fb14
+PYTHON_CONFIGSHELL_FB_SITE = $(call github,agrover,configshell-fb,$(PYTHON_CONFIGSHELL_FB_VERSION))
+PYTHON_CONFIGSHELL_FB_LICENSE = Apache-2.0
+PYTHON_CONFIGSHELL_FB_LICENSE_FILES = COPYING
+PYTHON_CONFIGSHELL_FB_SETUP_TYPE = setuptools
+PYTHON_CONFIGSHELL_FB_DEPENDENCIES = python-pyparsing python-urwid
+
+$(eval $(python-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 4/6] python-configshell-fb: new package
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
@ 2014-09-17 12:03 ` Thomas Petazzoni
0 siblings, 0 replies; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 12:03 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 13:39:57 +0200, Christophe Vu-Brugier wrote:
> diff --git a/package/python-configshell-fb/Config.in b/package/python-configshell-fb/Config.in
> new file mode 100644
> index 0000000..05de585
> --- /dev/null
> +++ b/package/python-configshell-fb/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
> + bool "python-configshell-fb"
> + depends on BR2_PACKAGE_PYTHON
Ok, I just read the README file for this package, and it explains that
the setup.py script runs 2to3 to convert the package source code to
Python 3 if needed. Most likely our installation of 2to3 is broken.
The patch anyway looks good to me, so:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 5/6] targetcli-fb: new package
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
` (3 preceding siblings ...)
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
5 siblings, 0 replies; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
targetcli-fb is a command-line interface for configuring the LIO
generic SCSI target, present in 3.x Linux kernel versions.
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
package/Config.in | 1 +
package/targetcli-fb/Config.in | 14 ++++++++++++++
package/targetcli-fb/targetcli-fb.mk | 14 ++++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 package/targetcli-fb/Config.in
create mode 100644 package/targetcli-fb/targetcli-fb.mk
diff --git a/package/Config.in b/package/Config.in
index 096d8c6..b10225b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -364,6 +364,7 @@ endif
source "package/sunxi-mali/Config.in"
source "package/sunxi-mali-prop/Config.in"
source "package/sysstat/Config.in"
+ source "package/targetcli-fb/Config.in"
source "package/ti-gfx/Config.in"
source "package/ti-uim/Config.in"
source "package/ti-utils/Config.in"
diff --git a/package/targetcli-fb/Config.in b/package/targetcli-fb/Config.in
new file mode 100644
index 0000000..dcc6a54
--- /dev/null
+++ b/package/targetcli-fb/Config.in
@@ -0,0 +1,14 @@
+comment "targetcli-fb depends on python"
+ depends on !BR2_PACKAGE_PYTHON
+
+config BR2_PACKAGE_TARGETCLI_FB
+ bool "targetcli-fb"
+ depends on BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_PYTHON_CONFIGSHELL_FB
+ select BR2_PACKAGE_PYTHON_RTSLIB_FB
+ help
+ targetcli-fb is a command-line interface for configuring the
+ LIO generic SCSI target, present in 3.x Linux kernel
+ versions.
+
+ https://github.com/agrover/targetcli-fb
diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
new file mode 100644
index 0000000..2384569
--- /dev/null
+++ b/package/targetcli-fb/targetcli-fb.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# targetcli-fb
+#
+################################################################################
+
+TARGETCLI_FB_VERSION = v2.1.fb36
+TARGETCLI_FB_SITE = $(call github,agrover,targetcli-fb,$(TARGETCLI_FB_VERSION))
+TARGETCLI_FB_LICENSE = Apache-2.0
+TARGETCLI_FB_LICENSE_FILES = COPYING
+TARGETCLI_FB_SETUP_TYPE = setuptools
+TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb
+
+$(eval $(python-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
` (4 preceding siblings ...)
2014-09-17 11:39 ` [Buildroot] [PATCH 5/6] targetcli-fb: " Christophe Vu-Brugier
@ 2014-09-17 11:39 ` Christophe Vu-Brugier
2014-09-17 12:12 ` Thomas Petazzoni
5 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 11:39 UTC (permalink / raw)
To: buildroot
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
---
package/targetcli-fb/S50target | 46 ++++++++++++++++++++++++++++++++++++
package/targetcli-fb/targetcli-fb.mk | 11 +++++++++
2 files changed, 57 insertions(+)
create mode 100755 package/targetcli-fb/S50target
diff --git a/package/targetcli-fb/S50target b/package/targetcli-fb/S50target
new file mode 100755
index 0000000..88290e4
--- /dev/null
+++ b/package/targetcli-fb/S50target
@@ -0,0 +1,46 @@
+#!/bin/sh
+#
+# Restore / clear the Linux "SCSI target" driver configuration with `targetctl`
+#
+
+start() {
+ local ret
+
+ echo -n "Restoring target configuration: "
+ /usr/bin/targetctl restore >/dev/null 2>&1
+ ret=$?
+ echo "done"
+
+ return $ret
+}
+
+stop() {
+ local ret
+
+ echo -n "Clearing target configuration: "
+ /usr/bin/targetctl clear >/dev/null 2>&1
+ ret=$?
+ echo "done"
+
+ return $ret
+}
+
+restart() {
+ stop
+ start
+}
+
+case "$1" in
+ start)
+ start
+ ;;
+ stop)
+ stop
+ ;;
+ restart)
+ restart
+ ;;
+ *)
+ echo "Usage: $0 {start|stop|restart}"
+ exit 1
+esac
diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
index 2384569..b83a6b6 100644
--- a/package/targetcli-fb/targetcli-fb.mk
+++ b/package/targetcli-fb/targetcli-fb.mk
@@ -11,4 +11,15 @@ TARGETCLI_FB_LICENSE_FILES = COPYING
TARGETCLI_FB_SETUP_TYPE = setuptools
TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb
+define TARGETCLI_FB_INSTALL_INITSCRIPT
+ @if [ ! -f $(TARGET_DIR)/etc/init.d/S50target ]; then \
+ $(INSTALL) -m 0755 -D package/targetcli-fb/S50target $(TARGET_DIR)/etc/init.d/S50target; \
+ fi
+ @if [ ! -d $(TARGET_DIR)/etc/target ]; then \
+ $(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/target; \
+ fi
+endef
+
+TARGETCLI_FB_POST_INSTALL_TARGET_HOOKS += TARGETCLI_FB_INSTALL_INITSCRIPT
+
$(eval $(python-package))
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
@ 2014-09-17 12:12 ` Thomas Petazzoni
2014-09-17 13:19 ` Christophe Vu-Brugier
0 siblings, 1 reply; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 12:12 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 13:39:59 +0200, Christophe Vu-Brugier wrote:
> Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> ---
> package/targetcli-fb/S50target | 46 ++++++++++++++++++++++++++++++++++++
> package/targetcli-fb/targetcli-fb.mk | 11 +++++++++
> 2 files changed, 57 insertions(+)
> create mode 100755 package/targetcli-fb/S50target
I think this should be part of the previous patch.
> diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
> index 2384569..b83a6b6 100644
> --- a/package/targetcli-fb/targetcli-fb.mk
> +++ b/package/targetcli-fb/targetcli-fb.mk
> @@ -11,4 +11,15 @@ TARGETCLI_FB_LICENSE_FILES = COPYING
> TARGETCLI_FB_SETUP_TYPE = setuptools
> TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb
>
> +define TARGETCLI_FB_INSTALL_INITSCRIPT
> + @if [ ! -f $(TARGET_DIR)/etc/init.d/S50target ]; then \
> + $(INSTALL) -m 0755 -D package/targetcli-fb/S50target $(TARGET_DIR)/etc/init.d/S50target; \
> + fi
This should not be handled using a post install target hook, but rather
using the TARGETCLI_FB_INIT_SYSV mechanism. See the Buildroot manual or
other packages for example (dnsmasq for example, or ntp if you want to
see both the SysV and the systemd cases).
Also, I don't think adding a @ at the beginning is really needed, as we
usually don't do that I believe. The test could also be summarized as:
[ -f $(TARGET_DIR)/etc/init.d/S50target ] || \
$(INSTALL) ...
> + @if [ ! -d $(TARGET_DIR)/etc/target ]; then \
> + $(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/target; \
> + fi
This should continue to belong to post install hook because it isn't
related to which init system is used. Is the test really necessary in
this case? Maybe you can just to the $(INSTALL), which doesn't fail if
the directory already exists I believe. If not, just use mkdir -p and
that's it. If you really want to be nice, you could also add a comment
above the hook explaining why this directory is needed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript
2014-09-17 12:12 ` Thomas Petazzoni
@ 2014-09-17 13:19 ` Christophe Vu-Brugier
2014-09-17 13:21 ` Thomas Petazzoni
0 siblings, 1 reply; 19+ messages in thread
From: Christophe Vu-Brugier @ 2014-09-17 13:19 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, 17 Sep 2014 14:12:04 +0200, Thomas Petazzoni wrote :
> On Wed, 17 Sep 2014 13:39:59 +0200, Christophe Vu-Brugier wrote:
> > Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> > ---
> > package/targetcli-fb/S50target | 46 ++++++++++++++++++++++++++++++++++++
> > package/targetcli-fb/targetcli-fb.mk | 11 +++++++++
> > 2 files changed, 57 insertions(+)
> > create mode 100755 package/targetcli-fb/S50target
>
> I think this should be part of the previous patch.
OK.
> > diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
> > index 2384569..b83a6b6 100644
> > --- a/package/targetcli-fb/targetcli-fb.mk
> > +++ b/package/targetcli-fb/targetcli-fb.mk
> > @@ -11,4 +11,15 @@ TARGETCLI_FB_LICENSE_FILES = COPYING
> > TARGETCLI_FB_SETUP_TYPE = setuptools
> > TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb
> >
> > +define TARGETCLI_FB_INSTALL_INITSCRIPT
> > + @if [ ! -f $(TARGET_DIR)/etc/init.d/S50target ]; then \
> > + $(INSTALL) -m 0755 -D package/targetcli-fb/S50target $(TARGET_DIR)/etc/init.d/S50target; \
> > + fi
>
> This should not be handled using a post install target hook, but rather
> using the TARGETCLI_FB_INIT_SYSV mechanism. See the Buildroot manual or
> other packages for example (dnsmasq for example, or ntp if you want to
> see both the SysV and the systemd cases).
OK. By the way, I also intend to add a systemd unit file later.
> Also, I don't think adding a @ at the beginning is really needed, as we
> usually don't do that I believe. The test could also be summarized as:
>
> [ -f $(TARGET_DIR)/etc/init.d/S50target ] || \
> $(INSTALL) ...
>
> > + @if [ ! -d $(TARGET_DIR)/etc/target ]; then \
> > + $(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/target; \
> > + fi
>
> This should continue to belong to post install hook because it isn't
> related to which init system is used. Is the test really necessary in
> this case? Maybe you can just to the $(INSTALL), which doesn't fail if
> the directory already exists I believe. If not, just use mkdir -p and
> that's it. If you really want to be nice, you could also add a comment
> above the hook explaining why this directory is needed.
The directory "/etc/target" is needed because it is expected by
targetcli. The configuration of the "SCSI target" driver is stored in a
JSON file named "/etc/target/saveconfig.json". This configuration is
used to create the configfs hierarchy that configures the target driver.
Thank you!
^ permalink raw reply [flat|nested] 19+ messages in thread
* [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript
2014-09-17 13:19 ` Christophe Vu-Brugier
@ 2014-09-17 13:21 ` Thomas Petazzoni
0 siblings, 0 replies; 19+ messages in thread
From: Thomas Petazzoni @ 2014-09-17 13:21 UTC (permalink / raw)
To: buildroot
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 15:19:25 +0200, Christophe Vu-Brugier wrote:
> > This should not be handled using a post install target hook, but rather
> > using the TARGETCLI_FB_INIT_SYSV mechanism. See the Buildroot manual or
> > other packages for example (dnsmasq for example, or ntp if you want to
> > see both the SysV and the systemd cases).
>
> OK. By the way, I also intend to add a systemd unit file later.
Great!
> > This should continue to belong to post install hook because it isn't
> > related to which init system is used. Is the test really necessary in
> > this case? Maybe you can just to the $(INSTALL), which doesn't fail if
> > the directory already exists I believe. If not, just use mkdir -p and
> > that's it. If you really want to be nice, you could also add a comment
> > above the hook explaining why this directory is needed.
>
> The directory "/etc/target" is needed because it is expected by
> targetcli. The configuration of the "SCSI target" driver is stored in a
> JSON file named "/etc/target/saveconfig.json". This configuration is
> used to create the configfs hierarchy that configures the target driver.
Ok, makes sense. Maybe just add exactly this explanation as a comment
above the creation of /etc/target ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread