All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Andrew Victor <linux@maxim.org.za>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, Johan Hovold <jhovold@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 9/9] mfd: syscon: add Atmel GPBR DT bindings documention
Date: Wed, 17 Sep 2014 19:57:27 +0200	[thread overview]
Message-ID: <20140917195727.1c75a062@bbrezillon> (raw)
In-Reply-To: <20140917163405.GM30918@lee--X1>

Hi Lee,

On Wed, 17 Sep 2014 09:34:05 -0700
Lee Jones <lee.jones@linaro.org> wrote:

> On Thu, 11 Sep 2014, Boris BREZILLON wrote:
> 
> > The GPBR block provides a set of battery-backed registers that can be used
> > to save data which need to be kept when the system is powered down and
> > VDD-core is maintained by an external battery.
> > 
> > A typical usage is the RTT block (when used as an RTC) which needs one of
> > those registers to save the current time.
> > 
> > Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/atmel,gpbr.txt | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > new file mode 100644
> > index 0000000..a285695
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > @@ -0,0 +1,15 @@
> > +* Device tree bindings for Atmel GPBR (General Purpose Backup Registers)
> > +
> > +The GPBR are a set of battery-backed registers.
> > +
> > +Required properties:
> > +- compatible:		"atmel,at91sam9260-gpbr", "syscon"
> > +- reg:			contains offset/length value of the GPBR memory
> > +			region.
> > +
> > +Example:
> > +
> > +gpbr: gpbr@fffffd50 {
> 
> Is something referencing this node via phandle?  If not, please remove
> the label.

Yes, the rtt device is referencing it in its atmel,rtt-rtc-time-reg
property (see patch 8 of this series).

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 9/9] mfd: syscon: add Atmel GPBR DT bindings documention
Date: Wed, 17 Sep 2014 19:57:27 +0200	[thread overview]
Message-ID: <20140917195727.1c75a062@bbrezillon> (raw)
In-Reply-To: <20140917163405.GM30918@lee--X1>

Hi Lee,

On Wed, 17 Sep 2014 09:34:05 -0700
Lee Jones <lee.jones@linaro.org> wrote:

> On Thu, 11 Sep 2014, Boris BREZILLON wrote:
> 
> > The GPBR block provides a set of battery-backed registers that can be used
> > to save data which need to be kept when the system is powered down and
> > VDD-core is maintained by an external battery.
> > 
> > A typical usage is the RTT block (when used as an RTC) which needs one of
> > those registers to save the current time.
> > 
> > Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/atmel,gpbr.txt | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > new file mode 100644
> > index 0000000..a285695
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,gpbr.txt
> > @@ -0,0 +1,15 @@
> > +* Device tree bindings for Atmel GPBR (General Purpose Backup Registers)
> > +
> > +The GPBR are a set of battery-backed registers.
> > +
> > +Required properties:
> > +- compatible:		"atmel,at91sam9260-gpbr", "syscon"
> > +- reg:			contains offset/length value of the GPBR memory
> > +			region.
> > +
> > +Example:
> > +
> > +gpbr: gpbr at fffffd50 {
> 
> Is something referencing this node via phandle?  If not, please remove
> the label.

Yes, the rtt device is referencing it in its atmel,rtt-rtc-time-reg
property (see patch 8 of this series).

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2014-09-17 17:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 13:18 [PATCH v4 0/9] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11 13:18 ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 1/9] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 2/9] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 3/9] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 4/9] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 5/9] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:44   ` Boris BREZILLON
2014-09-11 13:44     ` Boris BREZILLON
2014-09-11 13:53   ` [PATCH v5 " Boris BREZILLON
2014-09-11 13:53     ` Boris BREZILLON
2014-09-11 13:53     ` Boris BREZILLON
2014-09-11 17:42     ` Alexandre Belloni
2014-09-11 17:42       ` Alexandre Belloni
2014-09-11 17:42       ` Alexandre Belloni
2014-09-12  5:33       ` Boris BREZILLON
2014-09-12  5:33         ` Boris BREZILLON
2014-09-12  5:33         ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 6/9] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 7/9] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 8/9] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-11 13:18 ` [PATCH v4 9/9] mfd: syscon: add Atmel GPBR DT bindings documention Boris BREZILLON
2014-09-11 13:18   ` Boris BREZILLON
2014-09-17 16:34   ` Lee Jones
2014-09-17 16:34     ` Lee Jones
2014-09-17 16:34     ` Lee Jones
2014-09-17 17:57     ` Boris BREZILLON [this message]
2014-09-17 17:57       ` Boris BREZILLON
2014-09-17 21:32       ` Lee Jones
2014-09-17 21:32         ` Lee Jones
2014-09-17 21:32         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917195727.1c75a062@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jhovold@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.