All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: Carlo Caione <carlo@caione.org>
Cc: linux@roeck-us.net, wim@iguana.be,
	linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	maxime.ripard@free-electrons.com, linux@arm.linux.org.uk
Subject: Re: [PATCH v2 1/4] ARM: docs: add documentation binding for meson watchdog
Date: Wed, 17 Sep 2014 22:58:27 +0200	[thread overview]
Message-ID: <20140917205827.GA5269@gmail.com> (raw)
In-Reply-To: <1410984726-18944-2-git-send-email-carlo@caione.org>

On Wed, Sep 17, 2014 at 10:12:03PM +0200, Carlo Caione wrote:
> Signed-off-by: Carlo Caione <carlo@caione.org>
> ---
>  Documentation/devicetree/bindings/watchdog/meson-wdt.txt | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> new file mode 100644
> index 0000000..e66c0c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> @@ -0,0 +1,13 @@
> +Meson SoCs Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "amlogic,meson-wdt"

Hi Carlo,

the compatible property should describe a specific version of the
device, so maybe "amlogic,meson6-wdt" would be more appropriate.

Beniamino

> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +wdt: watchdog@c1109900 {
> +	compatible = "amlogic,meson-wdt";
> +	reg = <0xc1109900 0x8>;
> +};
> -- 
> 1.9.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: b.galvani@gmail.com (Beniamino Galvani)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] ARM: docs: add documentation binding for meson watchdog
Date: Wed, 17 Sep 2014 22:58:27 +0200	[thread overview]
Message-ID: <20140917205827.GA5269@gmail.com> (raw)
In-Reply-To: <1410984726-18944-2-git-send-email-carlo@caione.org>

On Wed, Sep 17, 2014 at 10:12:03PM +0200, Carlo Caione wrote:
> Signed-off-by: Carlo Caione <carlo@caione.org>
> ---
>  Documentation/devicetree/bindings/watchdog/meson-wdt.txt | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/meson-wdt.txt b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> new file mode 100644
> index 0000000..e66c0c3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/meson-wdt.txt
> @@ -0,0 +1,13 @@
> +Meson SoCs Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "amlogic,meson-wdt"

Hi Carlo,

the compatible property should describe a specific version of the
device, so maybe "amlogic,meson6-wdt" would be more appropriate.

Beniamino

> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +wdt: watchdog at c1109900 {
> +	compatible = "amlogic,meson-wdt";
> +	reg = <0xc1109900 0x8>;
> +};
> -- 
> 1.9.1
> 

  reply	other threads:[~2014-09-17 20:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 20:12 [PATCH v2 0/4] ARM: meson: watchdog driver Carlo Caione
2014-09-17 20:12 ` Carlo Caione
2014-09-17 20:12 ` [PATCH v2 1/4] ARM: docs: add documentation binding for meson watchdog Carlo Caione
2014-09-17 20:12   ` Carlo Caione
2014-09-17 20:58   ` Beniamino Galvani [this message]
2014-09-17 20:58     ` Beniamino Galvani
2014-09-19  8:07     ` Carlo Caione
2014-09-19  8:07       ` Carlo Caione
2014-09-17 20:12 ` [PATCH v2 2/4] ARM: meson: add watchdog driver Carlo Caione
2014-09-17 20:12   ` Carlo Caione
2014-09-19  3:31   ` Guenter Roeck
2014-09-19  3:31     ` Guenter Roeck
2014-09-19  8:07     ` Carlo Caione
2014-09-19  8:07       ` Carlo Caione
2014-09-17 20:12 ` [PATCH v2 3/4] ARM: DTS: meson: update DTSI to add watchdog node Carlo Caione
2014-09-17 20:12   ` Carlo Caione
2014-09-17 20:12 ` [PATCH v2 4/4] ARM: defconfig: update multi_v7_defconfig Carlo Caione
2014-09-17 20:12   ` Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917205827.GA5269@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=carlo@caione.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@roeck-us.net \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.