Re: i2c-core.ko renamed to i2ccore.ko

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Thu, Sep 18, 2014 at 03:58:57PM +0300, Mika Westerberg wrote:
> On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote:
> > Hi guys,
> > 
> > Sorry for jumping in a bit late, but given that I did not get involved
> > in the discussions that led to this decision, better late than never.
> > 
> > I almost had an heart attack when noticing that module i2c-core.ko has
> > suddenly been renamed to i2ccore.ko without an hyphen.
> > 
> > Renaming kernel modules is almost always wrong, in particular subsystem
> > core modules. Such renames have an impact at various levels. We just had
> > to change a configuration file in the openSUSE Factory kernel to adjust
> > that change, and this is how I noticed it. But there can be several
> > other issues, including mkinitrd or equivalent tools, as well as
> > documentation. The extra work and confusion is a high price to pay, and
> > it can easily be avoided.
> 
> I understand completely your point and I guess this was rather
> inadvertent change.

Yes. Thanks for pointing out, Jean!

> 
> > So I am kindly asking that you revert this name change before kernel
> > v3.17 final. Rename source files if you really have to, git makes it
> > easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
> > whatever. Just don't rename i2c-core.ko, please.
> 
> My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
> 
> Tianyu, Wolfram, comments?

Agreed.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]