From: Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: i2c-core.ko renamed to i2ccore.ko
Date: Fri, 19 Sep 2014 16:28:02 +0800 [thread overview]
Message-ID: <541BE912.6060905@intel.com> (raw)
In-Reply-To: <20140918150954.GA4420@katana>
On 2014年09月18日 23:10, Wolfram Sang wrote:
> On Thu, Sep 18, 2014 at 03:58:57PM +0300, Mika Westerberg wrote:
>> On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote:
>>> Hi guys,
>>>
>>> Sorry for jumping in a bit late, but given that I did not get involved
>>> in the discussions that led to this decision, better late than never.
>>>
>>> I almost had an heart attack when noticing that module i2c-core.ko has
>>> suddenly been renamed to i2ccore.ko without an hyphen.
>>>
>>> Renaming kernel modules is almost always wrong, in particular subsystem
>>> core modules. Such renames have an impact at various levels. We just had
>>> to change a configuration file in the openSUSE Factory kernel to adjust
>>> that change, and this is how I noticed it. But there can be several
>>> other issues, including mkinitrd or equivalent tools, as well as
>>> documentation. The extra work and confusion is a high price to pay, and
>>> it can easily be avoided.
>>
>> I understand completely your point and I guess this was rather
>> inadvertent change.
>
> Yes. Thanks for pointing out, Jean!
>
>>
>>> So I am kindly asking that you revert this name change before kernel
>>> v3.17 final. Rename source files if you really have to, git makes it
>>> easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
>>> whatever. Just don't rename i2c-core.ko, please.
>>
>> My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
>>
>> Tianyu, Wolfram, comments?
>
> Agreed.
>
How about including i2c-acpi.c in the i2c-core.c directly if ACPI is
selected?
--
Best regards
Tianyu Lan
next prev parent reply other threads:[~2014-09-19 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 12:17 i2c-core.ko renamed to i2ccore.ko Jean Delvare
[not found] ` <1411042678.7338.20.camel-H7Kp9ZFCxt/N0uC3ymp8PA@public.gmane.org>
2014-09-18 12:58 ` Mika Westerberg
[not found] ` <20140918125825.GR10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-18 15:10 ` Wolfram Sang
2014-09-19 8:28 ` Lan Tianyu [this message]
[not found] ` <541BE912.6060905-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-19 8:53 ` Mika Westerberg
[not found] ` <20140919085328.GC10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-20 9:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541BE912.6060905@intel.com \
--to=tianyu.lan-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.