All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Markus Pargmann <mpa@pengutronix.de>,
	Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>,
	Michael Trimarchi <michael@amarulasolutions.com>,
	Shawn Guo <shawn.guo@freescale.com>
Subject: Re: No sound captured with SGTL5000 on i.MX6 in I²S master mode
Date: Thu, 18 Sep 2014 16:50:46 -0700	[thread overview]
Message-ID: <20140918235045.GA4148@Asurada> (raw)
In-Reply-To: <CAOMZO5BJbzizB4r8vvtJEBzv+DhsyRmYMUoQL2D-dQhBorGkzA@mail.gmail.com>

On Thu, Sep 18, 2014 at 08:35:31PM -0300, Fabio Estevam wrote:
> On Thu, Sep 18, 2014 at 3:39 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
> 
> > It actually is merged into broonie/for-next and even linux-next I think.
> > I'll later send a patch to Shawn's tree for imx_v6_v7_defconfig changes
> > after next merge window's done.
> 
> Ok, I see it now, but master/slave configuration is still hardcoded there:
> 
>     } else if (of_device_is_compatible(np, "fsl,imx-audio-sgtl5000")) {
>         priv->codec_priv.mclk_id = SGTL5000_SYSCLK;
>         priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;

It's just a combinational driver and also made to be compatible with
old DTs. Unless we refine the DT binding like simple-card, this hard-
code is inevitable. As long as this dai_fmt has been defined, at least
AUDMUX part will be automatically configured.

I made this driver was initially to support ASRC for imx-cs42888. But
merging the code from imx-sgtl5000 and imx-wm8962 allows us to omit
a branch of duplicated code. And that's it :)

Nicolin

  reply	other threads:[~2014-09-18 23:50 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 12:56 No sound captured with SGTL5000 on i.MX6 in I²S master mode Jean-Michel Hautbois
2014-09-18 13:30 ` Fabio Estevam
2014-09-18 13:35   ` Michael Trimarchi
2014-09-18 13:45     ` Jean-Michel Hautbois
2014-09-18 13:55       ` Michael Trimarchi
2014-09-18 14:09         ` Jean-Michel Hautbois
2014-09-18 16:09           ` Jean-Michel Hautbois
2014-09-18 17:05             ` Nicolin Chen
2014-09-18 17:26               ` Michael Trimarchi
2014-09-18 17:45                 ` Nicolin Chen
2014-09-18 18:03                   ` Michael Trimarchi
2014-09-18 18:13                     ` Nicolin Chen
2014-09-18 18:18                       ` Michael Trimarchi
2014-09-18 17:28               ` Fabio Estevam
2014-09-18 17:49                 ` Nicolin Chen
2014-09-18 17:58                   ` Fabio Estevam
2014-09-18 18:07                     ` Nicolin Chen
2014-09-18 18:14                       ` Fabio Estevam
2014-09-18 18:39                         ` Nicolin Chen
2014-09-18 23:35                           ` Fabio Estevam
2014-09-18 23:50                             ` Nicolin Chen [this message]
2014-09-19  7:42                               ` Jean-Michel Hautbois
2014-09-19  7:52                                 ` Nicolin Chen
2014-09-19  9:18                                   ` Jean-Michel Hautbois
2014-09-19 12:53                                     ` Jean-Michel Hautbois
2014-10-09 14:02                                       ` Jean-Michel Hautbois
2014-10-09 14:18                                         ` Fabio Estevam
2014-10-09 14:26                                           ` Jean-Michel Hautbois
2014-10-09 15:06                                             ` Fabio Estevam
2014-10-09 15:14                                               ` Jean-Michel Hautbois
2014-10-09 15:19                                                 ` Fabio Estevam
2014-10-10 15:49                                                   ` Jean-Michel Hautbois
2014-10-10 15:54                                                     ` Fabio Estevam
2014-09-22  3:26                       ` Fabio Estevam
2014-09-22  3:41                         ` Nicolin Chen
2014-09-18 17:19   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140918235045.GA4148@Asurada \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=festevam@gmail.com \
    --cc=jean-michel.hautbois@vodalys.com \
    --cc=lars@metafoo.de \
    --cc=michael@amarulasolutions.com \
    --cc=mpa@pengutronix.de \
    --cc=shawn.guo@freescale.com \
    --cc=shengjiu.wang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.