From: Dan Carpenter <dan.carpenter@oracle.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
hayeswang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] r8169: fix an if condition
Date: Fri, 19 Sep 2014 10:40:25 +0000 [thread overview]
Message-ID: <20140919104025.GA26391@mwanda> (raw)
There is an extra semi-colon so __rtl8169_set_features() is called every
time.
Fixes: 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3027f4a..1d81238 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1882,7 +1882,7 @@ static int rtl8169_set_features(struct net_device *dev,
features &= NETIF_F_RXALL | NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_RX;
rtl_lock_work(tp);
- if (features ^ dev->features);
+ if (features ^ dev->features)
__rtl8169_set_features(dev, features);
rtl_unlock_work(tp);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
hayeswang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] r8169: fix an if condition
Date: Fri, 19 Sep 2014 13:40:25 +0300 [thread overview]
Message-ID: <20140919104025.GA26391@mwanda> (raw)
There is an extra semi-colon so __rtl8169_set_features() is called every
time.
Fixes: 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3027f4a..1d81238 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1882,7 +1882,7 @@ static int rtl8169_set_features(struct net_device *dev,
features &= NETIF_F_RXALL | NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_RX;
rtl_lock_work(tp);
- if (features ^ dev->features);
+ if (features ^ dev->features)
__rtl8169_set_features(dev, features);
rtl_unlock_work(tp);
next reply other threads:[~2014-09-19 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 10:40 Dan Carpenter [this message]
2014-09-19 10:40 ` [patch -next] r8169: fix an if condition Dan Carpenter
2014-09-22 2:30 ` Hayes Wang
2014-09-22 19:19 ` David Miller
2014-09-22 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919104025.GA26391@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hayeswang@realtek.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.