* [patch] UBI: return on error in rename_volumes()
@ 2014-09-19 10:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-09-19 10:56 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: linux-mtd, kernel-janitors, Brian Norris, David Woodhouse
I noticed this during a code review. We are checking that the strlen()
of ->name is not less than the ->name_len which the user gave us. I
believe this bug is harmless but clearly we meant to return here instead
of setting an error code and then not using it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm not totally familiar with the code so please review extra carefully.
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 20aeb27..59de69a 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -701,7 +701,7 @@ static int rename_volumes(struct ubi_device *ubi,
req->ents[i].name[req->ents[i].name_len] = '\0';
n = strlen(req->ents[i].name);
if (n != req->ents[i].name_len)
- err = -EINVAL;
+ return -EINVAL;
}
/* Make sure volume IDs and names are unique */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] UBI: return on error in rename_volumes()
@ 2014-09-19 10:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-09-19 10:56 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: linux-mtd, kernel-janitors, Brian Norris, David Woodhouse
I noticed this during a code review. We are checking that the strlen()
of ->name is not less than the ->name_len which the user gave us. I
believe this bug is harmless but clearly we meant to return here instead
of setting an error code and then not using it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I'm not totally familiar with the code so please review extra carefully.
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 20aeb27..59de69a 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -701,7 +701,7 @@ static int rename_volumes(struct ubi_device *ubi,
req->ents[i].name[req->ents[i].name_len] = '\0';
n = strlen(req->ents[i].name);
if (n != req->ents[i].name_len)
- err = -EINVAL;
+ return -EINVAL;
}
/* Make sure volume IDs and names are unique */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] UBI: return on error in rename_volumes()
2014-09-19 10:56 ` Dan Carpenter
@ 2014-09-19 15:15 ` Artem Bityutskiy
-1 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2014-09-19 15:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-mtd, kernel-janitors, Brian Norris, David Woodhouse
On Fri, 2014-09-19 at 13:56 +0300, Dan Carpenter wrote:
> I noticed this during a code review. We are checking that the strlen()
> of ->name is not less than the ->name_len which the user gave us. I
> believe this bug is harmless but clearly we meant to return here instead
> of setting an error code and then not using it.
Pushed to linux-ubifs.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] UBI: return on error in rename_volumes()
@ 2014-09-19 15:15 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2014-09-19 15:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-mtd, kernel-janitors, Brian Norris, David Woodhouse
On Fri, 2014-09-19 at 13:56 +0300, Dan Carpenter wrote:
> I noticed this during a code review. We are checking that the strlen()
> of ->name is not less than the ->name_len which the user gave us. I
> believe this bug is harmless but clearly we meant to return here instead
> of setting an error code and then not using it.
Pushed to linux-ubifs.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-19 15:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 10:56 [patch] UBI: return on error in rename_volumes() Dan Carpenter
2014-09-19 10:56 ` Dan Carpenter
2014-09-19 15:15 ` Artem Bityutskiy
2014-09-19 15:15 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.