From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] blk-mq: auto-start hw queue in requeue
Date: Fri, 19 Sep 2014 19:48:06 +0200 [thread overview]
Message-ID: <20140919174806.GA19983@lst.de> (raw)
In-Reply-To: <1411136570-23439-1-git-send-email-ming.lei@canonical.com>
On Fri, Sep 19, 2014 at 10:22:50PM +0800, Ming Lei wrote:
> Requests often need to be retried because of timeout, hardware
> busy or sort of reasons via blk_mq_requeue_request(), but at
> that time dispatch queue may have been stopped.
>
> This patch starts the dispatch queue automatically in requeue's
> work handler, and fixes scsi-mq's timeout issue, which can be
> triggered if there are two or more requests timedout.
Sounds like blk_mq_requeue_work should simply call void
blk_mq_start_hw_queues where it calls blk_mq_run_queues currently.
next prev parent reply other threads:[~2014-09-19 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 14:22 [PATCH] blk-mq: auto-start hw queue in requeue Ming Lei
2014-09-19 17:48 ` Christoph Hellwig [this message]
2014-09-19 17:52 ` Jens Axboe
2014-09-19 17:54 ` Christoph Hellwig
2014-09-19 18:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919174806.GA19983@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.