From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: auto-start hw queue in requeue
Date: Fri, 19 Sep 2014 12:03:03 -0600 [thread overview]
Message-ID: <541C6FD7.7090201@kernel.dk> (raw)
In-Reply-To: <20140919175452.GA20333@lst.de>
On 09/19/2014 11:54 AM, Christoph Hellwig wrote:
> On Fri, Sep 19, 2014 at 11:52:59AM -0600, Jens Axboe wrote:
>> I agree. I think Ming wanted to avoid an unnecessary bitflip if
>> possible, but the fix is more convoluted than I would like.
>
> If the requeue from irq context ever ends up in the fast path we
> have much worse problems..
Oh yes certainly, my point was purely that I think this is why Mings fix
ended up being more involved than it need be.
--
Jens Axboe
prev parent reply other threads:[~2014-09-19 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 14:22 [PATCH] blk-mq: auto-start hw queue in requeue Ming Lei
2014-09-19 17:48 ` Christoph Hellwig
2014-09-19 17:52 ` Jens Axboe
2014-09-19 17:54 ` Christoph Hellwig
2014-09-19 18:03 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C6FD7.7090201@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.