All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-pci <linux-pci@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tanmay Inamdar <tinamdar@apm.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Sinan Kaya <okaya@codeaurora.org>,
	Jingoo Han <jg1.han@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Device Tree ML <devicetree@vger.kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v11 10/10] PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources into CPU space
Date: Sat, 20 Sep 2014 04:20:31 +0200	[thread overview]
Message-ID: <201409200420.31433.arnd@arndb.de> (raw)
In-Reply-To: <20140919215400.GA30239@google.com>

On Friday 19 September 2014, Bjorn Helgaas wrote:
> On Thu, Sep 18, 2014 at 02:30:25AM +0100, Liviu Dudau wrote:

> PCI_IOBASE is a virtual address.  So PCI_IOBASE + res->start is also a
> virtual address (only for IORESOURCE_IO).
> 
> Since res->start is normally a *physical* address, I think it would be less
> confusing to do something like this:
> 
>     vaddr = PCI_IOBASE + res->start;
>     ioremap_page_range(vaddr, vaddr + resource_size(res), ...);
> 
> so we have a hint that the first two ioremap_page_range() parameters are
> virtual addresses.  It's also confusing that it uses "unsigned long" for
> the virtual addresses, when we usually use "void *".  But that's out of
> scope for this patch.

Good idea. I think it will have to be (unsigned long)PCI_IOBASE above then,
since ioremap_page_range takes a 'unsigned long' virtual address and PCI_IOBASE
should really remain an __iomem pointer.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 10/10] PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources into CPU space
Date: Sat, 20 Sep 2014 04:20:31 +0200	[thread overview]
Message-ID: <201409200420.31433.arnd@arndb.de> (raw)
In-Reply-To: <20140919215400.GA30239@google.com>

On Friday 19 September 2014, Bjorn Helgaas wrote:
> On Thu, Sep 18, 2014 at 02:30:25AM +0100, Liviu Dudau wrote:

> PCI_IOBASE is a virtual address.  So PCI_IOBASE + res->start is also a
> virtual address (only for IORESOURCE_IO).
> 
> Since res->start is normally a *physical* address, I think it would be less
> confusing to do something like this:
> 
>     vaddr = PCI_IOBASE + res->start;
>     ioremap_page_range(vaddr, vaddr + resource_size(res), ...);
> 
> so we have a hint that the first two ioremap_page_range() parameters are
> virtual addresses.  It's also confusing that it uses "unsigned long" for
> the virtual addresses, when we usually use "void *".  But that's out of
> scope for this patch.

Good idea. I think it will have to be (unsigned long)PCI_IOBASE above then,
since ioremap_page_range takes a 'unsigned long' virtual address and PCI_IOBASE
should really remain an __iomem pointer.

	Arnd

  reply	other threads:[~2014-09-20  2:20 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18  1:30 [PATCH v11 00/10] Support for creating generic PCI host bridges from DT Liviu Dudau
2014-09-18  1:30 ` Liviu Dudau
2014-09-18  1:30 ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 01/10] Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 02/10] PCI: Introduce helper functions to deal with PCI I/O ranges Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
     [not found]   ` <1411003825-21521-3-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2014-09-19 20:48     ` Bjorn Helgaas
2014-09-19 20:48       ` Bjorn Helgaas
2014-09-19 20:48       ` Bjorn Helgaas
2014-09-18  1:30 ` [PATCH v11 03/10] ARM: Define PCI_IOBASE as the base of virtual PCI IO space Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
     [not found]   ` <1411003825-21521-4-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2014-09-20  2:14     ` Arnd Bergmann
2014-09-20  2:14       ` Arnd Bergmann
2014-09-20  2:14       ` Arnd Bergmann
2014-09-18  1:30 ` [PATCH v11 04/10] PCI: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-19 20:56   ` Bjorn Helgaas
2014-09-19 20:56     ` Bjorn Helgaas
2014-09-19 20:56     ` Bjorn Helgaas
2014-09-20 17:33   ` Rob Herring
2014-09-20 17:33     ` Rob Herring
2014-09-22 15:32     ` Liviu Dudau
2014-09-22 15:32       ` Liviu Dudau
2014-09-22 15:32       ` Liviu Dudau
2014-09-22 17:18       ` Rob Herring
2014-09-22 17:18         ` Rob Herring
2014-09-22 17:18         ` Rob Herring
2014-09-18  1:30 ` [PATCH v11 05/10] PCI: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 06/10] PCI: Introduce generic domain handling for PCI busses Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 07/10] OF: Introduce helper function for getting PCI domain_nr Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-19 21:03   ` Bjorn Helgaas
2014-09-19 21:03     ` Bjorn Helgaas
2014-09-22 11:05     ` Liviu Dudau
2014-09-22 11:05       ` Liviu Dudau
2014-09-22 15:25       ` Bjorn Helgaas
2014-09-22 15:25         ` Bjorn Helgaas
2014-09-22 15:33         ` Liviu Dudau
2014-09-22 15:33           ` Liviu Dudau
2014-09-20  2:24   ` Arnd Bergmann
2014-09-20  2:24     ` Arnd Bergmann
2014-09-22 15:20     ` Liviu Dudau
2014-09-22 15:20       ` Liviu Dudau
2014-09-20 17:52   ` Rob Herring
2014-09-20 17:52     ` Rob Herring
2014-09-18  1:30 ` [PATCH v11 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-19 21:06   ` Bjorn Helgaas
2014-09-19 21:06     ` Bjorn Helgaas
2014-09-20  0:28     ` Rob Herring
2014-09-20  0:28       ` Rob Herring
2014-09-22 17:55       ` Liviu Dudau
2014-09-22 17:55         ` Liviu Dudau
2014-09-22 22:11         ` Rob Herring
2014-09-22 22:11           ` Rob Herring
2014-09-22  9:32   ` Robert Richter
2014-09-22  9:32     ` Robert Richter
2014-09-22  9:32     ` Robert Richter
2014-09-22  9:32     ` Robert Richter
2014-09-22 11:43     ` Liviu Dudau
2014-09-22 11:43       ` Liviu Dudau
2014-09-22 11:43       ` Liviu Dudau
     [not found]       ` <20140922114317.GN1994-2JSQmVVBSi7ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-09-22 12:15         ` Robert Richter
2014-09-22 12:15           ` Robert Richter
2014-09-22 12:15           ` Robert Richter
2014-09-23  7:56       ` Arnd Bergmann
2014-09-23  7:56         ` Arnd Bergmann
2014-09-23  7:56         ` Arnd Bergmann
2014-09-23 10:49         ` Liviu Dudau
2014-09-23 10:49           ` Liviu Dudau
2014-09-23 10:49           ` Liviu Dudau
2014-09-23 13:30         ` Rob Herring
2014-09-23 13:30           ` Rob Herring
2014-09-23 13:30           ` Rob Herring
2014-09-23 13:58           ` Liviu Dudau
2014-09-23 13:58             ` Liviu Dudau
2014-09-23 13:58             ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 09/10] PCI: Assign unassigned bus resources in pci_scan_root_bus() Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30 ` [PATCH v11 10/10] PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources into CPU space Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-18  1:30   ` Liviu Dudau
2014-09-19 21:54   ` Bjorn Helgaas
2014-09-19 21:54     ` Bjorn Helgaas
2014-09-20  2:20     ` Arnd Bergmann [this message]
2014-09-20  2:20       ` Arnd Bergmann
2014-09-22 15:29       ` Robert Richter
2014-09-22 15:29         ` Robert Richter
2014-09-20  0:34   ` Rob Herring
2014-09-20  0:34     ` Rob Herring
2014-09-19 21:59 ` [PATCH v11 00/10] Support for creating generic PCI host bridges from DT Bjorn Helgaas
2014-09-19 21:59   ` Bjorn Helgaas
2014-09-22 11:35   ` Liviu Dudau
2014-09-22 11:35     ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201409200420.31433.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Liviu.Dudau@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jg1.han@samsung.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=okaya@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.