From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 3/3] i2c-rcar: make rcar_i2c_irq_recv() *void*
Date: Sat, 20 Sep 2014 11:45:10 +0200 [thread overview]
Message-ID: <20140920094510.GJ1612@katana> (raw)
In-Reply-To: <19871938.mRdZLUD6Mv@wasted.cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
On Mon, Sep 15, 2014 at 12:17:34AM +0400, Sergei Shtylyov wrote:
> rcar_i2c_irq_recv() always returns 0, so we can make this function return
> *void* and also remove rcar_i2c_flags_set() invocation in rcar_i2c_irq().
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I prefer to skip this patch to have more similarity between the
send_irq and recv_irq routines.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 3/3] i2c-rcar: make rcar_i2c_irq_recv() *void*
Date: Sat, 20 Sep 2014 09:45:10 +0000 [thread overview]
Message-ID: <20140920094510.GJ1612@katana> (raw)
In-Reply-To: <19871938.mRdZLUD6Mv@wasted.cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
On Mon, Sep 15, 2014 at 12:17:34AM +0400, Sergei Shtylyov wrote:
> rcar_i2c_irq_recv() always returns 0, so we can make this function return
> *void* and also remove rcar_i2c_flags_set() invocation in rcar_i2c_irq().
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I prefer to skip this patch to have more similarity between the
send_irq and recv_irq routines.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-20 9:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 20:12 [PATCH v2 0/3] R-Car I2C driver: some cleanups Sergei Shtylyov
2014-09-14 20:12 ` Sergei Shtylyov
2014-09-14 20:14 ` [PATCH v2 1/3] i2c-rcar: simplify check for last message Sergei Shtylyov
2014-09-14 20:14 ` Sergei Shtylyov
2014-09-20 9:41 ` Wolfram Sang
2014-09-20 9:41 ` Wolfram Sang
2014-09-14 20:15 ` [PATCH v2 2/3] i2c-rcar: make rcar_i2c_prepare_msg() *void* Sergei Shtylyov
2014-09-14 20:15 ` Sergei Shtylyov
2014-09-20 9:44 ` Wolfram Sang
2014-09-20 9:44 ` Wolfram Sang
2014-09-14 20:17 ` [PATCH v2 3/3] i2c-rcar: make rcar_i2c_irq_recv() *void* Sergei Shtylyov
2014-09-14 20:17 ` Sergei Shtylyov
2014-09-20 9:45 ` Wolfram Sang [this message]
2014-09-20 9:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920094510.GJ1612@katana \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.