From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook
Date: Sat, 20 Sep 2014 15:19:50 +0200 [thread overview]
Message-ID: <20140920151950.443b7ea9@free-electrons.com> (raw)
In-Reply-To: <1411155880-23447-2-git-send-email-f.fainelli@gmail.com>
Dear Florian Fainelli,
On Fri, 19 Sep 2014 12:44:39 -0700, Florian Fainelli wrote:
> -void __init brcmstb_hook_fault_code(void)
> +static int __init brcmstb_hook_fault_code(void)
> {
> hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0,
> "imprecise external abort");
> + return 0;
> }
> +arch_initcall(brcmstb_hook_fault_code)
I don't have the entire context, but if your platform is part of
multi-platform, it means that regardless of which platform is actually
booting your system, you will register your fault hook. Is this the
intended behavior?
Generally speaking, in a multiplatform context, many arch_initcall()
should have a conditional to check whether we're really on a platform
where the initcall is needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, computersforpeace@gmail.com,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: Re: [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook
Date: Sat, 20 Sep 2014 15:19:50 +0200 [thread overview]
Message-ID: <20140920151950.443b7ea9@free-electrons.com> (raw)
In-Reply-To: <1411155880-23447-2-git-send-email-f.fainelli@gmail.com>
Dear Florian Fainelli,
On Fri, 19 Sep 2014 12:44:39 -0700, Florian Fainelli wrote:
> -void __init brcmstb_hook_fault_code(void)
> +static int __init brcmstb_hook_fault_code(void)
> {
> hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0,
> "imprecise external abort");
> + return 0;
> }
> +arch_initcall(brcmstb_hook_fault_code)
I don't have the entire context, but if your platform is part of
multi-platform, it means that regardless of which platform is actually
booting your system, you will register your fault hook. Is this the
intended behavior?
Generally speaking, in a multiplatform context, many arch_initcall()
should have a conditional to check whether we're really on a platform
where the initcall is needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-20 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 19:44 [PATCH 0/2] bus: brcmstb_gisb: misc fixes Florian Fainelli
2014-09-19 19:44 ` Florian Fainelli
2014-09-19 19:44 ` [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook Florian Fainelli
2014-09-19 19:44 ` Florian Fainelli
2014-09-19 19:45 ` Florian Fainelli
2014-09-19 19:45 ` Florian Fainelli
2014-09-20 13:19 ` Thomas Petazzoni [this message]
2014-09-20 13:19 ` Thomas Petazzoni
2014-09-21 23:10 ` Brian Norris
2014-09-21 23:10 ` Brian Norris
2014-09-22 6:57 ` Thomas Petazzoni
2014-09-22 6:57 ` Thomas Petazzoni
2014-09-19 19:44 ` [PATCH 2/2] bus: brcmstb_gisb: save and restore GISB timeout Florian Fainelli
2014-09-19 19:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920151950.443b7ea9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.