From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Anders Berg <anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 22 Sep 2014 15:16:40 +0200 [thread overview]
Message-ID: <20140922131640.GU3755@pengutronix.de> (raw)
In-Reply-To: <20140920121242.GA3833@katana>
On Sat, Sep 20, 2014 at 02:12:43PM +0200, Wolfram Sang wrote:
> Hi,
>
> thanks for the submission.
>
> On Mon, Aug 25, 2014 at 01:51:22PM +0200, Anders Berg wrote:
> > Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
> > driver implements 10-bit addressing and SMBus transfer modes via emulation
> > (including SMBus block data read).
> >
> > Signed-off-by: Anders Berg <anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
>
> Looks pretty good already. Still, some comments:
>
> > +config I2C_AXXIA
> > + tristate "Axxia I2C controller"
> > + depends on ARCH_AXXIA
> > + help
> > + Say yes if you want to support the I2C bus on Axxia platforms.
> > +
> > + If you don't know, say Y.
>
> I'd say skip this sentence and consider 'default y' if it is really
> needed on this platform.
Still better:
depends on ARCH_AXXIA || COMPILE_TEST
default ARCH_AXXIA
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 22 Sep 2014 15:16:40 +0200 [thread overview]
Message-ID: <20140922131640.GU3755@pengutronix.de> (raw)
In-Reply-To: <20140920121242.GA3833@katana>
On Sat, Sep 20, 2014 at 02:12:43PM +0200, Wolfram Sang wrote:
> Hi,
>
> thanks for the submission.
>
> On Mon, Aug 25, 2014 at 01:51:22PM +0200, Anders Berg wrote:
> > Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
> > driver implements 10-bit addressing and SMBus transfer modes via emulation
> > (including SMBus block data read).
> >
> > Signed-off-by: Anders Berg <anders.berg@avagotech.com>
>
> Looks pretty good already. Still, some comments:
>
> > +config I2C_AXXIA
> > + tristate "Axxia I2C controller"
> > + depends on ARCH_AXXIA
> > + help
> > + Say yes if you want to support the I2C bus on Axxia platforms.
> > +
> > + If you don't know, say Y.
>
> I'd say skip this sentence and consider 'default y' if it is really
> needed on this platform.
Still better:
depends on ARCH_AXXIA || COMPILE_TEST
default ARCH_AXXIA
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Anders Berg <anders.berg@avagotech.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: axxia: Add I2C driver for AXM55xx
Date: Mon, 22 Sep 2014 15:16:40 +0200 [thread overview]
Message-ID: <20140922131640.GU3755@pengutronix.de> (raw)
In-Reply-To: <20140920121242.GA3833@katana>
On Sat, Sep 20, 2014 at 02:12:43PM +0200, Wolfram Sang wrote:
> Hi,
>
> thanks for the submission.
>
> On Mon, Aug 25, 2014 at 01:51:22PM +0200, Anders Berg wrote:
> > Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
> > driver implements 10-bit addressing and SMBus transfer modes via emulation
> > (including SMBus block data read).
> >
> > Signed-off-by: Anders Berg <anders.berg@avagotech.com>
>
> Looks pretty good already. Still, some comments:
>
> > +config I2C_AXXIA
> > + tristate "Axxia I2C controller"
> > + depends on ARCH_AXXIA
> > + help
> > + Say yes if you want to support the I2C bus on Axxia platforms.
> > +
> > + If you don't know, say Y.
>
> I'd say skip this sentence and consider 'default y' if it is really
> needed on this platform.
Still better:
depends on ARCH_AXXIA || COMPILE_TEST
default ARCH_AXXIA
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-09-22 13:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 11:51 [PATCH] i2c: axxia: Add I2C driver for AXM55xx Anders Berg
2014-08-25 11:51 ` Anders Berg
2014-08-25 11:51 ` Anders Berg
[not found] ` <1408967482-17723-1-git-send-email-anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
2014-09-20 12:12 ` Wolfram Sang
2014-09-20 12:12 ` Wolfram Sang
2014-09-20 12:12 ` Wolfram Sang
2014-09-22 9:19 ` Anders Berg
2014-09-22 9:19 ` Anders Berg
2014-09-22 9:19 ` Anders Berg
[not found] ` <CAE0=X_0VQ8rWrUgbsgKm1MwCP8bwWm3UJPq9p=xNDfjP4CC7Bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-22 9:59 ` Wolfram Sang
2014-09-22 9:59 ` Wolfram Sang
2014-09-22 9:59 ` Wolfram Sang
2014-09-22 10:24 ` Anders Berg
2014-09-22 10:24 ` Anders Berg
2014-09-22 10:24 ` Anders Berg
2014-09-22 10:47 ` Anders Berg
2014-09-22 10:47 ` Anders Berg
[not found] ` <CAE0=X_1v_1eNr=dPTgofamFuy6zP9ff=LS7dyexj4CeutDqaPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-22 11:04 ` Wolfram Sang
2014-09-22 11:04 ` Wolfram Sang
2014-09-22 11:04 ` Wolfram Sang
2014-09-22 12:18 ` Anders Berg
2014-09-22 12:18 ` Anders Berg
2014-09-22 13:03 ` Russell King - ARM Linux
2014-09-22 13:03 ` Russell King - ARM Linux
2014-09-22 13:03 ` Russell King - ARM Linux
[not found] ` <20140922130351.GL5182-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-09-22 14:49 ` Wolfram Sang
2014-09-22 14:49 ` Wolfram Sang
2014-09-22 14:49 ` Wolfram Sang
2014-09-22 13:16 ` Uwe Kleine-König [this message]
2014-09-22 13:16 ` Uwe Kleine-König
2014-09-22 13:16 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922131640.GU3755@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=anders.berg-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.