All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Matlack <dmatlack@google.com>,
	Gleb Natapov <gleb@kernel.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: don't take vcpu mutex for obviously invalid vcpu ioctls
Date: Mon, 22 Sep 2014 20:00:29 -0300	[thread overview]
Message-ID: <20140922230029.GA12293@amt.cnet> (raw)
In-Reply-To: <542094AC.6070908@redhat.com>

On Mon, Sep 22, 2014 at 11:29:16PM +0200, Paolo Bonzini wrote:
> Il 22/09/2014 22:08, Marcelo Tosatti ha scritto:
> > > This patch does not change functionality, it just makes invalid ioctls
> > > fail faster.
> > 
> > Should not be executing vcpu ioctls without interrupt KVM_RUN in the
> > first place.
> 
> This is not entirely true, there are a couple of asynchronous ioctls
> though they are not used on x86 (commit 2122ff5eab8f, KVM: move vcpu
> locking to dispatcher for generic vcpu ioctls, 2010-05-13).
> 
> Paolo

Alright. 

s/Should not be executing vcpu ioctls/Should not be executing vcpu
ioctls which take vcpu mutex/

  reply	other threads:[~2014-09-22 23:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 23:03 [PATCH] kvm: don't take vcpu mutex for obviously invalid vcpu ioctls David Matlack
2014-09-22 10:50 ` Paolo Bonzini
2014-09-22 13:45   ` Christian Borntraeger
2014-09-22 14:31     ` Paolo Bonzini
2014-09-22 18:35       ` David Matlack
2014-09-22 19:20       ` Christian Borntraeger
2014-09-22 19:29         ` Paolo Bonzini
2014-09-23  6:49           ` Gleb Natapov
2014-09-23  8:06             ` Christian Borntraeger
2014-09-23  8:23               ` Paolo Bonzini
2014-09-22 19:40         ` David Matlack
2014-09-22 20:08 ` Marcelo Tosatti
2014-09-22 21:29   ` Paolo Bonzini
2014-09-22 23:00     ` Marcelo Tosatti [this message]
2014-09-22 22:58   ` David Matlack
2014-09-23  0:13     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140922230029.GA12293@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=dmatlack@google.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.