From: Johan Hovold <jhovold@gmail.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andrew Victor <linux@maxim.org.za>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Johan Hovold <jhovold@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 8/9] rtc: at91sam9: add DT bindings documentation
Date: Tue, 23 Sep 2014 09:57:50 +0200 [thread overview]
Message-ID: <20140923075750.GP5237@localhost> (raw)
In-Reply-To: <1411400563-570-9-git-send-email-boris.brezillon@free-electrons.com>
On Mon, Sep 22, 2014 at 05:42:42PM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> new file mode 100644
> index 0000000..e94e2ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> @@ -0,0 +1,23 @@
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtt alarm/event interrupt
> +- clocks: should contain one clock pointing the the slow clk
Just noticed: s/the the/to the/
> +- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
> + the time base when the RTT is used as an RTC.
> + The first cell should point to the GPBR node and the second one
> + encode the offset within the GPBR block (or in other words, the
> + GPBR register used to store the current time value).
s/current time value/time base/.
Looks good to me otherwise.
Thanks,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: jhovold@gmail.com (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 8/9] rtc: at91sam9: add DT bindings documentation
Date: Tue, 23 Sep 2014 09:57:50 +0200 [thread overview]
Message-ID: <20140923075750.GP5237@localhost> (raw)
In-Reply-To: <1411400563-570-9-git-send-email-boris.brezillon@free-electrons.com>
On Mon, Sep 22, 2014 at 05:42:42PM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
> .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> new file mode 100644
> index 0000000..e94e2ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> @@ -0,0 +1,23 @@
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtt alarm/event interrupt
> +- clocks: should contain one clock pointing the the slow clk
Just noticed: s/the the/to the/
> +- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
> + the time base when the RTT is used as an RTC.
> + The first cell should point to the GPBR node and the second one
> + encode the offset within the GPBR block (or in other words, the
> + GPBR register used to store the current time value).
s/current time value/time base/.
Looks good to me otherwise.
Thanks,
Johan
next prev parent reply other threads:[~2014-09-23 7:57 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 15:42 [PATCH v6 0/9] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` [PATCH v6 1/9] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:13 ` Nicolas Ferre
2014-09-23 8:13 ` Nicolas Ferre
2014-09-23 8:13 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 2/9] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:14 ` Nicolas Ferre
2014-09-23 8:14 ` Nicolas Ferre
2014-09-23 8:14 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 3/9] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:15 ` Nicolas Ferre
2014-09-23 8:15 ` Nicolas Ferre
2014-09-23 8:15 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 4/9] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:16 ` Nicolas Ferre
2014-09-23 8:16 ` Nicolas Ferre
2014-09-23 8:16 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 5/9] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:31 ` Nicolas Ferre
2014-09-23 8:31 ` Nicolas Ferre
2014-09-23 8:31 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 6/9] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:23 ` Nicolas Ferre
2014-09-23 8:23 ` Nicolas Ferre
2014-09-23 8:23 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 7/9] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:21 ` Nicolas Ferre
2014-09-23 8:21 ` Nicolas Ferre
2014-09-23 8:21 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 8/9] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 7:57 ` Johan Hovold [this message]
2014-09-23 7:57 ` Johan Hovold
2014-09-23 8:24 ` Nicolas Ferre
2014-09-23 8:24 ` Nicolas Ferre
2014-09-23 8:24 ` Nicolas Ferre
2014-09-22 15:42 ` [PATCH v6 9/9] mfd: syscon: add Atmel GPBR DT bindings documention Boris BREZILLON
2014-09-22 15:42 ` Boris BREZILLON
2014-09-23 8:23 ` Nicolas Ferre
2014-09-23 8:23 ` Nicolas Ferre
2014-09-23 8:23 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923075750.GP5237@localhost \
--to=jhovold@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.