From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Johan Hovold <johan@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andrew Victor <linux@maxim.org.za>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Johan Hovold <jhovold@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK
Date: Tue, 23 Sep 2014 13:05:06 +0200 [thread overview]
Message-ID: <20140923130506.3433c5a3@bbrezillon> (raw)
In-Reply-To: <20140923103326.GA404@localhost>
On Tue, 23 Sep 2014 12:33:26 +0200
Johan Hovold <johan@kernel.org> wrote:
> On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
>
> > @@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > struct sam9_rtc *rtc;
> > int ret, irq;
> > u32 mr;
> > + unsigned int sclk_rate;
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > @@ -385,11 +386,27 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > }
> >
> > + rtc->sclk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(rtc->sclk))
> > + return PTR_ERR(rtc->sclk);
> > +
> > + sclk_rate = clk_get_rate(rtc->sclk);
> > + if (!sclk_rate || sclk_rate > AT91_RTT_RTTRST) {
>
> You probably meant AT91_RTT_RTPRES here.
Yes, that's what I meant.
Nice catch!
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK
Date: Tue, 23 Sep 2014 13:05:06 +0200 [thread overview]
Message-ID: <20140923130506.3433c5a3@bbrezillon> (raw)
In-Reply-To: <20140923103326.GA404@localhost>
On Tue, 23 Sep 2014 12:33:26 +0200
Johan Hovold <johan@kernel.org> wrote:
> On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
>
> > @@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > struct sam9_rtc *rtc;
> > int ret, irq;
> > u32 mr;
> > + unsigned int sclk_rate;
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > @@ -385,11 +386,27 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > }
> >
> > + rtc->sclk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(rtc->sclk))
> > + return PTR_ERR(rtc->sclk);
> > +
> > + sclk_rate = clk_get_rate(rtc->sclk);
> > + if (!sclk_rate || sclk_rate > AT91_RTT_RTTRST) {
>
> You probably meant AT91_RTT_RTPRES here.
Yes, that's what I meant.
Nice catch!
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK
Date: Tue, 23 Sep 2014 13:05:06 +0200 [thread overview]
Message-ID: <20140923130506.3433c5a3@bbrezillon> (raw)
In-Reply-To: <20140923103326.GA404@localhost>
On Tue, 23 Sep 2014 12:33:26 +0200
Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Tue, Sep 23, 2014 at 11:38:48AM +0200, Boris BREZILLON wrote:
>
> > @@ -328,6 +328,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > struct sam9_rtc *rtc;
> > int ret, irq;
> > u32 mr;
> > + unsigned int sclk_rate;
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0) {
> > @@ -385,11 +386,27 @@ static int at91_rtc_probe(struct platform_device *pdev)
> > return -ENOMEM;
> > }
> >
> > + rtc->sclk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(rtc->sclk))
> > + return PTR_ERR(rtc->sclk);
> > +
> > + sclk_rate = clk_get_rate(rtc->sclk);
> > + if (!sclk_rate || sclk_rate > AT91_RTT_RTTRST) {
>
> You probably meant AT91_RTT_RTPRES here.
Yes, that's what I meant.
Nice catch!
Thanks,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-23 11:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 9:38 [PATCH v7 00/10] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 01/10] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 02/10] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 03/10] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 04/10] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 05/10] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 06/10] rtc: at91sam9: rework the Kconfig description Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 10:08 ` Nicolas Ferre
2014-09-23 10:08 ` Nicolas Ferre
2014-09-23 10:08 ` Nicolas Ferre
2014-09-23 10:11 ` Boris BREZILLON
2014-09-23 10:11 ` Boris BREZILLON
2014-09-23 10:11 ` Boris BREZILLON
2014-09-23 10:39 ` Johan Hovold
2014-09-23 10:39 ` Johan Hovold
2014-09-23 10:39 ` Johan Hovold
2014-09-23 9:38 ` [PATCH v7 07/10] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 10:33 ` Johan Hovold
2014-09-23 10:33 ` Johan Hovold
2014-09-23 10:33 ` Johan Hovold
2014-09-23 11:05 ` Boris BREZILLON [this message]
2014-09-23 11:05 ` Boris BREZILLON
2014-09-23 11:05 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 09/10] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
2014-09-23 9:38 ` [PATCH v7 10/10] mfd: syscon: add Atmel GPBR DT bindings documention Boris BREZILLON
2014-09-23 9:38 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923130506.3433c5a3@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jhovold@gmail.com \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.