From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Antonios Motakis
<a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
Cc: Shuah Khan <shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Marc Zyngier <Marc.Zyngier-5wv7dgnIgG8@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Alexey Kardashevskiy
<aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>,
"moderated list:ARM SMMU DRIVER"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org"
<tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>,
"kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org"
<kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org>,
"christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCHv7 01/26] iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC
Date: Tue, 23 Sep 2014 15:58:16 +0100 [thread overview]
Message-ID: <20140923145816.GE28608@arm.com> (raw)
In-Reply-To: <1411483586-29304-2-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
Hi Antonios,
On Tue, Sep 23, 2014 at 03:46:00PM +0100, Antonios Motakis wrote:
> Exposing the XN flag of the SMMU driver as IOMMU_NOEXEC instead of
> IOMMU_EXEC makes it enforceable, since for IOMMUs that don't support
> the XN flag pages will always be executable.
>
> Signed-off-by: Antonios Motakis <a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 9 +++++----
> include/linux/iommu.h | 2 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
[...]
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 20f9a52..e1a644c 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -27,7 +27,7 @@
> #define IOMMU_READ (1 << 0)
> #define IOMMU_WRITE (1 << 1)
> #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */
> -#define IOMMU_EXEC (1 << 3)
> +#define IOMMU_NOEXEC (1 << 3)
This hunk needs to be a separate patch merged by Joerg before I can take the
arm-smmu part (which looks fine).
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 01/26] iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC
Date: Tue, 23 Sep 2014 15:58:16 +0100 [thread overview]
Message-ID: <20140923145816.GE28608@arm.com> (raw)
In-Reply-To: <1411483586-29304-2-git-send-email-a.motakis@virtualopensystems.com>
Hi Antonios,
On Tue, Sep 23, 2014 at 03:46:00PM +0100, Antonios Motakis wrote:
> Exposing the XN flag of the SMMU driver as IOMMU_NOEXEC instead of
> IOMMU_EXEC makes it enforceable, since for IOMMUs that don't support
> the XN flag pages will always be executable.
>
> Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
> ---
> drivers/iommu/arm-smmu.c | 9 +++++----
> include/linux/iommu.h | 2 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
[...]
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 20f9a52..e1a644c 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -27,7 +27,7 @@
> #define IOMMU_READ (1 << 0)
> #define IOMMU_WRITE (1 << 1)
> #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */
> -#define IOMMU_EXEC (1 << 3)
> +#define IOMMU_NOEXEC (1 << 3)
This hunk needs to be a separate patch merged by Joerg before I can take the
arm-smmu part (which looks fine).
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Antonios Motakis <a.motakis@virtualopensystems.com>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"tech@virtualopensystems.com" <tech@virtualopensystems.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"kim.phillips@freescale.com" <kim.phillips@freescale.com>,
"eric.auger@linaro.org" <eric.auger@linaro.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <shuah.kh@samsung.com>,
Thierry Reding <treding@nvidia.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"Upinder Malhi (umalhi)" <umalhi@cisco.com>,
"moderated list:ARM SMMU DRIVER"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv7 01/26] iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC
Date: Tue, 23 Sep 2014 15:58:16 +0100 [thread overview]
Message-ID: <20140923145816.GE28608@arm.com> (raw)
In-Reply-To: <1411483586-29304-2-git-send-email-a.motakis@virtualopensystems.com>
Hi Antonios,
On Tue, Sep 23, 2014 at 03:46:00PM +0100, Antonios Motakis wrote:
> Exposing the XN flag of the SMMU driver as IOMMU_NOEXEC instead of
> IOMMU_EXEC makes it enforceable, since for IOMMUs that don't support
> the XN flag pages will always be executable.
>
> Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
> ---
> drivers/iommu/arm-smmu.c | 9 +++++----
> include/linux/iommu.h | 2 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
[...]
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 20f9a52..e1a644c 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -27,7 +27,7 @@
> #define IOMMU_READ (1 << 0)
> #define IOMMU_WRITE (1 << 1)
> #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */
> -#define IOMMU_EXEC (1 << 3)
> +#define IOMMU_NOEXEC (1 << 3)
This hunk needs to be a separate patch merged by Joerg before I can take the
arm-smmu part (which looks fine).
Will
next prev parent reply other threads:[~2014-09-23 14:58 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 14:45 [PATCHv7 00/26] VFIO support for platform and AMBA devices on ARM Antonios Motakis
[not found] ` <1411483586-29304-1-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 14:46 ` [PATCHv7 01/26] iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-2-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 14:58 ` Will Deacon [this message]
2014-09-23 14:58 ` Will Deacon
2014-09-23 14:58 ` Will Deacon
[not found] ` <20140923145816.GE28608-5wv7dgnIgG8@public.gmane.org>
2014-09-23 22:14 ` Alex Williamson
2014-09-23 22:14 ` Alex Williamson
2014-09-23 22:14 ` Alex Williamson
2014-09-23 14:46 ` [PATCHv7 02/26] iommu: add capability IOMMU_CAP_NOEXEC Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-3-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-26 9:48 ` Joerg Roedel
2014-09-26 9:48 ` Joerg Roedel
[not found] ` <20140926094827.GE28786-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-09-26 15:00 ` Antonios Motakis
2014-09-26 15:00 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 03/26] iommu/arm-smmu: add IOMMU_CAP_NOEXEC to the ARM SMMU driver Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 04/26] vfio/iommu_type1: support for platform bus devices on ARM Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 05/26] vfio: introduce the VFIO_DMA_MAP_FLAG_NOEXEC flag Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-6-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 22:21 ` Alex Williamson
2014-09-23 22:21 ` Alex Williamson
[not found] ` <1411510876.24563.47.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-23 22:30 ` Alex Williamson
2014-09-23 22:30 ` Alex Williamson
[not found] ` <1411511426.24563.52.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:45 ` Antonios Motakis
2014-09-26 15:45 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 06/26] vfio/iommu_type1: implement " Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-7-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 22:40 ` Alex Williamson
2014-09-23 22:40 ` Alex Williamson
[not found] ` <1411512059.24563.57.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:39 ` Antonios Motakis
2014-09-26 15:39 ` Antonios Motakis
[not found] ` <CAG8rG2z14gT28jec66o3UQ=z-omNv+bC43moJT-FhdUtd2OJDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-26 20:27 ` Alex Williamson
2014-09-26 20:27 ` Alex Williamson
[not found] ` <1411763257.7360.49.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-29 10:38 ` Antonios Motakis
2014-09-29 10:38 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 07/26] driver core: amba: add device binding path 'driver_override' Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-8-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 22:45 ` Alex Williamson
2014-09-23 22:45 ` Alex Williamson
[not found] ` <1411512325.24563.59.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:10 ` Antonios Motakis
2014-09-26 15:10 ` Antonios Motakis
2014-09-26 15:37 ` Russell King - ARM Linux
[not found] ` <20140926153751.GW5182-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-09-29 10:14 ` Antonios Motakis
2014-09-29 10:14 ` Antonios Motakis
2014-10-08 12:18 ` Antonios Motakis
2014-10-08 12:18 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 08/26] driver core: amba: add documentation for " Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 09/26] vfio/platform: initial skeleton of VFIO support for platform devices Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 10/26] vfio: platform: probe to devices on the platform bus Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-11-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 23:01 ` Alex Williamson
2014-09-23 23:01 ` Alex Williamson
[not found] ` <1411513277.24563.61.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:30 ` Antonios Motakis
2014-09-26 15:30 ` Antonios Motakis
[not found] ` <CAG8rG2wECWL2w9Xyvs7tZx8bqdMqk2SP8gfYpq=ZY0_Jk0Q+-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-26 20:18 ` Alex Williamson
2014-09-26 20:18 ` Alex Williamson
[not found] ` <1411762736.7360.42.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-29 10:21 ` Antonios Motakis
2014-09-29 10:21 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 11/26] vfio: platform: add the VFIO PLATFORM module to Kconfig Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 12/26] vfio: amba: VFIO support for AMBA devices Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 13/26] vfio: amba: add the VFIO for AMBA devices module to Kconfig Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-14-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-23 23:11 ` Alex Williamson
2014-09-23 23:11 ` Alex Williamson
[not found] ` <1411513877.24563.62.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:06 ` Antonios Motakis
2014-09-26 15:06 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 14/26] vfio/platform: return info for bound device Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 15/26] vfio/platform: return info for device memory mapped IO regions Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 16/26] vfio/platform: read and write support for the device fd Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 17/26] vfio/platform: support MMAP of MMIO regions Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 18/26] vfio/platform: return IRQ info Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 19/26] vfio/platform: initial interrupts support code Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 20/26] vfio/platform: trigger an interrupt via eventfd Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
[not found] ` <1411483586-29304-21-git-send-email-a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
2014-09-24 17:00 ` Alex Williamson
2014-09-24 17:00 ` Alex Williamson
[not found] ` <1411578009.24563.107.camel-85EaTFmN5p//9pzu0YdTqQ@public.gmane.org>
2014-09-26 15:03 ` Antonios Motakis
2014-09-26 15:03 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 21/26] vfio/platform: support for maskable and automasked interrupts Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 22/26] vfio: move eventfd support code for VFIO_PCI to a separate file Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 23/26] vfio: add local lock in virqfd instead of depending on VFIO PCI Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 24/26] vfio: pass an opaque pointer on virqfd initialization Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 25/26] vfio: initialize the virqfd workqueue in VFIO generic code Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
2014-09-23 14:46 ` [PATCHv7 26/26] vfio/platform: implement IRQ masking/unmasking via an eventfd Antonios Motakis
2014-09-23 14:46 ` Antonios Motakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923145816.GE28608@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=Marc.Zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
--cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \
--cc=christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvmarm-FPEHb7Xf0XXUo1n7N8X6UoWGPAHP3yOg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=tech-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.