* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 14:29 ` Pranith Kumar
0 siblings, 0 replies; 19+ messages in thread
From: Pranith Kumar @ 2014-09-23 14:29 UTC (permalink / raw)
To: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE..., Chris Zankel,
Max Filippov, Arnd Bergmann, Peter Zijlstra, Paul E. McKenney,
Chen Gang, Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki,
Sam Ravnborg, open list:ALPHA PORT, open list,
moderated list:ARM PORT, open list:CRIS PORT,
open list:IA64 (Itanium) PL..., moderated list:M32R ARCHITECTURE,
open list:M32R ARCHITECTURE, open list:M68K ARCHITECTURE,
open list:MIPS, open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
is purely a style change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
arch/alpha/include/asm/atomic.h | 4 ++--
arch/arm/include/asm/atomic.h | 2 +-
arch/arm64/include/asm/atomic.h | 4 ++--
arch/avr32/include/asm/atomic.h | 2 +-
arch/cris/include/asm/atomic.h | 2 +-
arch/frv/include/asm/atomic.h | 2 +-
arch/ia64/include/asm/atomic.h | 4 ++--
arch/m32r/include/asm/atomic.h | 2 +-
arch/m68k/include/asm/atomic.h | 2 +-
arch/mips/include/asm/atomic.h | 4 ++--
arch/parisc/include/asm/atomic.h | 4 ++--
arch/sh/include/asm/atomic.h | 2 +-
arch/sparc/include/asm/atomic_32.h | 2 +-
arch/sparc/include/asm/atomic_64.h | 4 ++--
arch/x86/include/asm/atomic.h | 2 +-
arch/x86/include/asm/atomic64_64.h | 2 +-
arch/xtensa/include/asm/atomic.h | 2 +-
include/asm-generic/atomic.h | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h
index 6fbb53a..8f8eafb 100644
--- a/arch/alpha/include/asm/atomic.h
+++ b/arch/alpha/include/asm/atomic.h
@@ -17,8 +17,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#define atomic64_set(v,i) ((v)->counter = (i))
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 832f1cd..e22c119 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -27,7 +27,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#if __LINUX_ARM_ARCH__ >= 6
diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h
index b83c325..7047051 100644
--- a/arch/arm64/include/asm/atomic.h
+++ b/arch/arm64/include/asm/atomic.h
@@ -35,7 +35,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/*
@@ -139,7 +139,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)
*/
#define ATOMIC64_INIT(i) { (i) }
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic64_set(v,i) (((v)->counter) = (i))
#define ATOMIC64_OP(op, asm_op) \
diff --git a/arch/avr32/include/asm/atomic.h b/arch/avr32/include/asm/atomic.h
index 83e980a..2d07ce1 100644
--- a/arch/avr32/include/asm/atomic.h
+++ b/arch/avr32/include/asm/atomic.h
@@ -19,7 +19,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define ATOMIC_OP_RETURN(op, asm_op, asm_con) \
diff --git a/arch/cris/include/asm/atomic.h b/arch/cris/include/asm/atomic.h
index 0033f9d..279766a 100644
--- a/arch/cris/include/asm/atomic.h
+++ b/arch/cris/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/* These should be written in asm but we do it in C for now. */
diff --git a/arch/frv/include/asm/atomic.h b/arch/frv/include/asm/atomic.h
index f6c3a16..102190a 100644
--- a/arch/frv/include/asm/atomic.h
+++ b/arch/frv/include/asm/atomic.h
@@ -31,7 +31,7 @@
*/
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = (i))
#ifndef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
diff --git a/arch/ia64/include/asm/atomic.h b/arch/ia64/include/asm/atomic.h
index 42919a8..0bf0350 100644
--- a/arch/ia64/include/asm/atomic.h
+++ b/arch/ia64/include/asm/atomic.h
@@ -21,8 +21,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#define atomic64_set(v,i) (((v)->counter) = (i))
diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h
index 3946b2c..31bb74a 100644
--- a/arch/m32r/include/asm/atomic.h
+++ b/arch/m32r/include/asm/atomic.h
@@ -28,7 +28,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/arch/m68k/include/asm/atomic.h b/arch/m68k/include/asm/atomic.h
index 663d4ba..e85f047 100644
--- a/arch/m68k/include/asm/atomic.h
+++ b/arch/m68k/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
/*
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index f3ee721..6dd6bfc 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -29,7 +29,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic_set - set atomic variable
@@ -306,7 +306,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u)
* @v: pointer of type atomic64_t
*
*/
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic64_set - set atomic variable
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h
index 219750b..226f8ca 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -67,7 +67,7 @@ static __inline__ void atomic_set(atomic_t *v, int i)
static __inline__ int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/* exported interface */
@@ -204,7 +204,7 @@ atomic64_set(atomic64_t *v, s64 i)
static __inline__ s64
atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
#define atomic64_inc(v) (atomic64_add( 1,(v)))
diff --git a/arch/sh/include/asm/atomic.h b/arch/sh/include/asm/atomic.h
index f57b8a6..05b9f74 100644
--- a/arch/sh/include/asm/atomic.h
+++ b/arch/sh/include/asm/atomic.h
@@ -14,7 +14,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#if defined(CONFIG_GUSA_RB)
diff --git a/arch/sparc/include/asm/atomic_32.h b/arch/sparc/include/asm/atomic_32.h
index 7b024f0..765c177 100644
--- a/arch/sparc/include/asm/atomic_32.h
+++ b/arch/sparc/include/asm/atomic_32.h
@@ -26,7 +26,7 @@ int atomic_cmpxchg(atomic_t *, int, int);
int __atomic_add_unless(atomic_t *, int, int);
void atomic_set(atomic_t *, int);
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_add(i, v) ((void)atomic_add_return( (int)(i), (v)))
#define atomic_sub(i, v) ((void)atomic_add_return(-(int)(i), (v)))
diff --git a/arch/sparc/include/asm/atomic_64.h b/arch/sparc/include/asm/atomic_64.h
index 7e4ca1e..4082749 100644
--- a/arch/sparc/include/asm/atomic_64.h
+++ b/arch/sparc/include/asm/atomic_64.h
@@ -14,8 +14,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define atomic64_set(v, i) (((v)->counter) = i)
diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index bf20c81..5e5cd12 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -24,7 +24,7 @@
*/
static inline int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/x86/include/asm/atomic64_64.h b/arch/x86/include/asm/atomic64_64.h
index 46e9052..f8d273e 100644
--- a/arch/x86/include/asm/atomic64_64.h
+++ b/arch/x86/include/asm/atomic64_64.h
@@ -18,7 +18,7 @@
*/
static inline long atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/xtensa/include/asm/atomic.h b/arch/xtensa/include/asm/atomic.h
index 6266766..00b7d46 100644
--- a/arch/xtensa/include/asm/atomic.h
+++ b/arch/xtensa/include/asm/atomic.h
@@ -47,7 +47,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h
index 56d4d36..1973ad2 100644
--- a/include/asm-generic/atomic.h
+++ b/include/asm-generic/atomic.h
@@ -126,7 +126,7 @@ ATOMIC_OP(or, |)
* Atomically reads the value of @v.
*/
#ifndef atomic_read
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#endif
/**
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 14:29 ` Pranith Kumar
0 siblings, 0 replies; 19+ messages in thread
From: Pranith Kumar @ 2014-09-23 14:29 UTC (permalink / raw)
To: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE..., Chris Zankel,
Max Filippov, Arnd Bergmann, Peter Zijlstra, Paul E. McKenney,
Chen Gang, Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki,
Sam Ravnborg, open list:ALPHA PORT, open list,
moderated list:ARM PORT, open list:CRIS PORT,
open list:IA64 Itanium PL..., moderated list:M32R ARCHITECTURE,
open list:M32R ARCHITECTURE, open list:M68K ARCHITECTURE,
open list:MIPS, open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
is purely a style change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
arch/alpha/include/asm/atomic.h | 4 ++--
arch/arm/include/asm/atomic.h | 2 +-
arch/arm64/include/asm/atomic.h | 4 ++--
arch/avr32/include/asm/atomic.h | 2 +-
arch/cris/include/asm/atomic.h | 2 +-
arch/frv/include/asm/atomic.h | 2 +-
arch/ia64/include/asm/atomic.h | 4 ++--
arch/m32r/include/asm/atomic.h | 2 +-
arch/m68k/include/asm/atomic.h | 2 +-
arch/mips/include/asm/atomic.h | 4 ++--
arch/parisc/include/asm/atomic.h | 4 ++--
arch/sh/include/asm/atomic.h | 2 +-
arch/sparc/include/asm/atomic_32.h | 2 +-
arch/sparc/include/asm/atomic_64.h | 4 ++--
arch/x86/include/asm/atomic.h | 2 +-
arch/x86/include/asm/atomic64_64.h | 2 +-
arch/xtensa/include/asm/atomic.h | 2 +-
include/asm-generic/atomic.h | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h
index 6fbb53a..8f8eafb 100644
--- a/arch/alpha/include/asm/atomic.h
+++ b/arch/alpha/include/asm/atomic.h
@@ -17,8 +17,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#define atomic64_set(v,i) ((v)->counter = (i))
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 832f1cd..e22c119 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -27,7 +27,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#if __LINUX_ARM_ARCH__ >= 6
diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h
index b83c325..7047051 100644
--- a/arch/arm64/include/asm/atomic.h
+++ b/arch/arm64/include/asm/atomic.h
@@ -35,7 +35,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/*
@@ -139,7 +139,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)
*/
#define ATOMIC64_INIT(i) { (i) }
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic64_set(v,i) (((v)->counter) = (i))
#define ATOMIC64_OP(op, asm_op) \
diff --git a/arch/avr32/include/asm/atomic.h b/arch/avr32/include/asm/atomic.h
index 83e980a..2d07ce1 100644
--- a/arch/avr32/include/asm/atomic.h
+++ b/arch/avr32/include/asm/atomic.h
@@ -19,7 +19,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define ATOMIC_OP_RETURN(op, asm_op, asm_con) \
diff --git a/arch/cris/include/asm/atomic.h b/arch/cris/include/asm/atomic.h
index 0033f9d..279766a 100644
--- a/arch/cris/include/asm/atomic.h
+++ b/arch/cris/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/* These should be written in asm but we do it in C for now. */
diff --git a/arch/frv/include/asm/atomic.h b/arch/frv/include/asm/atomic.h
index f6c3a16..102190a 100644
--- a/arch/frv/include/asm/atomic.h
+++ b/arch/frv/include/asm/atomic.h
@@ -31,7 +31,7 @@
*/
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = (i))
#ifndef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
diff --git a/arch/ia64/include/asm/atomic.h b/arch/ia64/include/asm/atomic.h
index 42919a8..0bf0350 100644
--- a/arch/ia64/include/asm/atomic.h
+++ b/arch/ia64/include/asm/atomic.h
@@ -21,8 +21,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#define atomic64_set(v,i) (((v)->counter) = (i))
diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h
index 3946b2c..31bb74a 100644
--- a/arch/m32r/include/asm/atomic.h
+++ b/arch/m32r/include/asm/atomic.h
@@ -28,7 +28,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/arch/m68k/include/asm/atomic.h b/arch/m68k/include/asm/atomic.h
index 663d4ba..e85f047 100644
--- a/arch/m68k/include/asm/atomic.h
+++ b/arch/m68k/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
/*
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index f3ee721..6dd6bfc 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -29,7 +29,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic_set - set atomic variable
@@ -306,7 +306,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u)
* @v: pointer of type atomic64_t
*
*/
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic64_set - set atomic variable
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h
index 219750b..226f8ca 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -67,7 +67,7 @@ static __inline__ void atomic_set(atomic_t *v, int i)
static __inline__ int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/* exported interface */
@@ -204,7 +204,7 @@ atomic64_set(atomic64_t *v, s64 i)
static __inline__ s64
atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
#define atomic64_inc(v) (atomic64_add( 1,(v)))
diff --git a/arch/sh/include/asm/atomic.h b/arch/sh/include/asm/atomic.h
index f57b8a6..05b9f74 100644
--- a/arch/sh/include/asm/atomic.h
+++ b/arch/sh/include/asm/atomic.h
@@ -14,7 +14,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#if defined(CONFIG_GUSA_RB)
diff --git a/arch/sparc/include/asm/atomic_32.h b/arch/sparc/include/asm/atomic_32.h
index 7b024f0..765c177 100644
--- a/arch/sparc/include/asm/atomic_32.h
+++ b/arch/sparc/include/asm/atomic_32.h
@@ -26,7 +26,7 @@ int atomic_cmpxchg(atomic_t *, int, int);
int __atomic_add_unless(atomic_t *, int, int);
void atomic_set(atomic_t *, int);
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_add(i, v) ((void)atomic_add_return( (int)(i), (v)))
#define atomic_sub(i, v) ((void)atomic_add_return(-(int)(i), (v)))
diff --git a/arch/sparc/include/asm/atomic_64.h b/arch/sparc/include/asm/atomic_64.h
index 7e4ca1e..4082749 100644
--- a/arch/sparc/include/asm/atomic_64.h
+++ b/arch/sparc/include/asm/atomic_64.h
@@ -14,8 +14,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define atomic64_set(v, i) (((v)->counter) = i)
diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index bf20c81..5e5cd12 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -24,7 +24,7 @@
*/
static inline int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/x86/include/asm/atomic64_64.h b/arch/x86/include/asm/atomic64_64.h
index 46e9052..f8d273e 100644
--- a/arch/x86/include/asm/atomic64_64.h
+++ b/arch/x86/include/asm/atomic64_64.h
@@ -18,7 +18,7 @@
*/
static inline long atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/xtensa/include/asm/atomic.h b/arch/xtensa/include/asm/atomic.h
index 6266766..00b7d46 100644
--- a/arch/xtensa/include/asm/atomic.h
+++ b/arch/xtensa/include/asm/atomic.h
@@ -47,7 +47,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h
index 56d4d36..1973ad2 100644
--- a/include/asm-generic/atomic.h
+++ b/include/asm-generic/atomic.h
@@ -126,7 +126,7 @@ ATOMIC_OP(or, |)
* Atomically reads the value of @v.
*/
#ifndef atomic_read
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#endif
/**
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 14:29 ` Pranith Kumar
0 siblings, 0 replies; 19+ messages in thread
From: Pranith Kumar @ 2014-09-23 14:29 UTC (permalink / raw)
To: linux-arm-kernel
Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
is purely a style change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
arch/alpha/include/asm/atomic.h | 4 ++--
arch/arm/include/asm/atomic.h | 2 +-
arch/arm64/include/asm/atomic.h | 4 ++--
arch/avr32/include/asm/atomic.h | 2 +-
arch/cris/include/asm/atomic.h | 2 +-
arch/frv/include/asm/atomic.h | 2 +-
arch/ia64/include/asm/atomic.h | 4 ++--
arch/m32r/include/asm/atomic.h | 2 +-
arch/m68k/include/asm/atomic.h | 2 +-
arch/mips/include/asm/atomic.h | 4 ++--
arch/parisc/include/asm/atomic.h | 4 ++--
arch/sh/include/asm/atomic.h | 2 +-
arch/sparc/include/asm/atomic_32.h | 2 +-
arch/sparc/include/asm/atomic_64.h | 4 ++--
arch/x86/include/asm/atomic.h | 2 +-
arch/x86/include/asm/atomic64_64.h | 2 +-
arch/xtensa/include/asm/atomic.h | 2 +-
include/asm-generic/atomic.h | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h
index 6fbb53a..8f8eafb 100644
--- a/arch/alpha/include/asm/atomic.h
+++ b/arch/alpha/include/asm/atomic.h
@@ -17,8 +17,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#define atomic64_set(v,i) ((v)->counter = (i))
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 832f1cd..e22c119 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -27,7 +27,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#if __LINUX_ARM_ARCH__ >= 6
diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h
index b83c325..7047051 100644
--- a/arch/arm64/include/asm/atomic.h
+++ b/arch/arm64/include/asm/atomic.h
@@ -35,7 +35,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/*
@@ -139,7 +139,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)
*/
#define ATOMIC64_INIT(i) { (i) }
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic64_set(v,i) (((v)->counter) = (i))
#define ATOMIC64_OP(op, asm_op) \
diff --git a/arch/avr32/include/asm/atomic.h b/arch/avr32/include/asm/atomic.h
index 83e980a..2d07ce1 100644
--- a/arch/avr32/include/asm/atomic.h
+++ b/arch/avr32/include/asm/atomic.h
@@ -19,7 +19,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define ATOMIC_OP_RETURN(op, asm_op, asm_con) \
diff --git a/arch/cris/include/asm/atomic.h b/arch/cris/include/asm/atomic.h
index 0033f9d..279766a 100644
--- a/arch/cris/include/asm/atomic.h
+++ b/arch/cris/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/* These should be written in asm but we do it in C for now. */
diff --git a/arch/frv/include/asm/atomic.h b/arch/frv/include/asm/atomic.h
index f6c3a16..102190a 100644
--- a/arch/frv/include/asm/atomic.h
+++ b/arch/frv/include/asm/atomic.h
@@ -31,7 +31,7 @@
*/
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = (i))
#ifndef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
diff --git a/arch/ia64/include/asm/atomic.h b/arch/ia64/include/asm/atomic.h
index 42919a8..0bf0350 100644
--- a/arch/ia64/include/asm/atomic.h
+++ b/arch/ia64/include/asm/atomic.h
@@ -21,8 +21,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#define atomic64_set(v,i) (((v)->counter) = (i))
diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h
index 3946b2c..31bb74a 100644
--- a/arch/m32r/include/asm/atomic.h
+++ b/arch/m32r/include/asm/atomic.h
@@ -28,7 +28,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/arch/m68k/include/asm/atomic.h b/arch/m68k/include/asm/atomic.h
index 663d4ba..e85f047 100644
--- a/arch/m68k/include/asm/atomic.h
+++ b/arch/m68k/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
/*
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index f3ee721..6dd6bfc 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -29,7 +29,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic_set - set atomic variable
@@ -306,7 +306,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u)
* @v: pointer of type atomic64_t
*
*/
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic64_set - set atomic variable
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h
index 219750b..226f8ca 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -67,7 +67,7 @@ static __inline__ void atomic_set(atomic_t *v, int i)
static __inline__ int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/* exported interface */
@@ -204,7 +204,7 @@ atomic64_set(atomic64_t *v, s64 i)
static __inline__ s64
atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
#define atomic64_inc(v) (atomic64_add( 1,(v)))
diff --git a/arch/sh/include/asm/atomic.h b/arch/sh/include/asm/atomic.h
index f57b8a6..05b9f74 100644
--- a/arch/sh/include/asm/atomic.h
+++ b/arch/sh/include/asm/atomic.h
@@ -14,7 +14,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#if defined(CONFIG_GUSA_RB)
diff --git a/arch/sparc/include/asm/atomic_32.h b/arch/sparc/include/asm/atomic_32.h
index 7b024f0..765c177 100644
--- a/arch/sparc/include/asm/atomic_32.h
+++ b/arch/sparc/include/asm/atomic_32.h
@@ -26,7 +26,7 @@ int atomic_cmpxchg(atomic_t *, int, int);
int __atomic_add_unless(atomic_t *, int, int);
void atomic_set(atomic_t *, int);
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_add(i, v) ((void)atomic_add_return( (int)(i), (v)))
#define atomic_sub(i, v) ((void)atomic_add_return(-(int)(i), (v)))
diff --git a/arch/sparc/include/asm/atomic_64.h b/arch/sparc/include/asm/atomic_64.h
index 7e4ca1e..4082749 100644
--- a/arch/sparc/include/asm/atomic_64.h
+++ b/arch/sparc/include/asm/atomic_64.h
@@ -14,8 +14,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define atomic64_set(v, i) (((v)->counter) = i)
diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index bf20c81..5e5cd12 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -24,7 +24,7 @@
*/
static inline int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/x86/include/asm/atomic64_64.h b/arch/x86/include/asm/atomic64_64.h
index 46e9052..f8d273e 100644
--- a/arch/x86/include/asm/atomic64_64.h
+++ b/arch/x86/include/asm/atomic64_64.h
@@ -18,7 +18,7 @@
*/
static inline long atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/xtensa/include/asm/atomic.h b/arch/xtensa/include/asm/atomic.h
index 6266766..00b7d46 100644
--- a/arch/xtensa/include/asm/atomic.h
+++ b/arch/xtensa/include/asm/atomic.h
@@ -47,7 +47,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h
index 56d4d36..1973ad2 100644
--- a/include/asm-generic/atomic.h
+++ b/include/asm-generic/atomic.h
@@ -126,7 +126,7 @@ ATOMIC_OP(or, |)
* Atomically reads the value of @v.
*/
#ifndef atomic_read
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#endif
/**
--
2.1.0
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
2014-09-23 14:29 ` Pranith Kumar
(?)
(?)
@ 2014-09-23 15:15 ` Peter Zijlstra
-1 siblings, 0 replies; 19+ messages in thread
From: Peter Zijlstra @ 2014-09-23 15:15 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller
On Tue, Sep 23, 2014 at 10:29:50AM -0400, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good to me; I can route it through the locking tree if there's no
objections.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 15:15 ` Peter Zijlstra
0 siblings, 0 replies; 19+ messages in thread
From: Peter Zijlstra @ 2014-09-23 15:15 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE..., Chris Zankel,
Max Filippov, Arnd Bergmann, Paul E. McKenney, Chen Gang,
Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki, Sam Ravnborg,
open list:ALPHA PORT, open list, moderated list:ARM PORT,
open list:CRIS PORT, open list:IA64 (Itanium) PL...,
moderated list:M32R ARCHITECTURE, open list:M32R ARCHITECTURE,
open list:M68K ARCHITECTURE, open list:MIPS,
open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
On Tue, Sep 23, 2014 at 10:29:50AM -0400, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good to me; I can route it through the locking tree if there's no
objections.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 15:15 ` Peter Zijlstra
0 siblings, 0 replies; 19+ messages in thread
From: Peter Zijlstra @ 2014-09-23 15:15 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller
On Tue, Sep 23, 2014 at 10:29:50AM -0400, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good to me; I can route it through the locking tree if there's no
objections.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 15:15 ` Peter Zijlstra
0 siblings, 0 replies; 19+ messages in thread
From: Peter Zijlstra @ 2014-09-23 15:15 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 23, 2014 at 10:29:50AM -0400, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Looks good to me; I can route it through the locking tree if there's no
objections.
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
2014-09-23 14:29 ` Pranith Kumar
(?)
@ 2014-09-23 15:40 ` Jesper Nilsson
-1 siblings, 0 replies; 19+ messages in thread
From: Jesper Nilsson @ 2014-09-23 15:40 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas
On Tue, Sep 23, 2014 at 04:29:50PM +0200, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
For the CRIS parts:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 15:40 ` Jesper Nilsson
0 siblings, 0 replies; 19+ messages in thread
From: Jesper Nilsson @ 2014-09-23 15:40 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE..., Chris Zankel,
Max Filippov, Arnd Bergmann, Peter Zijlstra, Paul E. McKenney,
Chen Gang, Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki,
Sam Ravnborg, open list:ALPHA PORT, open list,
moderated list:ARM PORT, linux-cris-kernel,
open list:IA64 (Itanium) PL..., moderated list:M32R ARCHITECTURE,
open list:M32R ARCHITECTURE, open list:M68K ARCHITECTURE,
open list:MIPS, open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
On Tue, Sep 23, 2014 at 04:29:50PM +0200, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
For the CRIS parts:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 15:40 ` Jesper Nilsson
0 siblings, 0 replies; 19+ messages in thread
From: Jesper Nilsson @ 2014-09-23 15:40 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 23, 2014 at 04:29:50PM +0200, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
For the CRIS parts:
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson at axis.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
2014-09-23 14:29 ` Pranith Kumar
(?)
(?)
@ 2014-09-23 19:43 ` Hans-Christian Egtvedt
-1 siblings, 0 replies; 19+ messages in thread
From: Hans-Christian Egtvedt @ 2014-09-23 19:43 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen, Mikael Starvik,
Jesper Nilsson, David Howells, Tony Luck, Fenghua Yu,
Hirokazu Takata, Geert Uytterhoeven, Ralf Baechle,
James E.J. Bottomley, Helge Deller, David S. Miller,
Thomas Gleixner, Ingo
Around Tue 23 Sep 2014 10:29:50 -0400 or thereabout, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
For the AVR32 related part.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
<snipp diff>
--
BR, HcE
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 19:43 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 19+ messages in thread
From: Hans-Christian Egtvedt @ 2014-09-23 19:43 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen, Mikael Starvik,
Jesper Nilsson, David Howells, Tony Luck, Fenghua Yu,
Hirokazu Takata, Geert Uytterhoeven, Ralf Baechle,
James E.J. Bottomley, Helge Deller, David S. Miller,
Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
maintainer:X86 ARCHITECTURE..., Chris Zankel, Max Filippov,
Arnd Bergmann, Peter Zijlstra, Paul E. McKenney, Chen Gang,
Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki, Sam Ravnborg,
open list:ALPHA PORT, open list, moderated list:ARM PORT,
open list:CRIS PORT, open list:IA64 (Itanium) PL...,
moderated list:M32R ARCHITECTURE, open list:M32R ARCHITECTURE,
open list:M68K ARCHITECTURE, open list:MIPS,
open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
Around Tue 23 Sep 2014 10:29:50 -0400 or thereabout, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
For the AVR32 related part.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
<snipp diff>
--
BR, HcE
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 19:43 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 19+ messages in thread
From: Hans-Christian Egtvedt @ 2014-09-23 19:43 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen, Mikael Starvik,
Jesper Nilsson, David Howells, Tony Luck, Fenghua Yu,
Hirokazu Takata, Geert Uytterhoeven, Ralf Baechle,
James E.J. Bottomley, Helge Deller, David S. Miller,
Thomas Gleixner, Ingo
Around Tue 23 Sep 2014 10:29:50 -0400 or thereabout, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
For the AVR32 related part.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
<snipp diff>
--
BR, HcE
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 19:43 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 19+ messages in thread
From: Hans-Christian Egtvedt @ 2014-09-23 19:43 UTC (permalink / raw)
To: linux-arm-kernel
Around Tue 23 Sep 2014 10:29:50 -0400 or thereabout, Pranith Kumar wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
For the AVR32 related part.
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
<snipp diff>
--
BR, HcE
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
2014-09-23 14:29 ` Pranith Kumar
(?)
(?)
@ 2014-09-23 23:56 ` Max Filippov
-1 siblings, 0 replies; 19+ messages in thread
From: Max Filippov @ 2014-09-23 23:56 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller
On Tue, Sep 23, 2014 at 6:29 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 23:56 ` Max Filippov
0 siblings, 0 replies; 19+ messages in thread
From: Max Filippov @ 2014-09-23 23:56 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, maintainer:X86 ARCHITECTURE..., Chris Zankel,
Arnd Bergmann, Peter Zijlstra, Paul E. McKenney, Chen Gang,
Victor Kamensky, Bjorn Helgaas, Maciej W. Rozycki, Sam Ravnborg,
open list:ALPHA PORT, open list, moderated list:ARM PORT,
open list:CRIS PORT, open list:IA64 (Itanium) PL...,
moderated list:M32R ARCHITECTURE, open list:M32R ARCHITECTURE,
open list:M68K ARCHITECTURE, open list:MIPS,
open list:PARISC ARCHITECTURE, open list:SUPERH,
open list:SPARC + UltraSPAR..., open list:TENSILICA XTENSA...,
open list:GENERIC INCLUDE/A...
On Tue, Sep 23, 2014 at 6:29 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 23:56 ` Max Filippov
0 siblings, 0 replies; 19+ messages in thread
From: Max Filippov @ 2014-09-23 23:56 UTC (permalink / raw)
To: Pranith Kumar
Cc: Richard Henderson, Ivan Kokshaysky, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Haavard Skinnemoen,
Hans-Christian Egtvedt, Mikael Starvik, Jesper Nilsson,
David Howells, Tony Luck, Fenghua Yu, Hirokazu Takata,
Geert Uytterhoeven, Ralf Baechle, James E.J. Bottomley,
Helge Deller, David S. Miller
On Tue, Sep 23, 2014 at 6:29 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile
@ 2014-09-23 23:56 ` Max Filippov
0 siblings, 0 replies; 19+ messages in thread
From: Max Filippov @ 2014-09-23 23:56 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Sep 23, 2014 at 6:29 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Use the much reader friendly ACCESS_ONCE() instead of the cast to volatile. This
> is purely a style change.
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
> arch/alpha/include/asm/atomic.h | 4 ++--
> arch/arm/include/asm/atomic.h | 2 +-
> arch/arm64/include/asm/atomic.h | 4 ++--
> arch/avr32/include/asm/atomic.h | 2 +-
> arch/cris/include/asm/atomic.h | 2 +-
> arch/frv/include/asm/atomic.h | 2 +-
> arch/ia64/include/asm/atomic.h | 4 ++--
> arch/m32r/include/asm/atomic.h | 2 +-
> arch/m68k/include/asm/atomic.h | 2 +-
> arch/mips/include/asm/atomic.h | 4 ++--
> arch/parisc/include/asm/atomic.h | 4 ++--
> arch/sh/include/asm/atomic.h | 2 +-
> arch/sparc/include/asm/atomic_32.h | 2 +-
> arch/sparc/include/asm/atomic_64.h | 4 ++--
> arch/x86/include/asm/atomic.h | 2 +-
> arch/x86/include/asm/atomic64_64.h | 2 +-
> arch/xtensa/include/asm/atomic.h | 2 +-
> include/asm-generic/atomic.h | 2 +-
> 18 files changed, 24 insertions(+), 24 deletions(-)
For xtensa:
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 19+ messages in thread
* [tip:locking/arch] locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read()
2014-09-23 14:29 ` Pranith Kumar
` (5 preceding siblings ...)
(?)
@ 2014-10-03 5:29 ` tip-bot for Pranith Kumar
-1 siblings, 0 replies; 19+ messages in thread
From: tip-bot for Pranith Kumar @ 2014-10-03 5:29 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jesper.nilsson, bobby.prani, torvalds,
peterz, jcmvbkbc, tglx, egtvedt
Commit-ID: 2291059c852706c6f5ffb400366042b7625066cd
Gitweb: http://git.kernel.org/tip/2291059c852706c6f5ffb400366042b7625066cd
Author: Pranith Kumar <bobby.prani@gmail.com>
AuthorDate: Tue, 23 Sep 2014 10:29:50 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 3 Oct 2014 06:06:23 +0200
locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read()
Use the much more reader friendly ACCESS_ONCE() instead of the cast to volatile.
This is purely a stylistic change.
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-arch@vger.kernel.org
Link: http://lkml.kernel.org/r/1411482607-20948-1-git-send-email-bobby.prani@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/alpha/include/asm/atomic.h | 4 ++--
arch/arm/include/asm/atomic.h | 2 +-
arch/arm64/include/asm/atomic.h | 4 ++--
arch/avr32/include/asm/atomic.h | 2 +-
arch/cris/include/asm/atomic.h | 2 +-
arch/frv/include/asm/atomic.h | 2 +-
arch/ia64/include/asm/atomic.h | 4 ++--
arch/m32r/include/asm/atomic.h | 2 +-
arch/m68k/include/asm/atomic.h | 2 +-
arch/mips/include/asm/atomic.h | 4 ++--
arch/parisc/include/asm/atomic.h | 4 ++--
arch/sh/include/asm/atomic.h | 2 +-
arch/sparc/include/asm/atomic_32.h | 2 +-
arch/sparc/include/asm/atomic_64.h | 4 ++--
arch/x86/include/asm/atomic.h | 2 +-
arch/x86/include/asm/atomic64_64.h | 2 +-
arch/xtensa/include/asm/atomic.h | 2 +-
include/asm-generic/atomic.h | 2 +-
18 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h
index 6fbb53a..8f8eafb 100644
--- a/arch/alpha/include/asm/atomic.h
+++ b/arch/alpha/include/asm/atomic.h
@@ -17,8 +17,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#define atomic64_set(v,i) ((v)->counter = (i))
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 832f1cd..e22c119 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -27,7 +27,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#if __LINUX_ARM_ARCH__ >= 6
diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h
index b83c325..7047051 100644
--- a/arch/arm64/include/asm/atomic.h
+++ b/arch/arm64/include/asm/atomic.h
@@ -35,7 +35,7 @@
* strex/ldrex monitor on some implementations. The reason we can use it for
* atomic_set() is the clrex or dummy strex done on every exception return.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/*
@@ -139,7 +139,7 @@ static inline int __atomic_add_unless(atomic_t *v, int a, int u)
*/
#define ATOMIC64_INIT(i) { (i) }
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic64_set(v,i) (((v)->counter) = (i))
#define ATOMIC64_OP(op, asm_op) \
diff --git a/arch/avr32/include/asm/atomic.h b/arch/avr32/include/asm/atomic.h
index 83e980a..2d07ce1 100644
--- a/arch/avr32/include/asm/atomic.h
+++ b/arch/avr32/include/asm/atomic.h
@@ -19,7 +19,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define ATOMIC_OP_RETURN(op, asm_op, asm_con) \
diff --git a/arch/cris/include/asm/atomic.h b/arch/cris/include/asm/atomic.h
index 0033f9d..279766a 100644
--- a/arch/cris/include/asm/atomic.h
+++ b/arch/cris/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
/* These should be written in asm but we do it in C for now. */
diff --git a/arch/frv/include/asm/atomic.h b/arch/frv/include/asm/atomic.h
index f6c3a16..102190a 100644
--- a/arch/frv/include/asm/atomic.h
+++ b/arch/frv/include/asm/atomic.h
@@ -31,7 +31,7 @@
*/
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = (i))
#ifndef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
diff --git a/arch/ia64/include/asm/atomic.h b/arch/ia64/include/asm/atomic.h
index 42919a8..0bf0350 100644
--- a/arch/ia64/include/asm/atomic.h
+++ b/arch/ia64/include/asm/atomic.h
@@ -21,8 +21,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) (((v)->counter) = (i))
#define atomic64_set(v,i) (((v)->counter) = (i))
diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h
index 3946b2c..31bb74a 100644
--- a/arch/m32r/include/asm/atomic.h
+++ b/arch/m32r/include/asm/atomic.h
@@ -28,7 +28,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/arch/m68k/include/asm/atomic.h b/arch/m68k/include/asm/atomic.h
index 663d4ba..e85f047 100644
--- a/arch/m68k/include/asm/atomic.h
+++ b/arch/m68k/include/asm/atomic.h
@@ -17,7 +17,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
/*
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index f3ee721..6dd6bfc 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -29,7 +29,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic_set - set atomic variable
@@ -306,7 +306,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u)
* @v: pointer of type atomic64_t
*
*/
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
/*
* atomic64_set - set atomic variable
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h
index 219750b..226f8ca 100644
--- a/arch/parisc/include/asm/atomic.h
+++ b/arch/parisc/include/asm/atomic.h
@@ -67,7 +67,7 @@ static __inline__ void atomic_set(atomic_t *v, int i)
static __inline__ int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/* exported interface */
@@ -204,7 +204,7 @@ atomic64_set(atomic64_t *v, s64 i)
static __inline__ s64
atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
#define atomic64_inc(v) (atomic64_add( 1,(v)))
diff --git a/arch/sh/include/asm/atomic.h b/arch/sh/include/asm/atomic.h
index f57b8a6..05b9f74 100644
--- a/arch/sh/include/asm/atomic.h
+++ b/arch/sh/include/asm/atomic.h
@@ -14,7 +14,7 @@
#define ATOMIC_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v,i) ((v)->counter = (i))
#if defined(CONFIG_GUSA_RB)
diff --git a/arch/sparc/include/asm/atomic_32.h b/arch/sparc/include/asm/atomic_32.h
index 7b024f0..765c177 100644
--- a/arch/sparc/include/asm/atomic_32.h
+++ b/arch/sparc/include/asm/atomic_32.h
@@ -26,7 +26,7 @@ int atomic_cmpxchg(atomic_t *, int, int);
int __atomic_add_unless(atomic_t *, int, int);
void atomic_set(atomic_t *, int);
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#define atomic_add(i, v) ((void)atomic_add_return( (int)(i), (v)))
#define atomic_sub(i, v) ((void)atomic_add_return(-(int)(i), (v)))
diff --git a/arch/sparc/include/asm/atomic_64.h b/arch/sparc/include/asm/atomic_64.h
index 7e4ca1e..4082749 100644
--- a/arch/sparc/include/asm/atomic_64.h
+++ b/arch/sparc/include/asm/atomic_64.h
@@ -14,8 +14,8 @@
#define ATOMIC_INIT(i) { (i) }
#define ATOMIC64_INIT(i) { (i) }
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
-#define atomic64_read(v) (*(volatile long *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
+#define atomic64_read(v) ACCESS_ONCE((v)->counter)
#define atomic_set(v, i) (((v)->counter) = i)
#define atomic64_set(v, i) (((v)->counter) = i)
diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index bf20c81..5e5cd12 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -24,7 +24,7 @@
*/
static inline int atomic_read(const atomic_t *v)
{
- return (*(volatile int *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/x86/include/asm/atomic64_64.h b/arch/x86/include/asm/atomic64_64.h
index 46e9052..f8d273e 100644
--- a/arch/x86/include/asm/atomic64_64.h
+++ b/arch/x86/include/asm/atomic64_64.h
@@ -18,7 +18,7 @@
*/
static inline long atomic64_read(const atomic64_t *v)
{
- return (*(volatile long *)&(v)->counter);
+ return ACCESS_ONCE((v)->counter);
}
/**
diff --git a/arch/xtensa/include/asm/atomic.h b/arch/xtensa/include/asm/atomic.h
index 6266766..00b7d46 100644
--- a/arch/xtensa/include/asm/atomic.h
+++ b/arch/xtensa/include/asm/atomic.h
@@ -47,7 +47,7 @@
*
* Atomically reads the value of @v.
*/
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
/**
* atomic_set - set atomic variable
diff --git a/include/asm-generic/atomic.h b/include/asm-generic/atomic.h
index 56d4d36..1973ad2 100644
--- a/include/asm-generic/atomic.h
+++ b/include/asm-generic/atomic.h
@@ -126,7 +126,7 @@ ATOMIC_OP(or, |)
* Atomically reads the value of @v.
*/
#ifndef atomic_read
-#define atomic_read(v) (*(volatile int *)&(v)->counter)
+#define atomic_read(v) ACCESS_ONCE((v)->counter)
#endif
/**
^ permalink raw reply related [flat|nested] 19+ messages in thread
end of thread, other threads:[~2014-10-03 5:30 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 14:29 [PATCH] atomic_read: Use ACCESS_ONCE() instead of cast to volatile Pranith Kumar
2014-09-23 14:29 ` Pranith Kumar
2014-09-23 14:29 ` Pranith Kumar
2014-09-23 15:15 ` Peter Zijlstra
2014-09-23 15:15 ` Peter Zijlstra
2014-09-23 15:15 ` Peter Zijlstra
2014-09-23 15:15 ` Peter Zijlstra
2014-09-23 15:40 ` Jesper Nilsson
2014-09-23 15:40 ` Jesper Nilsson
2014-09-23 15:40 ` Jesper Nilsson
2014-09-23 19:43 ` Hans-Christian Egtvedt
2014-09-23 19:43 ` Hans-Christian Egtvedt
2014-09-23 19:43 ` Hans-Christian Egtvedt
2014-09-23 19:43 ` Hans-Christian Egtvedt
2014-09-23 23:56 ` Max Filippov
2014-09-23 23:56 ` Max Filippov
2014-09-23 23:56 ` Max Filippov
2014-09-23 23:56 ` Max Filippov
2014-10-03 5:29 ` [tip:locking/arch] locking,arch: Use ACCESS_ONCE() instead of cast to volatile in atomic_read() tip-bot for Pranith Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.