* [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment
@ 2014-09-21 6:48 Khem Raj
2014-09-23 16:29 ` Martin Jansa
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2014-09-21 6:48 UTC (permalink / raw)
To: openembedded-devel
Fixes errors
sets PACKAGE_ARCH before inherit packagegroup
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta-oe/recipes-core/packagegroups/packagegroup-basic.bb | 5 +++--
meta-oe/recipes-core/packagegroups/packagegroup-boot.bb | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
index 08db943..9412df2 100644
--- a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
+++ b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
@@ -7,12 +7,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
PR = "r13"
-inherit packagegroup
-
+#
# packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
#
PACKAGE_ARCH = "${MACHINE_ARCH}"
+inherit packagegroup
+
# Poke extra recomendations into the list using your machine.conf
#
MACHINE_EXTRA_RRECOMMENDS ?= ""
diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
index 3b634f3..ae7e989 100644
--- a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
+++ b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
@@ -4,12 +4,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
PR = "r58"
-inherit packagegroup
-
+#
# packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
#
PACKAGE_ARCH = "${MACHINE_ARCH}"
+inherit packagegroup
+
#
# those ones can be set in machine config to supply packages needed to get machine booting
#
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment
2014-09-21 6:48 [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment Khem Raj
@ 2014-09-23 16:29 ` Martin Jansa
2014-09-23 17:55 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2014-09-23 16:29 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2373 bytes --]
On Sat, Sep 20, 2014 at 11:48:59PM -0700, Khem Raj wrote:
> Fixes errors
>
> sets PACKAGE_ARCH before inherit packagegroup
wasn't this already resolved in:
commit 5a25dde053e93e64b945776ab3fbf8b67c8c0773
Author: Martin Jansa <Martin.Jansa@gmail.com>
Date: Sun Aug 24 18:01:11 2014 +0200
packagegroup*: set PACKAGE_ARCH before packagegroup inherit
?
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta-oe/recipes-core/packagegroups/packagegroup-basic.bb | 5 +++--
> meta-oe/recipes-core/packagegroups/packagegroup-boot.bb | 5 +++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> index 08db943..9412df2 100644
> --- a/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> +++ b/meta-oe/recipes-core/packagegroups/packagegroup-basic.bb
> @@ -7,12 +7,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
>
> PR = "r13"
>
> -inherit packagegroup
> -
> +#
> # packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
> #
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +inherit packagegroup
> +
> # Poke extra recomendations into the list using your machine.conf
> #
> MACHINE_EXTRA_RRECOMMENDS ?= ""
> diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> index 3b634f3..ae7e989 100644
> --- a/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> +++ b/meta-oe/recipes-core/packagegroups/packagegroup-boot.bb
> @@ -4,12 +4,13 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d
>
> PR = "r58"
>
> -inherit packagegroup
> -
> +#
> # packages which content depend on MACHINE_FEATURES need to be MACHINE_ARCH
> #
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> +inherit packagegroup
> +
> #
> # those ones can be set in machine config to supply packages needed to get machine booting
> #
> --
> 2.1.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment
2014-09-23 16:29 ` Martin Jansa
@ 2014-09-23 17:55 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2014-09-23 17:55 UTC (permalink / raw)
To: openembeded-devel
On Tue, Sep 23, 2014 at 9:29 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sat, Sep 20, 2014 at 11:48:59PM -0700, Khem Raj wrote:
>> Fixes errors
>>
>> sets PACKAGE_ARCH before inherit packagegroup
>
> wasn't this already resolved in:
> commit 5a25dde053e93e64b945776ab3fbf8b67c8c0773
> Author: Martin Jansa <Martin.Jansa@gmail.com>
> Date: Sun Aug 24 18:01:11 2014 +0200
>
> packagegroup*: set PACKAGE_ARCH before packagegroup inherit
>
> ?
>
Yes. I was on a prior SHA, ignore it
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-23 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-21 6:48 [meta-oe][PATCH] packagegroups: Move inheriting packagegroup below PACKAGE_ARCH assignment Khem Raj
2014-09-23 16:29 ` Martin Jansa
2014-09-23 17:55 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.