* [PATCH] wireshark: not put the CC options into CFLAGS_FOR_BUILD
@ 2014-09-17 5:08 rongqing.li
2014-09-23 16:58 ` Martin Jansa
0 siblings, 1 reply; 2+ messages in thread
From: rongqing.li @ 2014-09-17 5:08 UTC (permalink / raw)
To: openembedded-devel
From: "Roy.Li" <rongqing.li@windriver.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
.../files/Do-not-set-CC_FOR_BUILD-flags.patch | 46 ++++++++++++++++++++
.../recipes-support/wireshark/wireshark_1.12.0.bb | 1 +
2 files changed, 47 insertions(+)
create mode 100644 meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
diff --git a/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch b/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
new file mode 100644
index 0000000..64a08ad
--- /dev/null
+++ b/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
@@ -0,0 +1,46 @@
+[PATCH] Do not set CC_FOR_BUILD flags
+
+Upstream-status: Pending
+
+AC_WIRESHARK_COMPILER_FLAGS_CHECK() is checking which options CC is supported,
+and put the supported options into CFLAGS, but it should not put them into
+CFLAGS_FOR_BUILD. since CC and BUILD_CC can be different, CFLAGS_FOR_BUILD is
+used by BUILD_CC
+
+BUILD_CC is used to generated host tools, do not use the gcc's optimised options,
+do not effect the running of host tools. so do not set CC_FOR_BUILD flags.
+
+Signed-off-by: Roy.Li <rongqing.li@windriver.com>
+---
+ acinclude.m4 | 8 --------
+ 1 file changed, 8 deletions(-)
+
+diff --git a/acinclude.m4 b/acinclude.m4
+index 136fc27..8d3d360 100644
+--- a/acinclude.m4
++++ b/acinclude.m4
+@@ -1755,10 +1755,6 @@ if test "x$ac_supports_gcc_flags" = "xyes" ; then
+ # just the new option.
+ #
+ CFLAGS="$CFLAGS_saved $GCC_OPTION"
+- #
+- # Add it to the flags we use when building build tools.
+- #
+- CFLAGS_FOR_BUILD="$CFLAGS_FOR_BUILD $GCC_OPTION"
+ ],
+ [
+ AC_MSG_RESULT(yes)
+@@ -1771,10 +1767,6 @@ if test "x$ac_supports_gcc_flags" = "xyes" ; then
+ # just the new option.
+ #
+ CFLAGS="$CFLAGS_saved $GCC_OPTION"
+- #
+- # Add it to the flags we use when building build tools.
+- #
+- CFLAGS_FOR_BUILD="$CFLAGS_FOR_BUILD $GCC_OPTION"
+ fi
+ ],
+ [
+--
+1.9.1
+
diff --git a/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb b/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
index 39a24dc..675519b 100644
--- a/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
+++ b/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
@@ -30,6 +30,7 @@ EXTRA_OECONF = "--with-qt=no --enable-usr-local=no --enable-tshark --with-c-ares
LIC_FILES_CHKSUM = "file://README.linux;md5=631e077455b7972172eb149195e065b0"
SRC_URI = " \
http://wiresharkdownloads.riverbed.com/wireshark/src/wireshark-1.12.0.tar.bz2 \
+ file://Do-not-set-CC_FOR_BUILD-flags.patch \
"
PE = "1"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wireshark: not put the CC options into CFLAGS_FOR_BUILD
2014-09-17 5:08 [PATCH] wireshark: not put the CC options into CFLAGS_FOR_BUILD rongqing.li
@ 2014-09-23 16:58 ` Martin Jansa
0 siblings, 0 replies; 2+ messages in thread
From: Martin Jansa @ 2014-09-23 16:58 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3583 bytes --]
On Wed, Sep 17, 2014 at 01:08:01PM +0800, rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
Is it still needed for 1.12.1 version? If yes, please rebase (on
wireshark upgrade patch and resend.
> Signed-off-by: Roy Li <rongqing.li@windriver.com>
> ---
> .../files/Do-not-set-CC_FOR_BUILD-flags.patch | 46 ++++++++++++++++++++
> .../recipes-support/wireshark/wireshark_1.12.0.bb | 1 +
> 2 files changed, 47 insertions(+)
> create mode 100644 meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
>
> diff --git a/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch b/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
> new file mode 100644
> index 0000000..64a08ad
> --- /dev/null
> +++ b/meta-networking/recipes-support/wireshark/files/Do-not-set-CC_FOR_BUILD-flags.patch
> @@ -0,0 +1,46 @@
> +[PATCH] Do not set CC_FOR_BUILD flags
> +
> +Upstream-status: Pending
> +
> +AC_WIRESHARK_COMPILER_FLAGS_CHECK() is checking which options CC is supported,
> +and put the supported options into CFLAGS, but it should not put them into
> +CFLAGS_FOR_BUILD. since CC and BUILD_CC can be different, CFLAGS_FOR_BUILD is
> +used by BUILD_CC
> +
> +BUILD_CC is used to generated host tools, do not use the gcc's optimised options,
> +do not effect the running of host tools. so do not set CC_FOR_BUILD flags.
> +
> +Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> +---
> + acinclude.m4 | 8 --------
> + 1 file changed, 8 deletions(-)
> +
> +diff --git a/acinclude.m4 b/acinclude.m4
> +index 136fc27..8d3d360 100644
> +--- a/acinclude.m4
> ++++ b/acinclude.m4
> +@@ -1755,10 +1755,6 @@ if test "x$ac_supports_gcc_flags" = "xyes" ; then
> + # just the new option.
> + #
> + CFLAGS="$CFLAGS_saved $GCC_OPTION"
> +- #
> +- # Add it to the flags we use when building build tools.
> +- #
> +- CFLAGS_FOR_BUILD="$CFLAGS_FOR_BUILD $GCC_OPTION"
> + ],
> + [
> + AC_MSG_RESULT(yes)
> +@@ -1771,10 +1767,6 @@ if test "x$ac_supports_gcc_flags" = "xyes" ; then
> + # just the new option.
> + #
> + CFLAGS="$CFLAGS_saved $GCC_OPTION"
> +- #
> +- # Add it to the flags we use when building build tools.
> +- #
> +- CFLAGS_FOR_BUILD="$CFLAGS_FOR_BUILD $GCC_OPTION"
> + fi
> + ],
> + [
> +--
> +1.9.1
> +
> diff --git a/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb b/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
> index 39a24dc..675519b 100644
> --- a/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
> +++ b/meta-networking/recipes-support/wireshark/wireshark_1.12.0.bb
> @@ -30,6 +30,7 @@ EXTRA_OECONF = "--with-qt=no --enable-usr-local=no --enable-tshark --with-c-ares
> LIC_FILES_CHKSUM = "file://README.linux;md5=631e077455b7972172eb149195e065b0"
> SRC_URI = " \
> http://wiresharkdownloads.riverbed.com/wireshark/src/wireshark-1.12.0.tar.bz2 \
> + file://Do-not-set-CC_FOR_BUILD-flags.patch \
> "
>
> PE = "1"
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-23 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-17 5:08 [PATCH] wireshark: not put the CC options into CFLAGS_FOR_BUILD rongqing.li
2014-09-23 16:58 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.