From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz,
Sasha Levin <sasha.levin@oracle.com>,
Anish Bhatt <anish@chelsio.com>,
David Miller <davem@davemloft.net>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: mmotm 2014-09-22-16-57 uploaded
Date: Tue, 23 Sep 2014 16:20:02 -0400 [thread overview]
Message-ID: <20140923202002.GA22362@nhori> (raw)
In-Reply-To: <20140923130128.79f5931ac03dbb31f53be805@linux-foundation.org>
On Tue, Sep 23, 2014 at 01:01:28PM -0700, Andrew Morton wrote:
> On Tue, 23 Sep 2014 12:02:22 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
...
> >
> > arch/powerpc/mm/hugetlbpage.c:710:1: error: conflicting types for 'follow_huge_pud'
> > follow_huge_pud(struct mm_struct *mm, unsigned long address,
> > ^
> > In file included from arch/powerpc/mm/hugetlbpage.c:14:0: include/linux/hugetlb.h:103:14:
> > note: previous declaration of 'follow_huge_pud' was here
> > struct page *follow_huge_pud(struct mm_struct *mm, unsigned long address,
> ^
>
> Naoya, please check:
>
> --- a/arch/powerpc/mm/hugetlbpage.c~mm-hugetlb-reduce-arch-dependent-code-around-follow_huge_-fix
> +++ a/arch/powerpc/mm/hugetlbpage.c
> @@ -708,7 +708,7 @@ follow_huge_pmd(struct mm_struct *mm, un
>
> struct page *
> follow_huge_pud(struct mm_struct *mm, unsigned long address,
> - pmd_t *pmd, int write)
> + pud_t *pud, int write)
> {
> BUG();
> return NULL;
> _
Yes, this is a right fix. Thanks.
Naoya
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz,
Sasha Levin <sasha.levin@oracle.com>,
Anish Bhatt <anish@chelsio.com>,
David Miller <davem@davemloft.net>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: mmotm 2014-09-22-16-57 uploaded
Date: Tue, 23 Sep 2014 16:20:02 -0400 [thread overview]
Message-ID: <20140923202002.GA22362@nhori> (raw)
In-Reply-To: <20140923130128.79f5931ac03dbb31f53be805@linux-foundation.org>
On Tue, Sep 23, 2014 at 01:01:28PM -0700, Andrew Morton wrote:
> On Tue, 23 Sep 2014 12:02:22 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
...
> >
> > arch/powerpc/mm/hugetlbpage.c:710:1: error: conflicting types for 'follow_huge_pud'
> > follow_huge_pud(struct mm_struct *mm, unsigned long address,
> > ^
> > In file included from arch/powerpc/mm/hugetlbpage.c:14:0: include/linux/hugetlb.h:103:14:
> > note: previous declaration of 'follow_huge_pud' was here
> > struct page *follow_huge_pud(struct mm_struct *mm, unsigned long address,
> ^
>
> Naoya, please check:
>
> --- a/arch/powerpc/mm/hugetlbpage.c~mm-hugetlb-reduce-arch-dependent-code-around-follow_huge_-fix
> +++ a/arch/powerpc/mm/hugetlbpage.c
> @@ -708,7 +708,7 @@ follow_huge_pmd(struct mm_struct *mm, un
>
> struct page *
> follow_huge_pud(struct mm_struct *mm, unsigned long address,
> - pmd_t *pmd, int write)
> + pud_t *pud, int write)
> {
> BUG();
> return NULL;
> _
Yes, this is a right fix. Thanks.
Naoya
next prev parent reply other threads:[~2014-09-23 20:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 0:02 mmotm 2014-09-22-16-57 uploaded akpm
2014-09-23 0:02 ` akpm
2014-09-23 0:39 ` Stephen Rothwell
2014-09-23 1:12 ` Andrew Morton
2014-09-23 1:12 ` Andrew Morton
2014-09-23 9:24 ` [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix.patch Michal Hocko
2014-09-23 9:24 ` Michal Hocko
2014-09-23 9:24 ` Michal Hocko
2014-09-23 11:28 ` [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch Michal Hocko
2014-09-23 11:28 ` Michal Hocko
2014-09-23 11:28 ` Michal Hocko
2014-09-23 16:19 ` Valdis.Kletnieks
2014-09-23 20:52 ` Andrew Morton
2014-09-23 20:52 ` Andrew Morton
2014-09-24 7:09 ` Michal Hocko
2014-09-24 7:09 ` Michal Hocko
2014-09-23 20:12 ` Dave Jones
2014-09-23 20:12 ` Dave Jones
2014-10-13 18:51 ` Dave Jones
2014-10-13 18:51 ` Dave Jones
2014-10-13 19:07 ` Joe Perches
2014-10-13 19:07 ` Joe Perches
2014-10-14 11:55 ` Michal Hocko
2014-10-14 11:55 ` Michal Hocko
2014-10-14 16:50 ` Dave Jones
2014-10-14 16:50 ` Dave Jones
2014-10-15 9:03 ` Michal Hocko
2014-10-15 9:03 ` Michal Hocko
2014-09-23 19:02 ` mmotm 2014-09-22-16-57 uploaded Guenter Roeck
2014-09-23 19:02 ` Guenter Roeck
2014-09-23 20:01 ` Andrew Morton
2014-09-23 20:01 ` Andrew Morton
2014-09-23 20:13 ` Fabio Estevam
2014-09-23 20:13 ` Fabio Estevam
2014-09-23 20:20 ` Naoya Horiguchi [this message]
2014-09-23 20:20 ` Naoya Horiguchi
2014-09-23 20:38 ` Guenter Roeck
2014-09-23 20:38 ` Guenter Roeck
2014-09-23 21:08 ` Anish Bhatt
2014-09-23 21:08 ` Anish Bhatt
2014-09-23 20:31 ` Randy Dunlap
2014-09-23 20:31 ` Randy Dunlap
2014-09-23 20:57 ` Guenter Roeck
2014-09-23 20:57 ` Guenter Roeck
2014-09-23 21:36 ` Randy Dunlap
2014-09-23 21:36 ` Randy Dunlap
2014-09-23 21:53 ` Guenter Roeck
2014-09-23 21:53 ` Guenter Roeck
2014-09-24 4:34 ` Guenter Roeck
2014-09-24 4:34 ` Guenter Roeck
2014-09-24 6:24 ` David Miller
2014-09-24 6:24 ` David Miller
2014-09-24 7:18 ` Geert Uytterhoeven
2014-09-24 7:18 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2014-09-23 0:02 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923202002.GA22362@nhori \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mhocko@suse.cz \
--cc=sasha.levin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.