Re: [PATCH wpan-next] ieee802154: mrf24j40: support for external rx/tx

[Alexander Aring <alex.aring@gmail.com>]

On Tue, Sep 23, 2014 at 11:11:01PM -0700, Walter Mack wrote:
> 
> On 09/22/2014 08:51 PM, Alan Ott wrote:
> >On 09/16/2014 04:20 PM, Alexander Aring wrote:
> >>Hi Walter,
> >>
> >>On Tue, Sep 16, 2014 at 01:13:12PM -0700, Walter Mack wrote:
> >>>Alex,
> >>>
> >>>this is not a question of chip revisions. Chips with the same revision
> >>>can
> >>>be used in designs with or without the external transmitter/receiver.
> >>>Its
> >>>just that the chip has to be set up to be compatible with the design.
> >>>
> >>ah, ok. Dunno, I will wait on alan's opinion. If I don't heard anything
> >>in one
> >>week I will apply it.
> >
> >Did Simon's patch get applied? I couldn't see it in any of the obvious
> >places when I looked the other day.
> >
> >>
> >>Maybe alan wants also add a device tree support for this driver and then
> >>we could
> >>make a dt property/platform data for that. But for now, I am also fine
> >>with module
> >>parameter solution... because we don't have a dt support right now.
> >>
> >
> >I don't like this as a module parameter. That's not what module params are
> >really designed for. It's better as DT so that it can be turned on and off
> >for the individual devices, not system-wide.
> This is a valid point.

ack.

> >mrf24j40 loads up fine under DT. There just isn't anything to configure
> >(so far) other than the SPI.
> >
> >Are there any other known boards which use the external amplifier besides
> >the MB and MC (and MD and ME, which are the same as the MB and MC)?
> Mine does. It is a custom design that hooks up to the extension port of the
> Raspberry PI. It doesn't have a product name..
> >
> >Alex, I'm not sure how this fits with Simon's patch, as I haven't
> >investigated it fully. I'd expect both implementations to be the same, but
> >they're not.
> Is Simon's patch available for me to have a look at?
> 

I upload it now to pastie.org... [0].

I want to try to add this patch in a seperate branch but this patch doesn't
apply on linux-wpan. There must be changes in the middle of them which
are not mainline. Diff reports about line 813, but the end of the file
is line 802.

Simon can you confirm this? I never tried to apply it since there was
other review notes.

The same what your patch does and Simon's is the setting of
REG_TESTMODE.

- Alex

[0] http://pastie.org/9589875