From: Mark Einon <mark.einon@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
angus@agibson.me, tklauser@distanz.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v2] et131x: Promote staging et131x driver to drivers/net
Date: Wed, 24 Sep 2014 10:00:05 +0100 [thread overview]
Message-ID: <20140924090004.GA5097@leicester.auvation.com> (raw)
In-Reply-To: <1411506437.29268.13.camel@joe-AO725>
On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote:
> On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
>
> checkpatch type modification you might consider:
>
> Reduce logging line count by consolidating repeated dev_warn
> Use ether_addr_copy
> Line wrapping for 80 columns
> Remove unnecessary parentheses
> Remove unnecessary OOM message
Considered and done, thanks.
Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Einon <mark.einon@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, angus@agibson.me,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2] et131x: Promote staging et131x driver to drivers/net
Date: Wed, 24 Sep 2014 10:00:05 +0100 [thread overview]
Message-ID: <20140924090004.GA5097@leicester.auvation.com> (raw)
In-Reply-To: <1411506437.29268.13.camel@joe-AO725>
On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote:
> On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
>
> checkpatch type modification you might consider:
>
> Reduce logging line count by consolidating repeated dev_warn
> Use ether_addr_copy
> Line wrapping for 80 columns
> Remove unnecessary parentheses
> Remove unnecessary OOM message
Considered and done, thanks.
Mark
next prev parent reply other threads:[~2014-09-24 9:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 21:28 [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2014-09-22 23:56 ` Angus Gibson
2014-09-23 9:51 ` Mark Einon
2014-09-23 9:51 ` Mark Einon
2014-09-23 1:57 ` Joe Perches
2014-09-23 9:50 ` Mark Einon
2014-09-23 9:50 ` Mark Einon
2014-09-23 7:22 ` Tobias Klauser
2014-09-23 7:22 ` Tobias Klauser
2014-09-23 9:46 ` Mark Einon
2014-09-23 9:46 ` Mark Einon
2014-09-23 10:01 ` Tobias Klauser
2014-09-23 10:01 ` Tobias Klauser
2014-09-23 11:06 ` Mark Einon
2014-09-23 11:06 ` Mark Einon
2014-09-23 19:41 ` [PATCH 1/4] staging: et131x: zero allocation of fbr to prevent random address access Mark Einon
2014-09-23 19:41 ` Mark Einon
2014-09-23 19:41 ` [PATCH 2/4] staging: et131x: don't cast a void* to a struct pointer Mark Einon
2014-09-23 19:41 ` Mark Einon
2014-09-23 19:41 ` [PATCH 3/4] staging: et131x: Add space after { in pci ID table Mark Einon
2014-09-23 19:41 ` Mark Einon
2014-09-23 19:41 ` [PATCH 4/4] staging: et131x: Remove unnecessary defines to enable driver PM Mark Einon
2014-09-23 19:41 ` Mark Einon
2014-09-23 19:02 ` [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Francois Romieu
2014-09-23 19:17 ` Joe Perches
2014-09-23 20:07 ` Francois Romieu
2014-09-23 20:07 ` Francois Romieu
2014-09-23 20:05 ` [PATCH v2] " Mark Einon
2014-09-23 20:05 ` Mark Einon
2014-09-23 21:07 ` Joe Perches
2014-09-23 21:07 ` Joe Perches
2014-09-24 8:54 ` [PATCH 1/4] staging: et131x: Use ether_addr_copy when copying ethernet addresses Mark Einon
2014-09-24 8:54 ` Mark Einon
2014-09-24 8:54 ` [PATCH 2/4] staging: et131x: Cat some lines less than 80 columns Mark Einon
2014-09-24 8:54 ` Mark Einon
2014-09-24 8:54 ` [PATCH 3/4] staging: et131x: Remove unnecessary OOM message Mark Einon
2014-09-24 8:54 ` Mark Einon
2014-09-24 8:54 ` [PATCH 4/4] staging: et131x: Remove unnecessary parentheses Mark Einon
2014-09-24 8:54 ` Mark Einon
2014-09-24 9:00 ` Mark Einon [this message]
2014-09-24 9:00 ` [PATCH v2] et131x: Promote staging et131x driver to drivers/net Mark Einon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924090004.GA5097@leicester.auvation.com \
--to=mark.einon@gmail.com \
--cc=angus@agibson.me \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.