From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: "Ivan T. Ivanov" <iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Philippe Reynes <tremyfr-Qt13gs6zZMY@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Wed, 24 Sep 2014 18:10:46 +0100 [thread overview]
Message-ID: <20140924171046.GM5729@leverpostej> (raw)
In-Reply-To: <20140924170522.GL5729@leverpostej>
> > > > +
> > > > +- qcom,rsense:
> > > > + Usage: optional
> > > > + Value type: <u32>
> > > > + Definition: External sense register value in Ohm. Defining this
> > > > + propery will instruct ADC to use external ADC sense channel.
> > > > + If property is not defined ADC will use internal sense channel.
> > >
> > > The latter two sentences sound like a driver description.
> > >
> > > What exactly is the difference between the internal and external
> > > channels, and what exactly is the value in the sense register used for?
> >
> > Internal - when using chip build-in resistor
> > External - when using off-chip resistor
>
> Would it be possible to use the internal channel when you have an
> external resistor?
>
> If so, does the device have a channel per resistor, or can either
> resistor be selected and applied to the single channel the device has?
>
> This might be better worded as "external-registor-ohms".
I meant to say "external-resistor-ohms".
Muscle memory and lack of coffee got the better of me.
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Cameron <jic23@kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Lee Jones <lee.jones@linaro.org>,
Philippe Reynes <tremyfr@yahoo.fr>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Wed, 24 Sep 2014 18:10:46 +0100 [thread overview]
Message-ID: <20140924171046.GM5729@leverpostej> (raw)
In-Reply-To: <20140924170522.GL5729@leverpostej>
> > > > +
> > > > +- qcom,rsense:
> > > > + Usage: optional
> > > > + Value type: <u32>
> > > > + Definition: External sense register value in Ohm. Defining this
> > > > + propery will instruct ADC to use external ADC sense channel.
> > > > + If property is not defined ADC will use internal sense channel.
> > >
> > > The latter two sentences sound like a driver description.
> > >
> > > What exactly is the difference between the internal and external
> > > channels, and what exactly is the value in the sense register used for?
> >
> > Internal - when using chip build-in resistor
> > External - when using off-chip resistor
>
> Would it be possible to use the internal channel when you have an
> external resistor?
>
> If so, does the device have a channel per resistor, or can either
> resistor be selected and applied to the single channel the device has?
>
> This might be better worded as "external-registor-ohms".
I meant to say "external-resistor-ohms".
Muscle memory and lack of coffee got the better of me.
Mark.
next prev parent reply other threads:[~2014-09-24 17:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 13:58 [PATCH v2] iio: iadc: Qualcomm SPMI PMIC current ADC driver Ivan T. Ivanov
2014-09-24 14:55 ` Mark Rutland
2014-09-24 16:00 ` Ivan T. Ivanov
2014-09-24 16:00 ` Ivan T. Ivanov
2014-09-24 17:05 ` Mark Rutland
2014-09-24 17:05 ` Mark Rutland
2014-09-24 17:10 ` Mark Rutland [this message]
2014-09-24 17:10 ` Mark Rutland
2014-09-25 9:47 ` Ivan T. Ivanov
2014-09-25 16:02 ` Mark Rutland
2014-09-25 19:21 ` Ivan T. Ivanov
2014-09-25 19:21 ` Ivan T. Ivanov
[not found] ` <1411672895.28648.3.camel-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2014-09-27 9:50 ` Jonathan Cameron
2014-09-27 9:50 ` Jonathan Cameron
[not found] ` <5426886D.4050602-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-09-29 8:38 ` Ivan T. Ivanov
2014-09-29 8:38 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924171046.GM5729@leverpostej \
--to=mark.rutland-5wv7dgnigg8@public.gmane.org \
--cc=Pawel.Moll-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tremyfr-Qt13gs6zZMY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.