From: Marek Vasut <marex@denx.de>
To: Yuan Yao <yao.yuan@freescale.com>
Cc: wsa@the-dreams.de, LW@karo-electronics.de, mark.rutland@arm.com,
fugang.duan@freescale.com, shawn.guo@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v8 0/2] i2c: imx: add DMA support for freescale i2c driver
Date: Thu, 25 Sep 2014 12:23:54 +0200 [thread overview]
Message-ID: <201409251223.54218.marex@denx.de> (raw)
In-Reply-To: <1411632689-31531-1-git-send-email-yao.yuan@freescale.com>
On Thursday, September 25, 2014 at 10:11:27 AM, Yuan Yao wrote:
> Changed in v8:
> - some minor fixes for coding style.
> - unsetting I2CR_DMAEN immediatelly when failed in DMA mode.
Brief skim over the patch doesn't show any dangling problems.
Reviewed-by: Marek Vasut <marex@denx.de>
btw. the U-Boot output is completely irrelevant, it only points out you use
outdated version, so please keep only the relevant output. Also, I would
recommend you to trim the responses to patches with [...] so one doesn't have to
scroll through a wall of old text, but can easily find the relevant portions.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/2] i2c: imx: add DMA support for freescale i2c driver
Date: Thu, 25 Sep 2014 12:23:54 +0200 [thread overview]
Message-ID: <201409251223.54218.marex@denx.de> (raw)
In-Reply-To: <1411632689-31531-1-git-send-email-yao.yuan@freescale.com>
On Thursday, September 25, 2014 at 10:11:27 AM, Yuan Yao wrote:
> Changed in v8:
> - some minor fixes for coding style.
> - unsetting I2CR_DMAEN immediatelly when failed in DMA mode.
Brief skim over the patch doesn't show any dangling problems.
Reviewed-by: Marek Vasut <marex@denx.de>
btw. the U-Boot output is completely irrelevant, it only points out you use
outdated version, so please keep only the relevant output. Also, I would
recommend you to trim the responses to patches with [...] so one doesn't have to
scroll through a wall of old text, but can easily find the relevant portions.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-09-25 10:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:11 [PATCH v8 0/2] i2c: imx: add DMA support for freescale i2c driver Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 8:11 ` [PATCH v8 1/2] " Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 9:24 ` fugang.duan
2014-09-25 9:24 ` fugang.duan
2014-09-25 9:24 ` fugang.duan at freescale.com
[not found] ` <6a2c63ad3a60461a830a00281c9d0b3c-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-09-25 9:58 ` Yao Yuan
2014-09-25 9:58 ` Yao Yuan
2014-09-25 9:58 ` Yao Yuan
[not found] ` <1411632689-31531-2-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-10-03 7:54 ` Wolfram Sang
2014-10-03 7:54 ` Wolfram Sang
2014-10-03 7:54 ` Wolfram Sang
2014-10-08 6:30 ` Yao Yuan
2014-10-08 6:30 ` Yao Yuan
2014-10-08 6:30 ` Yao Yuan
[not found] ` <3cd0b028391140b9a75cddf58dbe40b8-ufbTtyGzTTQImQYq+4zkFeO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-10-08 6:46 ` Wolfram Sang
2014-10-08 6:46 ` Wolfram Sang
2014-10-08 6:46 ` Wolfram Sang
2014-09-25 8:11 ` [PATCH v8 2/2] Documentation:add " Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 8:11 ` Yuan Yao
2014-09-25 10:23 ` Marek Vasut [this message]
2014-09-25 10:23 ` [PATCH v8 0/2] i2c: imx: add " Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409251223.54218.marex@denx.de \
--to=marex@denx.de \
--cc=LW@karo-electronics.de \
--cc=fugang.duan@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawn.guo@linaro.org \
--cc=wsa@the-dreams.de \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.