[PATCH] monitordisk: don't log when not monitoring a filesystem for inodes

[PATCH] monitordisk: don't log when not monitoring a filesystem for inodes

[Ross Burton]

Writing a log that the filesystem isn't being monitored for inode usage just
confuses users who are not aware about the nature of inodes in their filesystem,
so don't say anything, just silently disable the monitor.  In general this only
happens on filesystems which don't have a limit on inodes.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 bitbake/lib/bb/monitordisk.py |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/bitbake/lib/bb/monitordisk.py b/bitbake/lib/bb/monitordisk.py
index 6b03682..466523c 100644
--- a/bitbake/lib/bb/monitordisk.py
+++ b/bitbake/lib/bb/monitordisk.py
@@ -239,11 +239,9 @@ class diskMonitor:
                 freeInode = st.f_favail
 
                 if minInode and freeInode < minInode:
-                    # Some fs formats' (e.g., btrfs) statvfs.f_files (inodes) is
-                    # zero, this is a feature of the fs, we disable the inode
-                    # checking for such a fs.
+                    # Some filesystems use dynamic inodes so can't run out
+                    # (e.g. btrfs). This is reported by the inode count being 0.
                     if st.f_files == 0:
-                        logger.info("Inode check for %s is unavaliable, will remove it from disk monitor" % path)
                         self.devDict[k][2] = None
                         continue
                     # Always show warning, the self.checked would always be False if the action is WARN
-- 
1.7.10.4

Re: [PATCH] monitordisk: don't log when not monitoring a filesystem for inodes

[Olof Johansson]

On 14-09-25 16:31 +0200, Ross Burton wrote:
> Writing a log that the filesystem isn't being monitored for inode usage just
> confuses users who are not aware about the nature of inodes in their filesystem,
> so don't say anything, just silently disable the monitor.  In general this only
> happens on filesystems which don't have a limit on inodes.

+1

It used to be a warning, but somebody on irc wanted it to remain
a notice when I sent the patch to lower it. But indeed, it's just
noise.

-- 
olofjn