From: Bob Picco <bpicco@meloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH V3] sparc64: sparse irq
Date: Thu, 25 Sep 2014 16:20:05 +0000 [thread overview]
Message-ID: <20140925162005.GB4211@zareason> (raw)
In-Reply-To: <1410982288-10549-1-git-send-email-bpicco@meloft.net>
Hi,
David Miller wrote: [Thu Sep 25 2014, 11:53:21AM EDT]
> From: Bob Picco <bpicco@meloft.net>
> Date: Wed, 17 Sep 2014 15:31:28 -0400
>
> > I've tested with SPARSE_IRQ on T5-8, M7-4 and T4-X and Jalap?no.
>
> I'm currently reviewing this, and I have to ask if any of your Niagara
> test scenerios had a hypervisor with HV_GRP_INTR major < 3?
>
> I have a sense that the legacy hypervisor case wasn't covered, and
> it seems that this patch will emit an ugly log message when that
> situation is triggered which probably isn't appropriate as the
> event isn't an error. It's just an older hypervisor that lacks
> cookie only VIRQ support.
Yes this issue actually came up indirectly yesterday. Some T4-X will have
legacy sysino and some cookie. Though I've never seen a T4-X with cookie.
For example an older T4 with older HV firmware has this:
[root@ca-qasparc14 bugdb-19677751.d]# dmesg | grep hv_error
[ 0.000000] irq_group_hv.129 hv_error = -22 major = 3
on an older kernel. I totally forgot about this issue.
You might have additional feedback. So please let me know whether you'd like
another version of the patch.
next prev parent reply other threads:[~2014-09-25 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 19:31 [PATCH V3] sparc64: sparse irq Bob Picco
2014-09-25 15:53 ` David Miller
2014-09-25 16:20 ` Bob Picco [this message]
2014-09-25 16:35 ` David Miller
2014-09-25 16:42 ` David Miller
2014-09-25 17:14 ` Bob Picco
2014-09-25 17:15 ` Bob Picco
2014-09-25 17:34 ` David Miller
2014-09-25 18:54 ` Bob Picco
2014-09-25 18:56 ` David Miller
2014-09-25 19:28 ` David Miller
2014-09-25 19:52 ` Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925162005.GB4211@zareason \
--to=bpicco@meloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.