All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Picco <bpicco@meloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH V3] sparc64: sparse irq
Date: Thu, 25 Sep 2014 19:52:38 +0000	[thread overview]
Message-ID: <20140925195238.GG4211@zareason> (raw)
In-Reply-To: <1410982288-10549-1-git-send-email-bpicco@meloft.net>

David Miller wrote:	[Thu Sep 25 2014, 03:28:29PM EDT]
> 
> Ok Bob, I think I've resolved everything, and I made some minor
> adjustments to your patch.  The final version is below and works
> well for me.
> 
> The changes I made were roughly:
> 
> 1) Add a helper test function sun4v_cookie_only_virqs()
> 
> 2) Put a big comment above that function explaining the version
>    behaviors.  Adjust the commit log message to match.
> 
> 3) Don't bark in the kernel log if the negoatiation fails.  But do
>    print an informative message about what style of IRQs we are going
>    to use.
> 
> 4) Minor indentation fixes here and there.
> 
> Let me know if this works for you:
Looks good to me. I also learned what caused me much pain.

thanx!

      parent reply	other threads:[~2014-09-25 19:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 19:31 [PATCH V3] sparc64: sparse irq Bob Picco
2014-09-25 15:53 ` David Miller
2014-09-25 16:20 ` Bob Picco
2014-09-25 16:35 ` David Miller
2014-09-25 16:42 ` David Miller
2014-09-25 17:14 ` Bob Picco
2014-09-25 17:15 ` Bob Picco
2014-09-25 17:34 ` David Miller
2014-09-25 18:54 ` Bob Picco
2014-09-25 18:56 ` David Miller
2014-09-25 19:28 ` David Miller
2014-09-25 19:52 ` Bob Picco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140925195238.GG4211@zareason \
    --to=bpicco@meloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.