From: josh@joshtriplett.org
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Support compiling out madvise and fadvise
Date: Thu, 25 Sep 2014 11:27:02 -0700 [thread overview]
Message-ID: <20140925182702.GB9360@cloud> (raw)
In-Reply-To: <20140925172113.GA8209@cmpxchg.org>
On Thu, Sep 25, 2014 at 01:21:13PM -0400, Johannes Weiner wrote:
> On Mon, Sep 22, 2014 at 09:11:16AM -0700, Josh Triplett wrote:
> > @@ -3,7 +3,7 @@
> > #
> >
> > mmu-y := nommu.o
> > -mmu-$(CONFIG_MMU) := fremap.o gup.o highmem.o madvise.o memory.o mincore.o \
> > +mmu-$(CONFIG_MMU) := fremap.o gup.o highmem.o memory.o mincore.o \
> > mlock.o mmap.o mprotect.o mremap.o msync.o rmap.o \
> > vmalloc.o pagewalk.o pgtable-generic.o
> >
> > @@ -11,7 +11,7 @@ ifdef CONFIG_CROSS_MEMORY_ATTACH
> > mmu-$(CONFIG_MMU) += process_vm_access.o
> > endif
> >
> > -obj-y := filemap.o mempool.o oom_kill.o fadvise.o \
> > +obj-y := filemap.o mempool.o oom_kill.o \
> > maccess.o page_alloc.o page-writeback.o \
> > readahead.o swap.o truncate.o vmscan.o shmem.o \
> > util.o mmzone.o vmstat.o backing-dev.o \
> > @@ -28,6 +28,9 @@ else
> > obj-y += bootmem.o
> > endif
> >
> > +ifdef CONFIG_MMU
> > + obj-$(CONFIG_ADVISE_SYSCALLS) += fadvise.o madvise.o
> > +endif
>
> That makes fadvise MMU-only, but I don't see why it should be.
>
> Was that intentional?
No. Fixed in v2; will send out momentarily. Thanks!
- Josh Triplett
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: josh@joshtriplett.org
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Support compiling out madvise and fadvise
Date: Thu, 25 Sep 2014 11:27:02 -0700 [thread overview]
Message-ID: <20140925182702.GB9360@cloud> (raw)
In-Reply-To: <20140925172113.GA8209@cmpxchg.org>
On Thu, Sep 25, 2014 at 01:21:13PM -0400, Johannes Weiner wrote:
> On Mon, Sep 22, 2014 at 09:11:16AM -0700, Josh Triplett wrote:
> > @@ -3,7 +3,7 @@
> > #
> >
> > mmu-y := nommu.o
> > -mmu-$(CONFIG_MMU) := fremap.o gup.o highmem.o madvise.o memory.o mincore.o \
> > +mmu-$(CONFIG_MMU) := fremap.o gup.o highmem.o memory.o mincore.o \
> > mlock.o mmap.o mprotect.o mremap.o msync.o rmap.o \
> > vmalloc.o pagewalk.o pgtable-generic.o
> >
> > @@ -11,7 +11,7 @@ ifdef CONFIG_CROSS_MEMORY_ATTACH
> > mmu-$(CONFIG_MMU) += process_vm_access.o
> > endif
> >
> > -obj-y := filemap.o mempool.o oom_kill.o fadvise.o \
> > +obj-y := filemap.o mempool.o oom_kill.o \
> > maccess.o page_alloc.o page-writeback.o \
> > readahead.o swap.o truncate.o vmscan.o shmem.o \
> > util.o mmzone.o vmstat.o backing-dev.o \
> > @@ -28,6 +28,9 @@ else
> > obj-y += bootmem.o
> > endif
> >
> > +ifdef CONFIG_MMU
> > + obj-$(CONFIG_ADVISE_SYSCALLS) += fadvise.o madvise.o
> > +endif
>
> That makes fadvise MMU-only, but I don't see why it should be.
>
> Was that intentional?
No. Fixed in v2; will send out momentarily. Thanks!
- Josh Triplett
next prev parent reply other threads:[~2014-09-25 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 16:11 [PATCH] mm: Support compiling out madvise and fadvise Josh Triplett
2014-09-22 16:11 ` Josh Triplett
2014-09-22 16:11 ` Josh Triplett
2014-09-22 16:47 ` Davidlohr Bueso
2014-09-22 16:47 ` Davidlohr Bueso
2014-09-22 17:03 ` Josh Triplett
2014-09-22 17:03 ` Josh Triplett
2014-09-25 17:21 ` Johannes Weiner
2014-09-25 17:21 ` Johannes Weiner
2014-09-25 18:27 ` josh [this message]
2014-09-25 18:27 ` josh
2014-09-25 18:32 ` [PATCHv2] " josh-iaAMLnmF4UmaiuxdJuQwMA
2014-09-25 18:32 ` josh
2014-09-25 18:32 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925182702.GB9360@cloud \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.