From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: dts: vf610: Add ARM Global Timer
Date: Fri, 26 Sep 2014 09:41:27 +0800 [thread overview]
Message-ID: <20140926014126.GE21077@dragon> (raw)
In-Reply-To: <1411575610-20895-3-git-send-email-stefan@agner.ch>
On Wed, Sep 24, 2014 at 06:20:09PM +0200, Stefan Agner wrote:
> Add Global Timer support which is part of the private peripherals
> of the Cortex-A5 processor. This Global Timer is compatible with the
> Cortex-A9 implementation. It's a 64-bit timer and is clocked by the
> peripheral clock, which is typically 133 or 166MHz on Vybrid.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf610.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index 4d2ec32..3232b9a 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -11,6 +11,7 @@
> #include "vf610-pinfunc.h"
> #include <dt-bindings/clock/vf610-clock.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>
> / {
> aliases {
> @@ -83,6 +84,13 @@
> <0x40002100 0x100>;
> };
>
> + timer: global-timer at 40002200 {
The renaming to "timer" should be applied on node name, not the label
name. I change it as below and applied the patch.
global_timer: timer at 40002200
Shawn
> + compatible = "arm,cortex-a9-global-timer";
> + reg = <0x40002200 0x20>;
> + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_PLATFORM_BUS>;
> + };
> +
> L2: l2-cache at 40006000 {
> compatible = "arm,pl310-cache";
> reg = <0x40006000 0x1000>;
> --
> 2.1.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Stefan Agner <stefan@agner.ch>
Cc: <kernel@pengutronix.de>, <daniel.lezcano@linaro.org>,
<tglx@linutronix.de>, <festevam@gmail.com>,
<jingchang.lu@freescale.com>, <bpringlemeir@nbsps.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: dts: vf610: Add ARM Global Timer
Date: Fri, 26 Sep 2014 09:41:27 +0800 [thread overview]
Message-ID: <20140926014126.GE21077@dragon> (raw)
In-Reply-To: <1411575610-20895-3-git-send-email-stefan@agner.ch>
On Wed, Sep 24, 2014 at 06:20:09PM +0200, Stefan Agner wrote:
> Add Global Timer support which is part of the private peripherals
> of the Cortex-A5 processor. This Global Timer is compatible with the
> Cortex-A9 implementation. It's a 64-bit timer and is clocked by the
> peripheral clock, which is typically 133 or 166MHz on Vybrid.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf610.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index 4d2ec32..3232b9a 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -11,6 +11,7 @@
> #include "vf610-pinfunc.h"
> #include <dt-bindings/clock/vf610-clock.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>
> / {
> aliases {
> @@ -83,6 +84,13 @@
> <0x40002100 0x100>;
> };
>
> + timer: global-timer@40002200 {
The renaming to "timer" should be applied on node name, not the label
name. I change it as below and applied the patch.
global_timer: timer@40002200
Shawn
> + compatible = "arm,cortex-a9-global-timer";
> + reg = <0x40002200 0x20>;
> + interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_PLATFORM_BUS>;
> + };
> +
> L2: l2-cache@40006000 {
> compatible = "arm,pl310-cache";
> reg = <0x40006000 0x1000>;
> --
> 2.1.0
>
next prev parent reply other threads:[~2014-09-26 1:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 16:20 [PATCH v2 0/3] ARM: vf610: Fix/add clocksource Stefan Agner
2014-09-24 16:20 ` Stefan Agner
2014-09-24 16:20 ` [PATCH v2 1/3] clocksource: vf_pit_timer: Support shutdown mode Stefan Agner
2014-09-24 16:20 ` Stefan Agner
2014-09-25 12:19 ` Sergei Shtylyov
2014-09-25 12:19 ` Sergei Shtylyov
2014-09-24 16:20 ` [PATCH v2 2/3] ARM: dts: vf610: Add ARM Global Timer Stefan Agner
2014-09-24 16:20 ` Stefan Agner
2014-09-26 1:41 ` Shawn Guo [this message]
2014-09-26 1:41 ` Shawn Guo
2014-09-24 16:20 ` [PATCH v2 3/3] ARM: vf610: Add ARM Global Timer clocksource option Stefan Agner
2014-09-24 16:20 ` Stefan Agner
2014-09-26 1:45 ` Shawn Guo
2014-09-26 1:45 ` Shawn Guo
2014-09-29 11:51 ` Shawn Guo
2014-09-29 11:51 ` Shawn Guo
2014-09-29 12:18 ` Stefan Agner
2014-09-29 12:18 ` Stefan Agner
2014-09-24 17:06 ` [PATCH v2 0/3] ARM: vf610: Fix/add clocksource Bill Pringlemeir
2014-09-24 17:06 ` Bill Pringlemeir
2014-09-26 7:01 ` Daniel Lezcano
2014-09-26 7:01 ` Daniel Lezcano
2014-09-26 7:24 ` Stefan Agner
2014-09-26 7:24 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926014126.GE21077@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.