All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
Date: Fri, 26 Sep 2014 10:07:46 +0800	[thread overview]
Message-ID: <20140926020745.GH21077@dragon> (raw)
In-Reply-To: <a0ecfce3f97fb6684657ae76b89f38108fcdf68f.1411122224.git.maitysanchayan@gmail.com>

On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote:
> Enable ADC support for Colibri VF61 modules
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-colibri.dtsi |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 0cd8343..6fd099e 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -27,6 +27,16 @@
>  
>  };
>  
> +&adc0 {
> +	pinctrl-names = "default";

Sorry for missing it, but I would expect properties pinctrl-names and
pinctrl-0 appear as a couple.  Should we drop property pinctrl-names
here?

Shawn

> +	status = "okay";
> +};
> +
> +&adc1 {
> +	pinctrl-names = "default";
> +	status = "okay";
> +};
> +
>  &esdhc1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_esdhc1>;
> -- 
> 1.7.9.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: <stefan@agner.ch>, <linux@arm.linux.org.uk>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support
Date: Fri, 26 Sep 2014 10:07:46 +0800	[thread overview]
Message-ID: <20140926020745.GH21077@dragon> (raw)
In-Reply-To: <a0ecfce3f97fb6684657ae76b89f38108fcdf68f.1411122224.git.maitysanchayan@gmail.com>

On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote:
> Enable ADC support for Colibri VF61 modules
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  arch/arm/boot/dts/vf610-colibri.dtsi |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 0cd8343..6fd099e 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -27,6 +27,16 @@
>  
>  };
>  
> +&adc0 {
> +	pinctrl-names = "default";

Sorry for missing it, but I would expect properties pinctrl-names and
pinctrl-0 appear as a couple.  Should we drop property pinctrl-names
here?

Shawn

> +	status = "okay";
> +};
> +
> +&adc1 {
> +	pinctrl-names = "default";
> +	status = "okay";
> +};
> +
>  &esdhc1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_esdhc1>;
> -- 
> 1.7.9.5
> 

  parent reply	other threads:[~2014-09-26  2:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 11:26 [PATCH v2] Enable ADC support for Colibri VF61 modules Sanchayan Maity
2014-09-19 11:26 ` Sanchayan Maity
2014-09-19 11:26 ` [PATCH v2] ARM: dts: vf610-colibri: Add ADC support Sanchayan Maity
2014-09-19 11:26   ` Sanchayan Maity
2014-09-19 16:22   ` Stefan Agner
2014-09-19 16:22     ` Stefan Agner
2014-09-26  2:07   ` Shawn Guo [this message]
2014-09-26  2:07     ` Shawn Guo
2014-09-26  9:44     ` Sanchayan Maity
2014-09-26  9:44       ` Sanchayan Maity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926020745.GH21077@dragon \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.