* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES [not found] <1410784339-25597-1-git-send-email-j-stiffler@ti.com> @ 2014-09-24 14:42 ` Stiffler, Jacob 2014-09-26 20:33 ` Cooper Jr., Franklin 0 siblings, 1 reply; 6+ messages in thread From: Stiffler, Jacob @ 2014-09-24 14:42 UTC (permalink / raw) To: meta-ti@yoctoproject.org ping -----Original Message----- From: Stiffler, Jacob Sent: Monday, September 15, 2014 8:32 AM To: meta-ti@yoctoproject.org Cc: Stiffler, Jacob Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> --- conf/machine/include/dra7xx.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/machine/include/dra7xx.inc b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 --- a/conf/machine/include/dra7xx.inc +++ b/conf/machine/include/dra7xx.inc @@ -1,4 +1,4 @@ require conf/machine/include/omap-a15.inc SOC_FAMILY_append = ":dra7xx" -MACHINE_FEATURES += "pci" +MACHINE_FEATURES += "pci mmip" -- 1.7.9.5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES 2014-09-24 14:42 ` [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES Stiffler, Jacob @ 2014-09-26 20:33 ` Cooper Jr., Franklin 2014-09-26 20:55 ` Denys Dmytriyenko 0 siblings, 1 reply; 6+ messages in thread From: Cooper Jr., Franklin @ 2014-09-26 20:33 UTC (permalink / raw) To: Stiffler, Jacob, meta-ti@yoctoproject.org So this patch shouldn't be needed. The only recipe that is using mmip is ipumm-fw. Currently the recipe has COMPATIBLE_MACHINE set to only omap-a15. So why do we also need to add this to the SOC family? Honestly for ipumm-fw the below code should be removed. python __anonymous() { features = bb.data.getVar("MACHINE_FEATURES", d, 1) if not features: return if "mmip" not in features: raise bb.parse.SkipPackage('ipumm-fw does not apply to systems without the "mmip" flag in MACHINE_FEATURES') } Plus this patch will break things for am57xx-evm. By allowing this change ipumm-fw would not be skipped for am57x evm and the current recipe will fail because of it. > -----Original Message----- > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > bounces@yoctoproject.org] On Behalf Of Stiffler, Jacob > Sent: Wednesday, September 24, 2014 9:42 AM > To: meta-ti@yoctoproject.org > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > MACHINE_FEATURES > > ping > > -----Original Message----- > From: Stiffler, Jacob > Sent: Monday, September 15, 2014 8:32 AM > To: meta-ti@yoctoproject.org > Cc: Stiffler, Jacob > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> > --- > conf/machine/include/dra7xx.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/conf/machine/include/dra7xx.inc > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 > --- a/conf/machine/include/dra7xx.inc > +++ b/conf/machine/include/dra7xx.inc > @@ -1,4 +1,4 @@ > require conf/machine/include/omap-a15.inc SOC_FAMILY_append = > ":dra7xx" > > -MACHINE_FEATURES += "pci" > +MACHINE_FEATURES += "pci mmip" > -- > 1.7.9.5 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES 2014-09-26 20:33 ` Cooper Jr., Franklin @ 2014-09-26 20:55 ` Denys Dmytriyenko 2014-09-26 21:09 ` Cooper Jr., Franklin 0 siblings, 1 reply; 6+ messages in thread From: Denys Dmytriyenko @ 2014-09-26 20:55 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-ti@yoctoproject.org On Fri, Sep 26, 2014 at 08:33:39PM +0000, Cooper Jr., Franklin wrote: > So this patch shouldn't be needed. > > The only recipe that is using mmip is ipumm-fw. Currently the recipe has > COMPATIBLE_MACHINE set to only omap-a15. So why do we also need to add this > to the SOC family? The above statement is not correct. The flag mmip in MACHINE_FEATURES was introduced to handle cases of hardware accelerated multimedia, when some software components needs to be replaced with "forked" patched and modified versions. Take a look at gstreamer pieces in meta-arago... > Honestly for ipumm-fw the below code should be removed. > python __anonymous() { > features = bb.data.getVar("MACHINE_FEATURES", d, 1) > if not features: > return > if "mmip" not in features: > raise bb.parse.SkipPackage('ipumm-fw does not apply to systems without the "mmip" flag in MACHINE_FEATURES') > } > > Plus this patch will break things for am57xx-evm. By allowing this change > ipumm-fw would not be skipped for am57x evm and the current recipe will fail > because of it. So, am57xx-evm should not build and load ipumm-fw is what you are saying? -- Denys > > -----Original Message----- > > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > > bounces@yoctoproject.org] On Behalf Of Stiffler, Jacob > > Sent: Wednesday, September 24, 2014 9:42 AM > > To: meta-ti@yoctoproject.org > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > MACHINE_FEATURES > > > > ping > > > > -----Original Message----- > > From: Stiffler, Jacob > > Sent: Monday, September 15, 2014 8:32 AM > > To: meta-ti@yoctoproject.org > > Cc: Stiffler, Jacob > > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES > > > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> > > --- > > conf/machine/include/dra7xx.inc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/conf/machine/include/dra7xx.inc > > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 > > --- a/conf/machine/include/dra7xx.inc > > +++ b/conf/machine/include/dra7xx.inc > > @@ -1,4 +1,4 @@ > > require conf/machine/include/omap-a15.inc SOC_FAMILY_append = > > ":dra7xx" > > > > -MACHINE_FEATURES += "pci" > > +MACHINE_FEATURES += "pci mmip" > > -- > > 1.7.9.5 > > > > -- > > _______________________________________________ > > meta-ti mailing list > > meta-ti@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/meta-ti > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES 2014-09-26 20:55 ` Denys Dmytriyenko @ 2014-09-26 21:09 ` Cooper Jr., Franklin 2014-09-26 21:44 ` Denys Dmytriyenko 0 siblings, 1 reply; 6+ messages in thread From: Cooper Jr., Franklin @ 2014-09-26 21:09 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Friday, September 26, 2014 3:55 PM > To: Cooper Jr., Franklin > Cc: Stiffler, Jacob; meta-ti@yoctoproject.org > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > MACHINE_FEATURES > > On Fri, Sep 26, 2014 at 08:33:39PM +0000, Cooper Jr., Franklin wrote: > > So this patch shouldn't be needed. > > > > The only recipe that is using mmip is ipumm-fw. Currently the recipe > > has COMPATIBLE_MACHINE set to only omap-a15. So why do we also > need to > > add this to the SOC family? > > The above statement is not correct. > > The flag mmip in MACHINE_FEATURES was introduced to handle cases of > hardware accelerated multimedia, when some software components needs > to be replaced with "forked" patched and modified versions. Take a look at > gstreamer pieces in meta-arago... [Franklin] Ah. My grep was only in meta-ti I missed the usage in meta-arago. > > > > Honestly for ipumm-fw the below code should be removed. > > python __anonymous() { > > features = bb.data.getVar("MACHINE_FEATURES", d, 1) > > if not features: > > return > > if "mmip" not in features: > > raise bb.parse.SkipPackage('ipumm-fw does not apply to > > systems without the "mmip" flag in MACHINE_FEATURES') } > > > > Plus this patch will break things for am57xx-evm. By allowing this > > change ipumm-fw would not be skipped for am57x evm and the current > > recipe will fail because of it. > > So, am57xx-evm should not build and load ipumm-fw is what you are saying? [Franklin] I didn't realize that dra7xx was used for am57x-evm. So it will build. So this patch is fine but I'm still pretty confused by the usage of mmip. Now that mmip is added to omap-a15 SOC family can we now remove skip package code from all the various recipes that use mmip and simply replace it with COMPATIBLE_MACHINE? > > -- > Denys > > > > > -----Original Message----- > > > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > > > bounces@yoctoproject.org] On Behalf Of Stiffler, Jacob > > > Sent: Wednesday, September 24, 2014 9:42 AM > > > To: meta-ti@yoctoproject.org > > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > > MACHINE_FEATURES > > > > > > ping > > > > > > -----Original Message----- > > > From: Stiffler, Jacob > > > Sent: Monday, September 15, 2014 8:32 AM > > > To: meta-ti@yoctoproject.org > > > Cc: Stiffler, Jacob > > > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES > > > > > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> > > > --- > > > conf/machine/include/dra7xx.inc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/conf/machine/include/dra7xx.inc > > > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 > > > --- a/conf/machine/include/dra7xx.inc > > > +++ b/conf/machine/include/dra7xx.inc > > > @@ -1,4 +1,4 @@ > > > require conf/machine/include/omap-a15.inc SOC_FAMILY_append = > > > ":dra7xx" > > > > > > -MACHINE_FEATURES += "pci" > > > +MACHINE_FEATURES += "pci mmip" > > > -- > > > 1.7.9.5 > > > > > > -- > > > _______________________________________________ > > > meta-ti mailing list > > > meta-ti@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/meta-ti > > -- > > _______________________________________________ > > meta-ti mailing list > > meta-ti@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES 2014-09-26 21:09 ` Cooper Jr., Franklin @ 2014-09-26 21:44 ` Denys Dmytriyenko 2014-09-26 21:49 ` Cooper Jr., Franklin 0 siblings, 1 reply; 6+ messages in thread From: Denys Dmytriyenko @ 2014-09-26 21:44 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-ti@yoctoproject.org On Fri, Sep 26, 2014 at 05:09:26PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Friday, September 26, 2014 3:55 PM > > To: Cooper Jr., Franklin > > Cc: Stiffler, Jacob; meta-ti@yoctoproject.org > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > MACHINE_FEATURES > > > > On Fri, Sep 26, 2014 at 08:33:39PM +0000, Cooper Jr., Franklin wrote: > > > So this patch shouldn't be needed. > > > > > > The only recipe that is using mmip is ipumm-fw. Currently the recipe > > > has COMPATIBLE_MACHINE set to only omap-a15. So why do we also > > need to > > > add this to the SOC family? > > > > The above statement is not correct. > > > > The flag mmip in MACHINE_FEATURES was introduced to handle cases of > > hardware accelerated multimedia, when some software components needs > > to be replaced with "forked" patched and modified versions. Take a look at > > gstreamer pieces in meta-arago... > [Franklin] Ah. My grep was only in meta-ti I missed the usage in meta-arago. > > > > > > > Honestly for ipumm-fw the below code should be removed. > > > python __anonymous() { > > > features = bb.data.getVar("MACHINE_FEATURES", d, 1) > > > if not features: > > > return > > > if "mmip" not in features: > > > raise bb.parse.SkipPackage('ipumm-fw does not apply to > > > systems without the "mmip" flag in MACHINE_FEATURES') } > > > > > > Plus this patch will break things for am57xx-evm. By allowing this > > > change ipumm-fw would not be skipped for am57x evm and the current > > > recipe will fail because of it. > > > > So, am57xx-evm should not build and load ipumm-fw is what you are saying? > [Franklin] I didn't realize that dra7xx was used for am57x-evm. So it will build. > > So this patch is fine but I'm still pretty confused by the usage of mmip. > Now that mmip is added to omap-a15 SOC family can we now remove skip package > code from all the various recipes that use mmip and simply replace it with > COMPATIBLE_MACHINE? Why are you saying "mmip" is added to omap-a15? I think there are some differences between OMAP5 and DRA7x/J6 in the MM department, although they are based on the same omap-a15 SOC family. That was one of the reasons "mmip" was introduced... Also, you can't do COMPATIBLE_MACHINE for gstreamer and co. Currently the correct variant of mainline vs. forked gstreamer is being selected by "mmip" flag in meta-arago distro config: PREFERRED_PROVIDER_gstreamer = "${@base_contains('MACHINE_FEATURES', 'mmip', 'gstreamer-mm-accel', 'gstreamer', d)}" -- Denys > > -- > > Denys > > > > > > > > -----Original Message----- > > > > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > > > > bounces@yoctoproject.org] On Behalf Of Stiffler, Jacob > > > > Sent: Wednesday, September 24, 2014 9:42 AM > > > > To: meta-ti@yoctoproject.org > > > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > > > MACHINE_FEATURES > > > > > > > > ping > > > > > > > > -----Original Message----- > > > > From: Stiffler, Jacob > > > > Sent: Monday, September 15, 2014 8:32 AM > > > > To: meta-ti@yoctoproject.org > > > > Cc: Stiffler, Jacob > > > > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES > > > > > > > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> > > > > --- > > > > conf/machine/include/dra7xx.inc | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/conf/machine/include/dra7xx.inc > > > > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 > > > > --- a/conf/machine/include/dra7xx.inc > > > > +++ b/conf/machine/include/dra7xx.inc > > > > @@ -1,4 +1,4 @@ > > > > require conf/machine/include/omap-a15.inc SOC_FAMILY_append = > > > > ":dra7xx" > > > > > > > > -MACHINE_FEATURES += "pci" > > > > +MACHINE_FEATURES += "pci mmip" > > > > -- > > > > 1.7.9.5 > > > > > > > > -- > > > > _______________________________________________ > > > > meta-ti mailing list > > > > meta-ti@yoctoproject.org > > > > https://lists.yoctoproject.org/listinfo/meta-ti > > > -- > > > _______________________________________________ > > > meta-ti mailing list > > > meta-ti@yoctoproject.org > > > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES 2014-09-26 21:44 ` Denys Dmytriyenko @ 2014-09-26 21:49 ` Cooper Jr., Franklin 0 siblings, 0 replies; 6+ messages in thread From: Cooper Jr., Franklin @ 2014-09-26 21:49 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Friday, September 26, 2014 4:44 PM > To: Cooper Jr., Franklin > Cc: Stiffler, Jacob; meta-ti@yoctoproject.org > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > MACHINE_FEATURES > > On Fri, Sep 26, 2014 at 05:09:26PM -0400, Cooper Jr., Franklin wrote: > > > > > > > -----Original Message----- > > > From: Dmytriyenko, Denys > > > Sent: Friday, September 26, 2014 3:55 PM > > > To: Cooper Jr., Franklin > > > Cc: Stiffler, Jacob; meta-ti@yoctoproject.org > > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > > MACHINE_FEATURES > > > > > > On Fri, Sep 26, 2014 at 08:33:39PM +0000, Cooper Jr., Franklin wrote: > > > > So this patch shouldn't be needed. > > > > > > > > The only recipe that is using mmip is ipumm-fw. Currently the > > > > recipe has COMPATIBLE_MACHINE set to only omap-a15. So why do > we > > > > also > > > need to > > > > add this to the SOC family? > > > > > > The above statement is not correct. > > > > > > The flag mmip in MACHINE_FEATURES was introduced to handle cases of > > > hardware accelerated multimedia, when some software components > needs > > > to be replaced with "forked" patched and modified versions. Take a > > > look at gstreamer pieces in meta-arago... > > [Franklin] Ah. My grep was only in meta-ti I missed the usage in meta- > arago. > > > > > > > > > > Honestly for ipumm-fw the below code should be removed. > > > > python __anonymous() { > > > > features = bb.data.getVar("MACHINE_FEATURES", d, 1) > > > > if not features: > > > > return > > > > if "mmip" not in features: > > > > raise bb.parse.SkipPackage('ipumm-fw does not apply to > > > > systems without the "mmip" flag in MACHINE_FEATURES') } > > > > > > > > Plus this patch will break things for am57xx-evm. By allowing this > > > > change ipumm-fw would not be skipped for am57x evm and the current > > > > recipe will fail because of it. > > > > > > So, am57xx-evm should not build and load ipumm-fw is what you are > saying? > > [Franklin] I didn't realize that dra7xx was used for am57x-evm. So it will > build. > > > > So this patch is fine but I'm still pretty confused by the usage of mmip. > > Now that mmip is added to omap-a15 SOC family can we now remove skip > > package code from all the various recipes that use mmip and simply > > replace it with COMPATIBLE_MACHINE? > > Why are you saying "mmip" is added to omap-a15? I think there are some > differences between OMAP5 and DRA7x/J6 in the MM department, although > they are based on the same omap-a15 SOC family. That was one of the > reasons "mmip" > was introduced... > > Also, you can't do COMPATIBLE_MACHINE for gstreamer and co. Currently > the correct variant of mainline vs. forked gstreamer is being selected by > "mmip" > flag in meta-arago distro config: > > PREFERRED_PROVIDER_gstreamer = > "${@base_contains('MACHINE_FEATURES', 'mmip', 'gstreamer-mm-accel', > 'gstreamer', d)}" [Franklin] I completely misread this patch when I first looked at it. Everything makes sense and this patch is fine as is. > > -- > Denys > > > > > -- > > > Denys > > > > > > > > > > > -----Original Message----- > > > > > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti- > > > > > bounces@yoctoproject.org] On Behalf Of Stiffler, Jacob > > > > > Sent: Wednesday, September 24, 2014 9:42 AM > > > > > To: meta-ti@yoctoproject.org > > > > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to > > > > > MACHINE_FEATURES > > > > > > > > > > ping > > > > > > > > > > -----Original Message----- > > > > > From: Stiffler, Jacob > > > > > Sent: Monday, September 15, 2014 8:32 AM > > > > > To: meta-ti@yoctoproject.org > > > > > Cc: Stiffler, Jacob > > > > > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES > > > > > > > > > > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com> > > > > > --- > > > > > conf/machine/include/dra7xx.inc | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/conf/machine/include/dra7xx.inc > > > > > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644 > > > > > --- a/conf/machine/include/dra7xx.inc > > > > > +++ b/conf/machine/include/dra7xx.inc > > > > > @@ -1,4 +1,4 @@ > > > > > require conf/machine/include/omap-a15.inc SOC_FAMILY_append = > > > > > ":dra7xx" > > > > > > > > > > -MACHINE_FEATURES += "pci" > > > > > +MACHINE_FEATURES += "pci mmip" > > > > > -- > > > > > 1.7.9.5 > > > > > > > > > > -- > > > > > _______________________________________________ > > > > > meta-ti mailing list > > > > > meta-ti@yoctoproject.org > > > > > https://lists.yoctoproject.org/listinfo/meta-ti > > > > -- > > > > _______________________________________________ > > > > meta-ti mailing list > > > > meta-ti@yoctoproject.org > > > > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-26 21:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1410784339-25597-1-git-send-email-j-stiffler@ti.com>
2014-09-24 14:42 ` [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES Stiffler, Jacob
2014-09-26 20:33 ` Cooper Jr., Franklin
2014-09-26 20:55 ` Denys Dmytriyenko
2014-09-26 21:09 ` Cooper Jr., Franklin
2014-09-26 21:44 ` Denys Dmytriyenko
2014-09-26 21:49 ` Cooper Jr., Franklin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.