From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init
Date: Fri, 26 Sep 2014 22:13:31 +0200 [thread overview]
Message-ID: <201409262213.31848.arnd@arndb.de> (raw)
In-Reply-To: <1410434561-9294-2-git-send-email-m.szyprowski@samsung.com>
On Thursday 11 September 2014, Marek Szyprowski wrote:
> -void of_reserved_mem_device_init(struct device *dev)
> +int of_reserved_mem_device_init(struct device *dev)
> {
> struct reserved_mem *rmem;
> struct device_node *np;
> @@ -260,6 +260,7 @@ void of_reserved_mem_device_init(struct device *dev)
>
> rmem->ops->device_init(rmem, dev);
> dev_info(dev, "assigned reserved memory node %s\n", rmem->name);
> + return 0;
> }
This function has two other 'return' statements that now are missing
a return value for the error case and cause undefined behavior
in the caller.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
Laura Abbott <lauraa@codeaurora.org>,
Josh Cartwright <joshc@codeaurora.org>,
Michal Nazarewicz <mina86@mina86.com>,
linaro-mm-sig@lists.linaro.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Grant Likely <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init
Date: Fri, 26 Sep 2014 22:13:31 +0200 [thread overview]
Message-ID: <201409262213.31848.arnd@arndb.de> (raw)
In-Reply-To: <1410434561-9294-2-git-send-email-m.szyprowski@samsung.com>
On Thursday 11 September 2014, Marek Szyprowski wrote:
> -void of_reserved_mem_device_init(struct device *dev)
> +int of_reserved_mem_device_init(struct device *dev)
> {
> struct reserved_mem *rmem;
> struct device_node *np;
> @@ -260,6 +260,7 @@ void of_reserved_mem_device_init(struct device *dev)
>
> rmem->ops->device_init(rmem, dev);
> dev_info(dev, "assigned reserved memory node %s\n", rmem->name);
> + return 0;
> }
This function has two other 'return' statements that now are missing
a return value for the error case and cause undefined behavior
in the caller.
Arnd
next prev parent reply other threads:[~2014-09-26 20:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 11:22 [PATCH v2 0/3] CMA & device tree, another approach Marek Szyprowski
2014-09-11 11:22 ` Marek Szyprowski
2014-09-11 11:22 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init Marek Szyprowski
2014-09-11 11:22 ` Marek Szyprowski
2014-09-26 6:44 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init (fixup) Marek Szyprowski
2014-09-26 6:44 ` Marek Szyprowski
2014-09-27 13:58 ` Fabio Estevam
2014-09-27 13:58 ` Fabio Estevam
2014-09-26 20:13 ` Arnd Bergmann [this message]
2014-09-26 20:13 ` [PATCH v2 1/3] drivers: of: add return value to of_reserved_mem_device_init Arnd Bergmann
2014-10-09 12:18 ` [PATCH v3] " Marek Szyprowski
2014-10-09 12:18 ` Marek Szyprowski
2014-10-13 11:19 ` Arnd Bergmann
2014-10-13 11:19 ` Arnd Bergmann
2014-10-15 11:01 ` [PATCH v4] " Marek Szyprowski
2014-10-15 11:01 ` Marek Szyprowski
2014-10-20 19:04 ` [Linaro-mm-sig] " Arnd Bergmann
2014-10-20 19:04 ` Arnd Bergmann
2014-09-11 11:22 ` [PATCH v2 2/3] drivers: dma-coherent: add initialization from device tree Marek Szyprowski
2014-09-11 11:22 ` Marek Szyprowski
2014-09-24 22:26 ` Andrew Morton
2014-09-24 22:26 ` Andrew Morton
2014-09-24 22:28 ` Andrew Morton
2014-09-24 22:28 ` Andrew Morton
2014-09-11 11:22 ` [PATCH v2 3/3] drivers: dma-contiguous: " Marek Szyprowski
2014-09-11 11:22 ` Marek Szyprowski
2014-09-23 8:05 ` [PATCH v2 0/3] CMA & device tree, another approach Marek Szyprowski
2014-09-23 8:05 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409262213.31848.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.