* Legacy Code in gpmc-onenand.c
@ 2014-09-28 2:37 ` nick
0 siblings, 0 replies; 6+ messages in thread
From: nick @ 2014-09-28 2:37 UTC (permalink / raw)
To: khilman; +Cc: linux, linux-omap, linux-arm-kernel, linux-kernel
Greetings Kevin and others,
I am wondering if the below code is legacy I can remove it as stated it the fix me.
Cheers Nick
else {
/*
* FIX ME: Appears to be legacy code from initial ONENAND commit.
* Unclear what boards this is for and if this can be removed.
*/
if (!cpu_is_omap34xx())
onenand_sync.wait_on_read = true;
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Legacy Code in gpmc-onenand.c
@ 2014-09-28 2:37 ` nick
0 siblings, 0 replies; 6+ messages in thread
From: nick @ 2014-09-28 2:37 UTC (permalink / raw)
To: linux-arm-kernel
Greetings Kevin and others,
I am wondering if the below code is legacy I can remove it as stated it the fix me.
Cheers Nick
else {
/*
* FIX ME: Appears to be legacy code from initial ONENAND commit.
* Unclear what boards this is for and if this can be removed.
*/
if (!cpu_is_omap34xx())
onenand_sync.wait_on_read = true;
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Legacy Code in gpmc-onenand.c
2014-09-28 2:37 ` nick
@ 2014-09-28 2:51 ` Al Viro
-1 siblings, 0 replies; 6+ messages in thread
From: Al Viro @ 2014-09-28 2:51 UTC (permalink / raw)
To: nick; +Cc: khilman, linux, linux-omap, linux-arm-kernel, linux-kernel
On Sat, Sep 27, 2014 at 10:37:02PM -0400, nick wrote:
> Greetings Kevin and others,
> I am wondering if the below code is legacy I can remove it as stated it the fix me.
> Cheers Nick
Nick, could you take that to more appropriate forum? alt.sex.fetish.FIXME
would probably be a good starting point...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Legacy Code in gpmc-onenand.c
2014-09-28 2:37 ` nick
@ 2014-09-28 16:14 ` Sudip Mukherjee
-1 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2014-09-28 16:14 UTC (permalink / raw)
To: nick; +Cc: khilman, linux, linux-omap, linux-arm-kernel, linux-kernel
On Sat, Sep 27, 2014 at 10:37:02PM -0400, nick wrote:
> Greetings Kevin and others,
> I am wondering if the below code is legacy I can remove it as stated it the fix me.
> Cheers Nick
> else {
> /*
> * FIX ME: Appears to be legacy code from initial ONENAND commit.
> * Unclear what boards this is for and if this can be removed.
> */
> if (!cpu_is_omap34xx())
> onenand_sync.wait_on_read = true;
> }
the FIX ME does not say that you can remove the code. It says you need to find out that the code is being used by which board. And if you want to remove it then you have to explain why the code is removed , and after removing what will be the effect , and if there is no effect then why there is no effect.
Good Luck.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread* Legacy Code in gpmc-onenand.c
@ 2014-09-28 16:14 ` Sudip Mukherjee
0 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2014-09-28 16:14 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 27, 2014 at 10:37:02PM -0400, nick wrote:
> Greetings Kevin and others,
> I am wondering if the below code is legacy I can remove it as stated it the fix me.
> Cheers Nick
> else {
> /*
> * FIX ME: Appears to be legacy code from initial ONENAND commit.
> * Unclear what boards this is for and if this can be removed.
> */
> if (!cpu_is_omap34xx())
> onenand_sync.wait_on_read = true;
> }
the FIX ME does not say that you can remove the code. It says you need to find out that the code is being used by which board. And if you want to remove it then you have to explain why the code is removed , and after removing what will be the effect , and if there is no effect then why there is no effect.
Good Luck.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-28 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-28 2:37 Legacy Code in gpmc-onenand.c nick
2014-09-28 2:37 ` nick
2014-09-28 2:51 ` Al Viro
2014-09-28 2:51 ` Al Viro
2014-09-28 16:14 ` Sudip Mukherjee
2014-09-28 16:14 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.