From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: imx-sdma: fix another incorrect __init annotation
Date: Sun, 28 Sep 2014 21:30:41 +0530 [thread overview]
Message-ID: <20140928160040.GI1638@intel.com> (raw)
In-Reply-To: <38530464.3ymIRX74DK@wuerfel>
On Fri, Sep 26, 2014 at 11:24:00PM +0200, Arnd Bergmann wrote:
> In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on
> sdma_probe()"), Mark found an extraneous __init label and fixed it.
>
> However, he missed another one, because now we get this other warning:
>
> WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware()
> The function sdma_probe() references
> the function __init sdma_get_firmware().
>
> Same reasoning as the last time, the function may get called at
> runtime, so it can't be __init.
>
Applied, thanks
--
~Vinod
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 52ce1d21154c..88afc48c2ca7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1334,7 +1334,7 @@ err_firmware:
> release_firmware(fw);
> }
>
> -static int __init sdma_get_firmware(struct sdma_engine *sdma,
> +static int sdma_get_firmware(struct sdma_engine *sdma,
> const char *fw_name)
> {
> int ret;
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Brown <broonie@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma: imx-sdma: fix another incorrect __init annotation
Date: Sun, 28 Sep 2014 21:30:41 +0530 [thread overview]
Message-ID: <20140928160040.GI1638@intel.com> (raw)
In-Reply-To: <38530464.3ymIRX74DK@wuerfel>
On Fri, Sep 26, 2014 at 11:24:00PM +0200, Arnd Bergmann wrote:
> In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on
> sdma_probe()"), Mark found an extraneous __init label and fixed it.
>
> However, he missed another one, because now we get this other warning:
>
> WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware()
> The function sdma_probe() references
> the function __init sdma_get_firmware().
>
> Same reasoning as the last time, the function may get called at
> runtime, so it can't be __init.
>
Applied, thanks
--
~Vinod
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 52ce1d21154c..88afc48c2ca7 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1334,7 +1334,7 @@ err_firmware:
> release_firmware(fw);
> }
>
> -static int __init sdma_get_firmware(struct sdma_engine *sdma,
> +static int sdma_get_firmware(struct sdma_engine *sdma,
> const char *fw_name)
> {
> int ret;
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
next prev parent reply other threads:[~2014-09-28 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 21:24 [PATCH] dma: imx-sdma: fix another incorrect __init annotation Arnd Bergmann
2014-09-26 21:24 ` Arnd Bergmann
2014-09-28 16:00 ` Vinod Koul [this message]
2014-09-28 16:00 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928160040.GI1638@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.