From: Josh Triplett <josh@joshtriplett.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-mtd@lists.infradead.org, linux-sparse@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
Date: Sun, 28 Sep 2014 17:02:44 -0700 [thread overview]
Message-ID: <20140929000243.GA1353@thin> (raw)
In-Reply-To: <1411932392-7751-1-git-send-email-fabf@skynet.be>
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote:
> fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
>
> Suggested-by: Brian Norris <computersforpeace@gmail.com>
> Suggested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> V2: use __must_hold instead of __releases / __acquires
> (suggested by Brian Norris and Josh Triplett)
>
> fs/jffs2/summary.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index c522d09..bc53854 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
> /* Write out summary information - called from jffs2_do_reserve_space */
>
> int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
> + __must_hold(&c->erase_completion_block)
> {
> int datasize, infosize, padsize;
> struct jffs2_eraseblock *jeb;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
Date: Sun, 28 Sep 2014 17:02:44 -0700 [thread overview]
Message-ID: <20140929000243.GA1353@thin> (raw)
In-Reply-To: <1411932392-7751-1-git-send-email-fabf@skynet.be>
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote:
> fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
>
> Suggested-by: Brian Norris <computersforpeace@gmail.com>
> Suggested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> V2: use __must_hold instead of __releases / __acquires
> (suggested by Brian Norris and Josh Triplett)
>
> fs/jffs2/summary.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index c522d09..bc53854 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
> /* Write out summary information - called from jffs2_do_reserve_space */
>
> int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
> + __must_hold(&c->erase_completion_block)
> {
> int datasize, infosize, padsize;
> struct jffs2_eraseblock *jeb;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-29 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 19:26 [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock Fabian Frederick
2014-09-28 19:26 ` Fabian Frederick
2014-09-29 0:02 ` Josh Triplett [this message]
2014-09-29 0:02 ` Josh Triplett
2014-10-22 8:40 ` Brian Norris
2014-10-22 8:40 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929000243.GA1353@thin \
--to=josh@joshtriplett.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.