* [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues
@ 2014-09-25 23:08 Mike Roocroft
2014-09-29 2:00 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Mike Roocroft @ 2014-09-25 23:08 UTC (permalink / raw)
To: gregkh; +Cc: swetland, devel, linux-kernel, Mike Roocroft
Signed-off-by: Mike Roocroft <mike.linux@btinternet.com>
---
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
char *str, int size)
{
struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
snprintf(str, size, "%d", pt->value);
}
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
static int sw_sync_release(struct inode *inode, struct file *file)
{
struct sw_sync_timeline *obj = file->private_data;
+
sync_timeline_destroy(&obj->obj);
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues
@ 2014-09-25 23:11 Mike Roocroft
2014-09-27 15:01 ` Sudip Mukherjee
0 siblings, 1 reply; 4+ messages in thread
From: Mike Roocroft @ 2014-09-25 23:11 UTC (permalink / raw)
To: gregkh; +Cc: swetland, devel, linux-kernel, Mike Roocroft
Signed-off-by: Mike Roocroft <mike.linux@btinternet.com>
---
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index a76db3f..863d4b1 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
char *str, int size)
{
struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
snprintf(str, size, "%d", pt->value);
}
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
static int sw_sync_release(struct inode *inode, struct file *file)
{
struct sw_sync_timeline *obj = file->private_data;
+
sync_timeline_destroy(&obj->obj);
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues
2014-09-25 23:11 Mike Roocroft
@ 2014-09-27 15:01 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2014-09-27 15:01 UTC (permalink / raw)
To: Mike Roocroft; +Cc: gregkh, swetland, devel, linux-kernel
On Fri, Sep 26, 2014 at 12:11:56AM +0100, Mike Roocroft wrote:
you forgot to write the commit message and also mention there what kind of warning you have fixed.
thanks
sudip
> Signed-off-by: Mike Roocroft <mike.linux@btinternet.com>
> ---
> drivers/staging/android/sw_sync.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
> index a76db3f..863d4b1 100644
> --- a/drivers/staging/android/sw_sync.c
> +++ b/drivers/staging/android/sw_sync.c
> @@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
> char *str, int size)
> {
> struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
> +
> snprintf(str, size, "%d", pt->value);
> }
>
> @@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
> static int sw_sync_release(struct inode *inode, struct file *file)
> {
> struct sw_sync_timeline *obj = file->private_data;
> +
> sync_timeline_destroy(&obj->obj);
> return 0;
> }
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues
2014-09-25 23:08 [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues Mike Roocroft
@ 2014-09-29 2:00 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-09-29 2:00 UTC (permalink / raw)
To: Mike Roocroft; +Cc: devel, swetland, linux-kernel
On Fri, Sep 26, 2014 at 12:08:22AM +0100, Mike Roocroft wrote:
> Signed-off-by: Mike Roocroft <mike.linux@btinternet.com>
What coding style issues?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-29 6:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-25 23:08 [PATCH 2/2] Staging: android: sw_sync: fixed a coding style issues Mike Roocroft
2014-09-29 2:00 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-09-25 23:11 Mike Roocroft
2014-09-27 15:01 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.