All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org,
	sparclinux <sparclinux@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Sam Ravnborg <sam@ravnborg.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()
Date: Mon, 29 Sep 2014 10:59:09 +0200	[thread overview]
Message-ID: <20140929085908.GI12506@ulmo> (raw)
In-Reply-To: <CAMuHMdW4emoma3nRUGna985tE17yPh5pNjMb-jxe5yc5UVr=cw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > #ifndef memset_io
> > -#define memset_io(a, b, c)     memset(__io_virt(a), (b), (c))
> > +#define memset_io memset_io
> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
> > +{
> > +       memset(__io_virt(addr), value, size);
> > +}
> >  #endif
> 
> xtensa/allmodconfig:
> 
> include/asm-generic/io.h:820:2: error: implicit declaration of
> function 'memset' [-Werror=implicit-function-declaration]
> include/asm-generic/io.h:829:2: error: implicit declaration of
> function 'memcpy' [-Werror=implicit-function-declaration]
> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/

I think this can be fixed by including linux/string.h for memset() and
memcpy() in include/asm-generic/io.h.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Linux-Arch <linux-arch@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-serial@vger.kernel.org,
	sparclinux <sparclinux@vger.kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Sam Ravnborg <sam@ravnborg.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()
Date: Mon, 29 Sep 2014 08:59:09 +0000	[thread overview]
Message-ID: <20140929085908.GI12506@ulmo> (raw)
In-Reply-To: <CAMuHMdW4emoma3nRUGna985tE17yPh5pNjMb-jxe5yc5UVr=cw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > #ifndef memset_io
> > -#define memset_io(a, b, c)     memset(__io_virt(a), (b), (c))
> > +#define memset_io memset_io
> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
> > +{
> > +       memset(__io_virt(addr), value, size);
> > +}
> >  #endif
> 
> xtensa/allmodconfig:
> 
> include/asm-generic/io.h:820:2: error: implicit declaration of
> function 'memset' [-Werror=implicit-function-declaration]
> include/asm-generic/io.h:829:2: error: implicit declaration of
> function 'memcpy' [-Werror=implicit-function-declaration]
> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/

I think this can be fixed by including linux/string.h for memset() and
memcpy() in include/asm-generic/io.h.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*()
Date: Mon, 29 Sep 2014 10:59:09 +0200	[thread overview]
Message-ID: <20140929085908.GI12506@ulmo> (raw)
In-Reply-To: <CAMuHMdW4emoma3nRUGna985tE17yPh5pNjMb-jxe5yc5UVr=cw@mail.gmail.com>

On Mon, Sep 29, 2014 at 10:54:34AM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 13, 2014 at 12:28 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> > #ifndef memset_io
> > -#define memset_io(a, b, c)     memset(__io_virt(a), (b), (c))
> > +#define memset_io memset_io
> > +static inline void memset_io(void __iomem *addr, int value, size_t size)
> > +{
> > +       memset(__io_virt(addr), value, size);
> > +}
> >  #endif
> 
> xtensa/allmodconfig:
> 
> include/asm-generic/io.h:820:2: error: implicit declaration of
> function 'memset' [-Werror=implicit-function-declaration]
> include/asm-generic/io.h:829:2: error: implicit declaration of
> function 'memcpy' [-Werror=implicit-function-declaration]
> arch/xtensa/include/asm/string.h:110:14: error: conflicting types for 'memset'
> arch/xtensa/include/asm/string.h:113:14: error: conflicting types for 'memcpy'
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12028900/

I think this can be fixed by including linux/string.h for memset() and
memcpy() in include/asm-generic/io.h.

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140929/9eeff4dc/attachment-0001.sig>

  reply	other threads:[~2014-09-29  8:59 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13 10:28 [PATCH v4 0/8] asm-generic/io.h overhaul Thierry Reding
2014-08-13 10:28 ` Thierry Reding
2014-08-13 10:28 ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 1/8] ARC: Remove redundant PCI_IOBASE declaration Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 2/8] serial: sunzilog: Remove unnecessary volatile keyword Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 3/8] sparc: Remove unnecessary volatile usage Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 4/8] [IA64] Change xlate_dev_{kmem,mem}_ptr() prototypes Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 5/8] /dev/mem: Use more consistent data types Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*() Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-09-29  8:54   ` Geert Uytterhoeven
2014-09-29  8:54     ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read, write}s*() Geert Uytterhoeven
2014-09-29  8:54     ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*() Geert Uytterhoeven
2014-09-29  8:59     ` Thierry Reding [this message]
2014-09-29  8:59       ` Thierry Reding
2014-09-29  8:59       ` Thierry Reding
2014-09-30 10:22       ` Max Filippov
2014-09-30 10:22         ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read, write}s*() Max Filippov
2014-09-30 10:22         ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*() Max Filippov
2014-09-30 10:26         ` Max Filippov
2014-09-30 10:26           ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read, write}s*() Max Filippov
2014-09-30 10:26           ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*() Max Filippov
2014-09-30 10:39           ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read, write}s*() Arnd Bergmann
2014-09-30 10:39             ` Arnd Bergmann
2014-09-30 10:39             ` [PATCH v4 6/8] asm-generic/io.h: Implement generic {read,write}s*() Arnd Bergmann
2014-09-30 10:39             ` Arnd Bergmann
2014-09-30 10:39             ` Arnd Bergmann
2014-09-30 10:51             ` Thierry Reding
2014-09-30 10:51               ` Thierry Reding
2014-09-30 10:51               ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 7/8] ARM: Use include/asm-generic/io.h Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28 ` [PATCH v4 8/8] arm64: " Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-13 10:28   ` Thierry Reding
2014-08-25 11:26 ` [PATCH v4 0/8] asm-generic/io.h overhaul Thierry Reding
2014-08-25 11:26   ` Thierry Reding
2014-08-25 11:26   ` Thierry Reding
2014-09-24  6:04   ` Thierry Reding
2014-09-24  6:04     ` Thierry Reding
2014-09-24  6:04     ` Thierry Reding
2014-09-25 14:56     ` Arnd Bergmann
2014-09-25 14:56       ` Arnd Bergmann
2014-09-25 14:56       ` Arnd Bergmann
2014-08-25 11:53 ` Richard Weinberger
2014-08-25 11:53   ` Richard Weinberger
2014-08-25 11:53   ` Richard Weinberger
2014-08-25 12:27   ` Thierry Reding
2014-08-25 12:27     ` Thierry Reding
2014-08-25 12:27     ` Thierry Reding
2014-08-25 12:52     ` Richard Weinberger
2014-08-25 12:52       ` Richard Weinberger
2014-08-25 12:52       ` Richard Weinberger
2014-08-25 13:37       ` Thierry Reding
2014-08-25 13:37         ` Thierry Reding
2014-08-25 13:37         ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929085908.GI12506@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    --cc=sboyd@codeaurora.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.